Commits · 1c8b378ffb8779d8258771935457ed7ced2132af · abdullh.alsoleman / Front-End

27 Mar, 2024 2 commits

Update localization files. (#145780) · 1c8b378f
godofredoc authored Mar 27, 2024
```
Update the localization files to be used in the upcoming stable release.
```
1c8b378f

Roll Flutter Engine from 026d8902e3b5 to 92ebd47dd8a8 (1 revision) (#145788) · d07a0b56

engine-flutter-autoroll authored Mar 27, 2024

https://github.com/flutter/engine/compare/026d8902e3b5...92ebd47dd8a8

2024-03-26 jonahwilliams@google.com [Impeller] use screen space coordinates for dithering. (flutter/engine#51668)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d07a0b56

26 Mar, 2024 17 commits

[web] Add BackgroundIsolateBinaryMessenger.ensureInitialized to web. (#145786) · 97866824

David Iglesias authored Mar 26, 2024

This PR makes the static API of the `BackgroundIsolateBinaryMessenger` consistent between its web and IO implementations.

This way, multi-platform applications will compile for the web when using the `ensureInitialized` method (even though it'll throw at runtime, like the `instance` getter, because isolates are not supported on the web).

### Issues

* Fixes: https://github.com/flutter/flutter/issues/145260

97866824

Bump codecov/codecov-action from 4.1.0 to 4.1.1 (#145787) · d2a19380

dependabot[bot] authored Mar 26, 2024

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.1.0 to 4.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v4.1.1</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump github/codeql-action from 3.24.5 to 3.24.6 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1315">codecov/codecov-action#1315</a></li>
<li>build(deps-dev): bump typescript from 5.3.3 to 5.4.2 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1319">codecov/codecov-action#1319</a></li>
<li>Removed mention of Mercurial by <a href="https://github.com/drazisil-codecov"><code>@âdrazisil-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1325">codecov/codecov-action#1325</a></li>
<li>build(deps): bump github/codeql-action from 3.24.6 to 3.24.7 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1332">codecov/codecov-action#1332</a></li>
<li>build(deps): bump actions/checkout from 4.1.1 to 4.1.2 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1331">codecov/codecov-action#1331</a></li>
<li>fix: force version by <a href="https://github.com/thomasrockhu-codecov"><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1329">codecov/codecov-action#1329</a></li>
<li>build(deps-dev): bump typescript from 5.4.2 to 5.4.3 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1334">codecov/codecov-action#1334</a></li>
<li>build(deps): bump undici from 5.28.2 to 5.28.3 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1338">codecov/codecov-action#1338</a></li>
<li>build(deps): bump github/codeql-action from 3.24.7 to 3.24.9 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1341">codecov/codecov-action#1341</a></li>
<li>fix: typo in disable_safe_directory by <a href="https://github.com/mkroening"><code>@âmkroening</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1343">codecov/codecov-action#1343</a></li>
<li>chore(release): 4.1.1 by <a href="https://github.com/thomasrockhu-codecov"><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1344">codecov/codecov-action#1344</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/mkroening"><code>@âmkroening</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1343">codecov/codecov-action#1343</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.1.0...v4.1.1">https://github.com/codecov/codecov-action/compare/v4.1.0...v4.1.1</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md">codecov/codecov-action's changelog</a>.</em></p>
<blockquote>
<h2>4.0.0-beta.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/1085">#1085</a> not adding -n if empty to do-upload command</li>
</ul>
<h2>4.0.0-beta.1</h2>
<p><code>v4</code> represents a move from the <a href="https://github.com/codecov/uploader">universal uploader</a> to the <a href="https://github.com/codecov/codecov-cli">Codecov CLI</a>. Although this will unlock new features for our users, the CLI is not yet at feature parity with the universal uploader.</p>
<h3>Breaking Changes</h3>
<ul>
<li>No current support for <code>aarch64</code> and <code>alpine</code> architectures.</li>
<li>Tokenless uploading is unsuported</li>
<li>Various arguments to the Action have been removed</li>
</ul>
<h2>3.1.4</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/967">#967</a> Fix typo in README.md</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/971">#971</a> fix: add back in working dir</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/969">#969</a> fix: CLI option names for uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/970">#970</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.12 to 18.16.3</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/979">#979</a> build(deps-dev): bump <code>@âtypes/node</code> from 20.1.0 to 20.1.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/981">#981</a> build(deps-dev): bump <code>@âtypes/node</code> from 20.1.2 to 20.1.4</li>
</ul>
<h2>3.1.3</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/960">#960</a> fix: allow for aarch64 build</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/957">#957</a> build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/958">#958</a> build(deps): bump openpgp from 5.7.0 to 5.8.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/959">#959</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.10 to 18.15.12</li>
</ul>
<h2>3.1.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/718">#718</a> Update README.md</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/851">#851</a> Remove unsupported path_to_write_report argument</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/898">#898</a> codeql-analysis.yml</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/901">#901</a> Update README to contain correct information - inputs and negate feature</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/955">#955</a> fix: add in all the extra arguments for uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/819">#819</a> build(deps): bump openpgp from 5.4.0 to 5.5.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/835">#835</a> build(deps): bump node-fetch from 3.2.4 to 3.2.10</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/840">#840</a> build(deps): bump ossf/scorecard-action from 1.1.1 to 2.0.4</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/841">#841</a> build(deps): bump <code>@âactions/core</code> from 1.9.1 to 1.10.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/843">#843</a> build(deps): bump <code>@âactions/github</code> from 5.0.3 to 5.1.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/869">#869</a> build(deps): bump node-fetch from 3.2.10 to 3.3.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/872">#872</a> build(deps-dev): bump jest-junit from 13.2.0 to 15.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/879">#879</a> build(deps): bump decode-uri-component from 0.2.0 to 0.2.2</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/c16abc29c95fcf9174b58eb7e1abf4c866893bc8"><code>c16abc2</code></a> chore(release): 4.1.1 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1344">#1344</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/3e33441c198bf1d61f10a04bae1fd822380d0c6d"><code>3e33441</code></a> fix: typo in disable_safe_directory (<a href="https://redirect.github.com/codecov/codecov-action/issues/1343">#1343</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/85aacc96543a61394c25e4172e3b041a7893d249"><code>85aacc9</code></a> build(deps): bump github/codeql-action from 3.24.7 to 3.24.9 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1341">#1341</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/4ea9be0fa3b51aaaf28171c3ebd384138e1fbd8b"><code>4ea9be0</code></a> build(deps): bump undici from 5.28.2 to 5.28.3 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1338">#1338</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/164fadeaa7c9c2f7ff8ed535672bfab80abdf570"><code>164fade</code></a> build(deps-dev): bump typescript from 5.4.2 to 5.4.3 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1334">#1334</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/4621ecce093438b398d3d338ab5fe3b038f8e593"><code>4621ecc</code></a> fix: force version (<a href="https://redirect.github.com/codecov/codecov-action/issues/1329">#1329</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/251ba34669580cb1cba13b602ce56b27a7bd1a33"><code>251ba34</code></a> build(deps): bump actions/checkout from 4.1.1 to 4.1.2 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1331">#1331</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/5a593a5341d231c229d4b555e2ec7ed967bc9208"><code>5a593a5</code></a> build(deps): bump github/codeql-action from 3.24.6 to 3.24.7 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1332">#1332</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/a15c0e43ca6bf783765f61cb1c13ca6a2152644e"><code>a15c0e4</code></a> Removed mention of Mercurial (<a href="https://redirect.github.com/codecov/codecov-action/issues/1325">#1325</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/8be6ba57821f458c7d51e7f82129ac29316c2ea1"><code>8be6ba5</code></a> build(deps-dev): bump typescript from 5.3.3 to 5.4.2 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1319">#1319</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/codecov/codecov-action/compare/54bcd8715eee62d40e33596ef5e8f0f48dbbccab...c16abc29c95fcf9174b58eb7e1abf4c866893bc8">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.1.0&new-version=4.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

d2a19380

Roll pub packages and regenerate gradle lockfiles (#145727) · 385bec0a

Christopher Fujino authored Mar 26, 2024

Example failing devicelab build https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/2980/overview

Fixes https://github.com/flutter/flutter/issues/145561

Supercedes https://github.com/flutter/flutter/pull/145564

385bec0a

Roll Flutter Engine from 5c7aea6f20fc to 026d8902e3b5 (1 revision) (#145785) · b3c9f5f8

engine-flutter-autoroll authored Mar 26, 2024

https://github.com/flutter/engine/compare/5c7aea6f20fc...026d8902e3b5

2024-03-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 09e56db7d600 to a600b67424a8 (5 revisions) (flutter/engine#51684)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b3c9f5f8

Roll Flutter Engine from baede78d2352 to 5c7aea6f20fc (2 revisions) (#145784) · 0779480e

engine-flutter-autoroll authored Mar 26, 2024

https://github.com/flutter/engine/compare/baede78d2352...5c7aea6f20fc

2024-03-26 jason-simmons@users.noreply.github.com [Impeller] Do not apply mask filters to a DrawPaint cover geometry (flutter/engine#51670)
2024-03-26 flar@google.com [Impeller] Simplify calculation of Matrix::GetMaxBasisXY() (flutter/engine#51664)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0779480e

Roll Flutter Engine from cffd1dcfe6a5 to baede78d2352 (2 revisions) (#145778) · 7f4d621f

engine-flutter-autoroll authored Mar 26, 2024

https://github.com/flutter/engine/compare/cffd1dcfe6a5...baede78d2352

2024-03-26 rmacnak@google.com Stop rolling zlib with Dart SDK rolls. (flutter/engine#51667)
2024-03-26 skia-flutter-autoroll@skia.org Roll Skia from 90cfbf5fb91e to 0590062821dc (2 revisions) (flutter/engine#51680)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f4d621f

Correct typo: "Free" to "Three" in comments (#145689) · e5e70b06

Lipu authored Mar 26, 2024

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

e5e70b06

Fix disabled `DropdownMenu` doesn't defer the mouse cursor (#145686) · d2c85529

Taha Tesser authored Mar 26, 2024

fixes [DropdownMenu cursor in disabled state](https://github.com/flutter/flutter/issues/144611)

This was added in https://github.com/flutter/flutter/pull/121353

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: Column(
            mainAxisSize: MainAxisSize.min,
            children: <Widget>[
              const Spacer(),
              const Text('enabled: true,\nrequestFocusOnTap: true,'),
              const SizedBox(height: 16),
              DropdownMenu<String>(
                enabled: true,
                initialSelection: 'First',
                requestFocusOnTap: true,
                width: 200,
                dropdownMenuEntries: ['First', 'Second', 'Third']
                    .map((e) => DropdownMenuEntry(value: e, label: e))
                    .toList(),
              ),
              const Text('Expected: text cursor'),
              const Spacer(),
              const Text('enabled: true,\nrequestFocusOnTap: false,'),
              const SizedBox(height: 16),
              DropdownMenu<String>(
                enabled: true,
                initialSelection: 'First',
                requestFocusOnTap: false,
                width: 200,
                dropdownMenuEntries: ['First', 'Second', 'Third']
                    .map((e) => DropdownMenuEntry(value: e, label: e))
                    .toList(),
                // label: const Text('requestFocusOnTap: false'),
              ),
              const Text('Expected: clickable cursor'),
              const Spacer(),
              const Text('enabled: false,\nrequestFocusOnTap: true,'),
              const SizedBox(height: 16),
              DropdownMenu<String>(
                enabled: false,
                initialSelection: 'First',
                requestFocusOnTap: true,
                width: 200,
                dropdownMenuEntries: ['First', 'Second', 'Third']
                    .map((e) => DropdownMenuEntry(value: e, label: e))
                    .toList(),
              ),
              const Text('Expected: deferred cursor'),
              const Spacer(),
              const Text('enabled: false,\nrequestFocusOnTap: false,'),
              const SizedBox(height: 16),
              DropdownMenu<String>(
                enabled: false,
                initialSelection: 'First',
                requestFocusOnTap: false,
                width: 200,
                dropdownMenuEntries: ['First', 'Second', 'Third']
                    .map((e) => DropdownMenuEntry(value: e, label: e))
                    .toList(),
              ),
              const Text('Expected: deferred cursor'),
              const Spacer(),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

### Preview
![Screenshot 2024-03-25 at 14 52 31](https://github.com/flutter/flutter/assets/48603081/cf4361a5-d3bb-4635-9825-5eefa4efe6cc)

d2c85529

Roll Flutter Engine from b2d93a64cbc7 to cffd1dcfe6a5 (9 revisions) (#145773) · 8d31c583

engine-flutter-autoroll authored Mar 26, 2024

https://github.com/flutter/engine/compare/b2d93a64cbc7...cffd1dcfe6a5

2024-03-26 jacksongardner@google.com Pass the flutter test font by default. (flutter/engine#51671)
2024-03-26 jonahwilliams@google.com [Impeller] revert usage of foreground blend optimization. (flutter/engine#51679)
2024-03-26 jonahwilliams@google.com [Impeller] Refactor clip stack into separate testable class. (flutter/engine#51656)
2024-03-26 zanderso@users.noreply.github.com Roll buildroot to ba3ca696f4f95e998707523be755c15440c6bf3f (flutter/engine#51678)
2024-03-26 zanderso@users.noreply.github.com Use RBE for Fuchsia CI builds (flutter/engine#51675)
2024-03-26 skia-flutter-autoroll@skia.org Roll Skia from 7ffd936a66df to 90cfbf5fb91e (15 revisions) (flutter/engine#51677)
2024-03-26 chris@bracken.jp [macOS] Disable FlutterEngineTest.CanOverrideBackgroundColor (flutter/engine#51669)
2024-03-26 zanderso@users.noreply.github.com Roll buildroot to 2a16784938d3be059014d4112f00ac70a386fa0c (flutter/engine#51674)
2024-03-26 skia-flutter-autoroll@skia.org Roll Dart SDK from a783a4a043ec to 09e56db7d600 (2 revisions) (flutter/engine#51666)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8d31c583

Roll Packages from 28d126c54c63 to ab1630b9b9bd (1 revision) (#145755) · 1279df81

engine-flutter-autoroll authored Mar 26, 2024

https://github.com/flutter/packages/compare/28d126c54c63...ab1630b9b9bd

2024-03-26 tarrinneal@gmail.com [pigeon] Adds @SwiftClass annotation (flutter/packages#6372)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1279df81

Memory leaks clean up 2 (#145757) · 94c63f82
Kostia Sokolovskyi authored Mar 26, 2024

94c63f82
Fix memory leak in Overlay.wrap. (#145744) · 8953ba65
Kostia Sokolovskyi authored Mar 26, 2024

8953ba65

Be tolerant of backticks around directory name in `pub` output. (#145768) · 15832892

Jackson Gardner authored Mar 26, 2024

This fixes https://github.com/flutter/flutter/issues/145766

The output of the pub command changed slightly with this change: https://dart.googlesource.com/pub/+/2179b765aa9071386be02d408b3c3caa82af98f5

Update the tests to be tolerant of the directory path being surrounded by backticks (or not) so that we are compatible with the current and upcoming implementation.

15832892

Fix `ExpansionTile` Expanded/Collapsed announcement is interrupted by VoiceOver (#143936) · 81f969e8

Taha Tesser authored Mar 26, 2024

fixes [`ExpansionTile` accessibility information doesn't read Expanded/Collapsed (iOS)](https://github.com/flutter/flutter/issues/132264)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        appBar: AppBar(
          title: const Text('ExpansionTile'),
        ),
        body: const ExpansionTile(
          title: Text("Title"),
          children: <Widget>[
            Placeholder(),
          ],
        ),
        floatingActionButton: FloatingActionButton(
          onPressed: () {},
          child: const Icon(Icons.add),
        ),
      ),
    );
  }
}
```

</details>

### Before

https://github.com/flutter/flutter/assets/48603081/542d8392-52dc-4319-92ba-215a7164db49

### After

https://github.com/flutter/flutter/assets/48603081/c9225144-4c12-4e92-bc41-4ff82b370ad7

81f969e8

[flutter_tools] Enable WebAssembly compilation everywhere, remove feature flag (#145562) · 388f3217
Kevin Moore authored Mar 26, 2024

388f3217

Roll Flutter Engine from 3c881b75cc28 to b2d93a64cbc7 (1 revision) (#145759) · 55528ba1

engine-flutter-autoroll authored Mar 26, 2024

https://github.com/flutter/engine/compare/3c881b75cc28...b2d93a64cbc7

2024-03-26 58529443+srujzs@users.noreply.github.com Change JSBoxedDartObject to JSAny (flutter/engine#51634)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55528ba1

Roll Flutter Engine from b2001fa6d773 to 3c881b75cc28 (1 revision) (#145733) · a8345d53

engine-flutter-autoroll authored Mar 26, 2024

https://github.com/flutter/engine/compare/b2001fa6d773...3c881b75cc28

2024-03-25 zanderso@users.noreply.github.com Revert "Disable cleaning up ImageReaders in memory pressure callback" (flutter/engine#51665)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a8345d53

25 Mar, 2024 21 commits

Roll Flutter Engine from 5fc95a3277ea to b2001fa6d773 (1 revision) (#145730) · bc9e789e

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/5fc95a3277ea...b2001fa6d773

2024-03-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ySBsQPn-0UgTQaXIw... to uu8lffXkeJQ9PC96I... (flutter/engine#51660)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ySBsQPn-0UgT to uu8lffXkeJQ9

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc9e789e

Fix `SearchAnchor` triggers unnecessary suggestions builder calls (#143443) · 8363e782

Taha Tesser authored Mar 25, 2024

fixes [`SearchAnchor` triggers extra search operations](https://github.com/flutter/flutter/issues/139880)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

Future<List<String>> createFuture() async {
  return List.generate(1000, (index) => "Hello World!");
}

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final SearchController controller = SearchController();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            SearchAnchor(
              searchController: controller,
              suggestionsBuilder: (suggestionsContext, controller) {
                final resultFuture = createFuture();
                return [
                  FutureBuilder(
                    future: resultFuture,
                    builder: ((context, snapshot) {
                      if (snapshot.connectionState != ConnectionState.done) {
                        return const LinearProgressIndicator();
                      }
                      final result = snapshot.data;
                      if (result == null) {
                        return const LinearProgressIndicator();
                      }
                      return ListView.builder(
                        shrinkWrap: true,
                        physics: const NeverScrollableScrollPhysics(),
                        itemCount: result.length,
                        itemBuilder: (BuildContext context, int index) {
                          final root = result[index];
                          return ListTile(
                            leading: const Icon(Icons.article),
                            title: Text(root),
                            subtitle: Text(
                              root,
                              overflow: TextOverflow.ellipsis,
                              style: TextStyle(
                                color: Theme.of(suggestionsContext)
                                    .colorScheme
                                    .onSurfaceVariant,
                              ),
                            ),
                            onTap: () {},
                          );
                        },
                      );
                    }),
                  ),
                ];
              },
              builder: (BuildContext context, SearchController controller) {
                return IconButton(
                  onPressed: () {
                    controller.openView();
                  },
                  icon: const Icon(Icons.search),
                );
              },
            ),
          ],
        ),
      ),
    );
  }
}

```

</details>

### Before

https://github.com/flutter/flutter/assets/48603081/69f6dfdc-9f92-4d2e-8a3e-984fce25f9e4

### After

https://github.com/flutter/flutter/assets/48603081/be105e2c-51d8-4cb0-a75b-f5f41d948e5e

8363e782

Refactor add_to_app_life_cycle_tests (#145546) · 2832611d

Jesse authored Mar 25, 2024

Refactor add_to_app_life_cycle_tests in order to reduce testing logic in test.dart, create a suite_runners directory and allow for later implementing package:test onto add_to_app_life_cycle_tests

Part of https://github.com/flutter/flutter/issues/145482

2832611d

Roll Flutter Engine from 04191a122e9a to 5fc95a3277ea (3 revisions) (#145722) · b05937d3

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/04191a122e9a...5fc95a3277ea

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 625d04f3a7c5 to 7ffd936a66df (7 revisions) (flutter/engine#51657)
2024-03-25 lauren@selfisekai.rocks font_subset tests: name correct variant in exception (flutter/engine#51492)
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 8a587a10323f to 625d04f3a7c5 (5 revisions) (flutter/engine#51655)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b05937d3

Fix vertical `Stepper` draws connector on the last step (#145703) · 5e19b335

Taha Tesser authored Mar 25, 2024

fixes [Vertical stepper shows line after last step](https://github.com/flutter/flutter/issues/144376)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: Stepper(
            currentStep: 1,
            steps: const <Step>[
              Step(
                title: Text("Step 1"),
                content: Text("Content 1"),
              ),
              Step(
                title: Text("Step 2"),
                content: Text("Content 2"),
              ),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before

![Screenshot 2024-03-25 at 18 36 32](https://github.com/flutter/flutter/assets/48603081/af859a88-7ec8-4432-8eec-f8eb72706b57)

### After
![Screenshot 2024-03-25 at 18 36 24](https://github.com/flutter/flutter/assets/48603081/994325b2-4bd4-44ef-9473-245d3492faf7)

5e19b335

Update links in analysis_options.yaml (#145706) · 330a2ca2

Michael Goderbauer authored Mar 25, 2024

According to the [readme](https://github.com/dart-lang/linter?tab=readme-ov-file#repository-has-moved) of the linter repository, the source of truth for the linter has moved to the SDK repository. This updates the link to `all.yaml` in our file.

While I am in here, I also updated two other links that were outdated.

330a2ca2

Add a `--print-dtd` flag to print the DTD address served by DevTools server (#144272) · 31f4f2b6
Kenzie Davisson authored Mar 25, 2024

31f4f2b6

Roll Flutter Engine from ef896e942f44 to 04191a122e9a (1 revision) (#145709) · dbdcead9

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/ef896e942f44...04191a122e9a

2024-03-25 jonahwilliams@google.com [Impeller] fix unbalanced restores. (flutter/engine#51648)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbdcead9

Update semantics.dart (#145683) · 9fa731dd
Ikko Eltociear Ashimine authored Mar 25, 2024
```
loosing -> losing
```
9fa731dd
TwoDimensionalChildDelegate should dispatch creation and disposal events (#145684) · 453a04d9
Kostia Sokolovskyi authored Mar 25, 2024

453a04d9
Memory leaks clean up 1 (#145691) · 47bfa827
Kostia Sokolovskyi authored Mar 25, 2024

47bfa827

Roll Flutter Engine from 2e8d77dbb0f0 to ef896e942f44 (1 revision) (#145705) · 2dd27648

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/2e8d77dbb0f0...ef896e942f44

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from e7ae039f5b1b to 8a587a10323f (1 revision) (flutter/engine#51654)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2dd27648

[Fix]: Searchbar doesn't lose focus when tapped outside (#145232) · a9f18b80

Sahil Kachhap authored Mar 25, 2024

Added a Fix to search bar that allows it be unfocused when tapped anywhere outside the search bar.

I have attached below the app flow after implementing the fix.

https://github.com/flutter/flutter/assets/54017876/70915c47-9b77-4a43-a128-8706107f921f

Issue that gets resolved by this fix: #145096

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

a9f18b80

Fix typo in hitTest docs (#145677) · 2851ed32
Kostia Sokolovskyi authored Mar 25, 2024
```
This PR fixes the typo in the `hitTest` method documentation.
```
2851ed32

Roll Packages from 611aea1657fb to 28d126c54c63 (1 revision) (#145690) · b39660df

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/packages/compare/611aea1657fb...28d126c54c63

2024-03-25 engine-flutter-autoroll@skia.org Roll Flutter from 18340ea1 to 14774b95 (20 revisions) (flutter/packages#6376)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b39660df

[deps] Bump native assets dependencies (#145612) · baa54fdd

Daco Harkes authored Mar 25, 2024

Roll of a bunch of breaking changes from the native_assets_builder and
native_assets_cli upstream. Most notably:

* https://github.com/dart-lang/native/pull/946
* https://github.com/dart-lang/native/pull/1018
* https://github.com/dart-lang/native/pull/1019

This PR also updates the template in `flutter create
--template=package_ffi` to use the rewritten API.

This PR does not change any functionality in Flutter.

For reference, the same roll in the Dart SDK:

* https://dart-review.googlesource.com/c/sdk/+/357605
* https://dart-review.googlesource.com/c/sdk/+/357623

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

baa54fdd

Roll Flutter Engine from 857584c458ff to 2e8d77dbb0f0 (1 revision) (#145678) · 280037f6

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/857584c458ff...2e8d77dbb0f0

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from e6dc16a6d82d to e7ae039f5b1b (1 revision) (flutter/engine#51653)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

280037f6

Add `AnimationStyle` to `showBottomSheet` and `showModalBottomSheet` (#145536) · 23687c52

Taha Tesser authored Mar 25, 2024

fixes [Introduce animation customizable with `AnimationStyle` to `BottomSheet`](https://github.com/flutter/flutter/issues/145532)

### Default bottom sheet animation
![00-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/a295b002-b310-4dea-8bc4-23b1d299748c)

### Custom bottom sheet animation
![01-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/8c5c3d5f-e67d-4ed5-880d-f17d262087e1)

### No bottom sheet animation
![02-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/872409d8-8a8d-4db9-b95b-7f96a62cdffc)

23687c52

Roll Flutter Engine from ae758d54630d to 857584c458ff (2 revisions) (#145673) · 62adaff8

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/ae758d54630d...857584c458ff

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 7f2e8320bbfe to e6dc16a6d82d (1 revision) (flutter/engine#51652)
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from df5d7a960d34 to 7f2e8320bbfe (1 revision) (flutter/engine#51651)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

62adaff8

Roll Flutter Engine from efdde39a2a57 to ae758d54630d (1 revision) (#145669) · 7f06c263

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/efdde39a2a57...ae758d54630d

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from fa486cd8b2d0 to df5d7a960d34 (1 revision) (flutter/engine#51650)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f06c263

make hot reload reflect changes to asset transformer configurations (#144660) · cd785544

Andrew Kolos authored Mar 25, 2024

In service of https://github.com/flutter/flutter/issues/143348

This PR makes hot reloads reflect changes to transformer configurations under the `assets` section in pubspec.yaml.
This PR is optimized for ease of implementation, and should not be merged as-is. If it is merged as-is, seriously consider creating a tech debt issue and assigning it to someone to make sure it gets resolved.

cd785544