- 28 Oct, 2019 2 commits
-
-
LongCatIsLooong authored
-
Albertus Angga Raharja authored
* Add structured errors in Animations, TabView, ChangeNotifier * Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan * Add structured errors in Debug * Fix test errors * Add structured errors in Scaffold and Stepper * Add structured errors in part of Rendering Layer * Fix failing test due to FloatingPoint precision * Fix failing tests due to precision error and not using final * Fix failing test due to floating precision error with RegEx instead * Add structured error in CustomLayout and increase test coverage * Add structured error & its test in ListBody * Add structured error in ProxyBox and increase test coverage * Add structured error message in Viewport * Fix styles and add more assertions on ErrorHint and DiagnosticProperty * Add structured error in scheduler/binding and scheduler/ticker Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add structured error in AssetBundle and TextInput Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add structured errors in several widgets #1 Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Remove unused import Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add assertions on hint messages Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Fix catch spacing Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add structured error in several widgets part 2 and increase code coverage Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Add structured error in flutter_test/widget_tester * Fix floating precision accuracy by using RegExp Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Remove todo to add tests in Scaffold showBottomSheet Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Fix reviews by indenting lines and fixing the assertion orders Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Fix failing tests due to renaming class Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Try skipping the NetworkBundleTest Signed-off-by: Albertus Angga Raharja <albertusangga@google.com> * Remove leading space in material/debug error hint Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>
-
- 25 Oct, 2019 1 commit
-
-
Kate Lovett authored
-
- 22 Oct, 2019 1 commit
-
-
Kate Lovett authored
This reverts commit 8df0d655.
-
- 21 Oct, 2019 1 commit
-
-
Kate Lovett authored
-
- 09 Oct, 2019 2 commits
-
-
Greg Spencer authored
This adds a Semantics node to the Focus and FocusScope widgets, setting the focused and focusable attributes so that the accessibility subsystem can be told when a control has the input focus. Includes an engine roll to flutter/engine@77252d2, and the following 8 engine changes: flutter/engine@77252d2 Greg Spencer Add missing focusable testing info (flutter/engine#13013) flutter/engine@0e42a29 skia-flutter-.. Roll src/third_party/skia 54548626a977..e27a503a0a21 (1 commits) (flutter/engine#13024) flutter/engine@6b56ed7 gaaclarke Refactor: FlutterDartProject (flutter/engine#13006) flutter/engine@393480c skia-flutter-.. Roll src/third_party/skia 77dde599c98a..54548626a977 (1 commits) (flutter/engine#13023) flutter/engine@080b89d skia-flutter-.. Roll src/third_party/skia 2b1a25a4d324..77dde599c98a (1 commits) (flutter/engine#13021) flutter/engine@90b0f30 Ben Konyi Roll src/third_party/dart f4a72bfc64..bb04f145b2 (18 commits) (flutter/engine#13020) flutter/engine@049fb89 skia-flutter-.. Roll fuchsia/sdk/core/linux-amd64 from q_uYX... to cknsi... (flutter/engine#13019) flutter/engine@6925b2a skia-flutter-.. Roll fuchsia/sdk/core/mac-amd64 from wuAtw... to u0JpE... (flutter/engine#13018) Related Issues Addresses #40101 Landing on red in order to fix the build: it's red because of the needed engine roll.
-
Kate Lovett authored
-
- 07 Oct, 2019 1 commit
-
-
Yegor authored
Add more web tests;use blacklist instead of whitelist
-
- 26 Sep, 2019 1 commit
-
-
Greg Spencer authored
This fixes the mouse hover code to not schedule frames with every mouse move. Before this, it would schedule a post frame callback, and then schedule a frame immediately, even if there was nothing that needed to be updated. Now it will schedule checks for mouse position updates synchronously, unless there's a new annotation, and skip scheduling a new frame in all cases. It has to be async in the case of a new annotation (i.e. a new MouseRegion is added), since when the annotation is added, it hasn't yet painted, and it can't hit test against the new layer until after the paint, so in that case it schedules a post frame callback, but since it's already building a frame when it does that, it doesn't need to schedule a frame. The code also used to do mouse position checks for all mice if only one mouse changed position. I fixed this part too, so that it will only check position for the mouse that changed.
-
- 24 Sep, 2019 2 commits
-
-
Mehmet Fidanboylu authored
-
Greg Spencer authored
There were four or five different implementations in various tests for sendFakeKeyEvent, which roughly all did the same thing. I was going to add yet another one, and decided that it needed to be generalized and centralized. This replaces those instances with something that just takes a LogicalKeyboardKey so that it's self-documenting, and can be used with multiple platforms. This adds two functions to widget tester: sendKeyDownEvent and sendKeyUpEvent which simulate key up/down from a physical keyboard. It also adds global functions simulateKeyDownEvent and simulateKeyUpEvent that can be called without a widget tester. All are async functions protected by the async guard.
-
- 18 Sep, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 17 Sep, 2019 3 commits
-
-
Michael Goderbauer authored
This reverts commit 6ad88bd5.
-
Michael Goderbauer authored
-
Alexandre Ardhuin authored
-
- 16 Sep, 2019 1 commit
-
-
Kate Lovett authored
* Fixing LocalFileComparator output * Fixing path separators for windows failures * Windows path issues * Testing * ++ * ++ * Fixing base directory - windows * Clean up
-
- 13 Sep, 2019 1 commit
-
-
Jonah Williams authored
-
- 11 Sep, 2019 1 commit
-
-
Jonah Williams authored
-
- 06 Sep, 2019 2 commits
-
-
chunhtai authored
-
Michael Goderbauer authored
-
- 05 Sep, 2019 2 commits
-
-
Ian Hickson authored
* Minor improvements to framework documentation. * maybePop documentation fix * Mark some flutter_test arguments required. Without these set, we get a crash. * Minor correction to ListView docs
-
- 03 Sep, 2019 1 commit
-
-
Kate Lovett authored
-
- 02 Sep, 2019 1 commit
-
-
Jonah Williams authored
-
- 28 Aug, 2019 1 commit
-
-
liyuqian authored
This is the continuation of https://github.com/flutter/engine/pull/11041 and https://github.com/flutter/flutter/pull/38574 This is not a breaking change as we're not removing `onReportTimings` API. We're simply removing the use of it in our framework.
-
- 27 Aug, 2019 1 commit
-
-
adazh authored
-
- 22 Aug, 2019 1 commit
-
-
Shi-Hao Hong authored
* Wire Window.systemGestureInsets to MediaQuery.systemGestureInsets * Add systemGestureInsets property to TestWindow
-
- 21 Aug, 2019 1 commit
-
- 20 Aug, 2019 1 commit
-
-
James D. Lin authored
Flutter widget tests assert if a test completes with timers still pending. However, it can be hard to diagnose where a pending timer came from. For example, a widget might consume a third-party library that internally uses a timer. I added a FakeAsync.pendingTimersDebugInfo getter to quiver (https://github.com/google/quiver-dart/pull/500). Make flutter_test use it. Additionally modify Flutter's debugPrintStack to take an optional StackTrace argument instead of always printing StackTrace.current. Fixes #4237.
-
- 19 Aug, 2019 2 commits
-
-
Kaushik Iska authored
Filed: https://github.com/flutter/flutter/issues/38838 to track these usages. This was introduced by: https://github.com/flutter/engine/pull/11041
-
Kate Lovett authored
-
- 16 Aug, 2019 3 commits
-
-
Yegor authored
Teach Layer and its implementations, RenderObject and its implementations, and PaintingContext to reuse engine layers. The idea is that a concrete RenderObject creates a Layer and holds on to it as long as it needs it (i.e. when it is composited, and the layer type does not change). In return, each Layer object holds on to an EngineLayer and reports it to the engine via addRetained and oldLayer. This allows the Web engine to reuse DOM elements across frames. Without it, each frame drops all previously rendered HTML and regenerates it from scratch.
-
Kate Lovett authored
-
Nurhan Turgut authored
* Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route * Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route * Reverting all unrelated formatting changes. * Adding unit tests. Adding more comments. * Changing string method names with constant strings. * Fixing a constant strings. * Fixing analyzer error. * Fixing more white space. * Changing the method names. Adding comments to the SystemChannels * Comment and code name fixes * replacing the comment with reviewer suggestion. * addinf systemchannels.navigation mock to test bindings * Adding a new class for sending route change notrifications. The nottifications are only sent on web. This should fix breaking android/ios * using new class RouteNotificationMessages in navigator * Fixing analyzer issues. * fixing cycle dependency * fixing github analyze error * dartfmt two new classes. trying to fix anayze errors * Update route_notification_messages.dart * trying to fix white space errors
-
- 09 Aug, 2019 3 commits
-
-
Michael Klimushyn authored
This reverts commit 92ef2b9c. This requires either runApp() or WidgetsFlutterBinding.ensureInitialized() to have been called before using any MethodChannels. Plugins broadly rely on MethodChannels and right now there's no general requirements that they be constructed within the runApp call, so the ecosystem breakages from this are broader than originally thought. Reverting for now.
-
Kate Lovett authored
This reverts commit 3a2d3081.
-
adazh authored
-
- 08 Aug, 2019 1 commit
-
-
Jonah Williams authored
-
- 07 Aug, 2019 1 commit
-
-
Kate Lovett authored
-
- 02 Aug, 2019 1 commit
-
-
Dan Field authored
-