1. 26 Sep, 2019 1 commit
    • Greg Spencer's avatar
      Added proper focus handling when pushing and popping routes (#40166) · 1a7bb1f5
      Greg Spencer authored
      The proposed change will change focus handling when pushing and popping routes so that the FocusScopeNode for the route receives focus when pushed, and that the FocusScopeNode in the navigator receives focus when the route is popped.
      
      This means that the last setFirstFocus call on the scope is used to determine which control actually receives focus. When the focus scope receives focus, it traverses its children, trying to find a non-scope node that is the "first focus" of itself or a child node.
      
      This is a breaking change, because the focus behavior has changed. If you push a route after this change, and had a 'first focus' set on a widget via FocusScopeNode.setFirstFocus, it won't currently receive focus immediately, but after this change it will. Similarly, if you pop a route after this change, the focus will go back to where it was before the route was pushed, which is correct, but different from what happens now.
      1a7bb1f5
  2. 24 Sep, 2019 2 commits
  3. 05 Sep, 2019 2 commits
  4. 16 Aug, 2019 1 commit
    • Nurhan Turgut's avatar
      Navigator change backup (#38494) · c2e2f093
      Nurhan Turgut authored
      * Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route
      
      * Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route
      
      * Reverting all unrelated formatting changes.
      
      * Adding unit tests. Adding more comments.
      
      * Changing string method names with constant strings.
      
      * Fixing a constant strings.
      
      * Fixing analyzer error.
      
      * Fixing more white space.
      
      * Changing the method names. Adding comments to the SystemChannels
      
      * Comment and code name fixes
      
      * replacing the comment with reviewer suggestion.
      
      * addinf systemchannels.navigation mock to test bindings
      
      * Adding a new class for sending route change notrifications. The nottifications are only sent on web. This should fix breaking android/ios
      
      * using new class RouteNotificationMessages in navigator
      
      * Fixing analyzer issues.
      
      * fixing cycle dependency
      
      * fixing github analyze error
      
      * dartfmt two new classes. trying to fix anayze errors
      
      * Update route_notification_messages.dart
      
      * trying to fix white space errors
      c2e2f093
  5. 09 Jul, 2019 1 commit
    • Kate Lovett's avatar
      Navigator pushAndRemoveUntil Fix (#35223) · 97b2c986
      Kate Lovett authored
      * Initial work
      
      * ++
      
      * Updated tests
      
      * Moved TestObserver out for access across tests.
      
      * ++
      
      * Added hero tests
      
      * Review feedback
      
      * simplified preceding route overlay
      
      * Review feedback
      
      * trailing doc slash
      97b2c986
  6. 16 Jun, 2019 1 commit
  7. 25 May, 2019 1 commit
    • Chris Bracken's avatar
      Americanise spellings (#33323) · 156b4220
      Chris Bracken authored
      Updates documentation and non-public API to use American spellings for
      consistency with the rest of the codebase.
      
      No changes to behaviour... other than how it's spelt.
      156b4220
  8. 02 May, 2019 1 commit
  9. 25 Apr, 2019 1 commit
    • Greg Spencer's avatar
      [Re-Land] Implement focus traversal for desktop platforms. (#31614) · 7775c237
      Greg Spencer authored
      This re-lands the Focus changes in #30040. Correctness changes in routes.dart, and removes the automatic requesting of focus on reparent when there is no current focus, which caused undesirable selections.
      
      Addresses #11344, #1608, #13264, and #1678
      Fixes #30084
      Fixes #26704
      7775c237
  10. 23 Apr, 2019 1 commit
  11. 22 Apr, 2019 1 commit
    • Greg Spencer's avatar
      Implement focus traversal for desktop platforms, shoehorn edition. (#30040) · 4218c0bc
      Greg Spencer authored
      Implements focus traversal for desktop platforms, including re-implementing the existing focus manager and focus tree.
      
      This implements a Focus widget that can be put into a widget tree to allow input focus to be given to a particular part of a widget tree.
      
      It incorporates with the existing FocusScope and FocusNode infrastructure, and has minimal breakage to the API, although FocusScope.reparentIfNeeded is removed, replaced by a call to FocusAttachment.reparent(), so this is a breaking change:
      
      FocusScopeNodes must now be attached to the focus tree using FocusScopeNode.attach, which takes a context and an optional onKey callback, and returns a FocusAttachment that should be kept by the widget that hosts the FocusScopeNode. This is necessary because of the need to make sure that the focus tree reflects the widget hierarchy.
      
      Callers that used to call FocusScope(context).reparentIfNeeded in their build method will call reparent  on a FocusAttachment instead, which they will obtain by calling FocusScopeNode.attach in their initState method. Widgets that own FocusNodes will need to call dispose on the focus node in their dispose method.
      
      Addresses #11344, #1608, #13264, and #1678
      Fixes #30084
      Fixes #26704
      4218c0bc
  12. 18 Mar, 2019 1 commit
  13. 06 Mar, 2019 1 commit
  14. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  15. 21 Feb, 2019 1 commit
  16. 15 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793) · 262f12b4
      Greg Spencer authored
      This converts all remaining "## Sample code" segments into snippets, and fixes
      the snippet generator to handle multiple snippets in the same dartdoc block
      properly.
      
      I also generated, compiled, and ran each of the existing application samples,
      and fixed them up to be more useful and/or just run without errors.
      
      This PR fixes these problems with examples:
      
      1. Switching tabs in a snippet now works if there is more than one snippet in
         a single dartdoc block.
      2. Generation of snippet code now works if there is more than one snippet.
      3. Contrast of text and links in the code sample block has been improved to
         recommended levels.
      4. Added five new snippet templates, including a "freeform" template to make
         it possible to show examples that need to change the app instantiation.
      5. Fixed several examples to run properly, a couple by adding the "Scaffold"
         widget to the template, a couple by just fixing their code.
      6. Fixed visual look of some of the samples when they run by placing many
         samples inside of a Scaffold.
      7. In order to make it easier to run locally, changed the sample analyzer to
         remove the contents of the supplied temp directory before running, since
         having files that hang around is problematic (only a problem when running
         locally with the `--temp` argument).
      8. Added a `SampleCheckerException` class, and handle sample checking
         exceptions more gracefully.
      9. Deprecated the old "## Sample code" designation, and added enforcement for
         the deprecation.
      10. Removed unnecessary `new` from templates (although they never appeared in
         the samples thanks to dartfmt, but still).
      
      Fixes #26398
      Fixes #27411
      262f12b4
  17. 06 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Make a kReleaseMode constant that is public. (#27502) · da27f623
      Greg Spencer authored
      Before this, we had several places where an isReleaseMode was defined, all with the same definition. This just makes it more broadly visible to allow our users to use it, as well as creating debug and profile versions, and adding a device lab test for it.
      
      Since this is a const value, this makes it possible for a developer to easily mark blocks that can be removed at AOT compile time.
      da27f623
  18. 30 Jan, 2019 2 commits
  19. 07 Jan, 2019 1 commit
  20. 18 Dec, 2018 1 commit
  21. 08 Nov, 2018 1 commit
  22. 05 Nov, 2018 1 commit
    • Greg Spencer's avatar
      Rewrite the analyze-sample-code script to also analyze snippets (#23893) · 202b045b
      Greg Spencer authored
      This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.
      
      It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.
      
      I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.
      
      For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
      202b045b
  23. 26 Oct, 2018 1 commit
  24. 17 Oct, 2018 1 commit
  25. 02 Oct, 2018 1 commit
  26. 14 Sep, 2018 1 commit
  27. 12 Sep, 2018 1 commit
  28. 07 Sep, 2018 1 commit
  29. 24 Aug, 2018 1 commit
  30. 18 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Fixes resulting from audit of issues links (#20772) · 8c79f40d
      Ian Hickson authored
      * Fixes resulting from audit of issues links
      
      I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
      
      * Update run_test.dart
      
      skip this test again since it failed on linux and macos bots
      8c79f40d
  31. 20 Jun, 2018 1 commit
  32. 19 Jun, 2018 1 commit
  33. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  34. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  35. 05 Jun, 2018 2 commits
  36. 30 May, 2018 1 commit