1. 17 Aug, 2018 6 commits
    • Ian Hickson's avatar
      Performance test cleanup (#20652) · 1993a673
      Ian Hickson authored
      * Fix TODO syntax.
      * Clarify messages for some timeouts, to aid debugging.
      * Increase some other timeouts that were a needlessly short, to reduce sources of flakes.
      * Remove some more timeouts that were mostly redundant, to remove complexity.
      * Minor style cleanup.
      * Remove some dangerous traps (specifically, hide the explicit start/end times in TimedEvent since they shouldn't matter).
      1993a673
    • Ian Hickson's avatar
      03d6f18f
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
    • Ian Hickson's avatar
      Try to resolve an intermitted crash during coverage collection (#20506) · d5812085
      Ian Hickson authored
      * Try to resolve an intermitted crash during coverage collection
      
      The only theory I can come up with is that maybe the test completes
      before we finish processing the standard input, so I made the test
      harness wait for the observatory URL before considering whether the
      test has finished or not.
      
      Also, some code cleanup while I'm at it, e.g. avoiding using "onFoo"
      for the names of methods, avoiding back-to-back switch statements with
      the same values, avoiding `_` argument names, and using `?.` instead
      of `if (foo != null) foo.`.
      
      * Revert back the signature of _pipeStandardStreamsToConsole
      
      * Also remove the other additions to this method.
      d5812085
    • Jonah Williams's avatar
      fix dart analysis error (#20698) · 09542fe3
      Jonah Williams authored
      09542fe3
    • Jonah Williams's avatar
  2. 16 Aug, 2018 17 commits
  3. 15 Aug, 2018 17 commits