- 05 Dec, 2023 1 commit
-
-
Lau Ching Jun authored
-
- 31 Jul, 2023 1 commit
-
-
Danny Tuppeny authored
In the legacy VS Code DAP, we would deserialise the Flutter.Error event and provide some basic colouring (eg. stack frames are faded if not from user code and the text is split between stdout/stderr to allow the client to colour it). In the new DAPs we originally used `renderedErrorText` which didn't support either of these. This change adds changes to use the structured data (with some basic parsing because the source classes are in package:flutter and not accessible here) to provide a similar experience. It would be nicer if we could use the real underlying Flutter classes for this deserialisation, but extracting them from `package:flutter` and removing all dependencies on Flutter is a much larger job and I don't think should hold up providing improved error formatting for the new DAPs. Some comparisons:  
-
- 05 Jul, 2023 1 commit
-
-
Helin Shiah authored
This change is for an internal IDE client to send a custom hot reload request, as custom requests from the client must start with `$/`. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. (this PR is linked internally) - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 16 Jun, 2023 1 commit
-
-
Danny Tuppeny authored
When building the new SDK DAPs, this functionality was missed from the Flutter adapter (but added to the Dart CLI adapter). As well as passing a VM Service URI directly, we support passing a file that can be polled for it. This uses the same mechanism we use to obtain the VM Service URI from a Dart debug session (we run `dart --write-service-info=foo.json my_file.dart` and then poll that file which the VM will write) and is useful for users that have their own mechanism for launching an app (for example using custom Flutter embedders - see https://github.com/Dart-Code/Dart-Code/issues/3353) to provide a VM Service URI once the app is up and running. Fixes https://github.com/Dart-Code/Dart-Code/issues/4577.
-
- 09 Jun, 2023 1 commit
-
-
Danny Tuppeny authored
The editor is set to hot-reload-on-save by default so saving while the debug session is starting currently prints an error: Failed to Hot Reload: app 'null' not found  This change skips the call to `app.restart` if the app hasn't started yet to avoid printing an error.
-
- 05 Apr, 2023 1 commit
-
-
Danny Tuppeny authored
[flutter_tools] Include mode in app.start event, and forward app.start to DAP clients
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 03 Mar, 2023 1 commit
-
-
Danny Tuppeny authored
[flutter_tools/dap] Inform DAP client whether restart is supported
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 15 Feb, 2023 1 commit
-
-
Christopher Fujino authored
* wip run_local_linter.dart * get run_local_linter.dart working * slow working implementation * speed up run_local_linter.dart * fix run_local_linter.dart * remove catchError * another fix * fix another * fix * more fixes * fix moar * fix moar * fix * finish * fix tests * clean up further * code review * delete run_local_linter.dart
-
- 02 Feb, 2023 1 commit
-
-
Danny Tuppeny authored
-
- 19 Jan, 2023 1 commit
-
-
Danny Tuppeny authored
* Support logging 'flutter run' communication to DAP clients Fixes https://github.com/Dart-Code/Dart-Code/issues/4266. * Fix test
-
- 09 Jan, 2023 1 commit
-
-
Helin Shiah authored
-
- 19 Dec, 2022 1 commit
-
-
Danny Tuppeny authored
Fixes https://github.com/Dart-Code/Dart-Code/issues/4293.
-
- 30 Nov, 2022 1 commit
-
-
Danny Tuppeny authored
* [flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP clients Fixes https://github.com/Dart-Code/Dart-Code/issues/4292. * Update packages/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart Co-authored-by:
Christopher Fujino <fujino@google.com> * Another static const instead of final Co-authored-by:
Christopher Fujino <fujino@google.com>
-
- 09 Nov, 2022 1 commit
-
-
Danny Tuppeny authored
[flutter_tools/dap] Add support for forwarding `flutter run --machine` exposeUrl requests to the DAP client (#114539) * [flutter_tools/dap] Add support for forwarding `flutter run --machine` requests to the DAP client Currently the only request that Flutter sends to the client is `app.exposeUrl` though most of this code is generic to support other requests that may be added in future. * Improve comment * Fix thrown strings * StateError -> DebugAdapterException * Add a non-null assertion and assert * Use DebugAdapterException to handle restartRequests sent before process starts * Fix typo + use local var * Don't try to actually send Flutter messages in tests because there's no process
-
- 02 Nov, 2022 2 commits
-
-
Danny Tuppeny authored
[flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (#114533)
-
Danny Tuppeny authored
[flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (#114369)
-
- 29 Sep, 2022 1 commit
-
-
Danny Tuppeny authored
-
- 25 Aug, 2022 1 commit
-
-
Danny Tuppeny authored
[dap] Don't wait for appStarted before responding to launch/attach + don't call app.stop for unstarted app (#109386)
-
- 26 Jul, 2022 1 commit
-
-
Danny Tuppeny authored
* [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate Fixes an issue where the flutter_tester device may not be cleaned up correctly if we just terminate the Flutter process. * Update integration test expectations * Revert accidental commit
-
- 25 Jul, 2022 1 commit
-
-
Danny Tuppeny authored
Since https://github.com/dart-lang/sdk/commit/02d9c3e6a586ad47909262931375f25abb34b4e3 this flag does absolutely nothing. The behaviour it controlled is now automatic and the flag is not required. The flag will be removed from the Dart SDK in the future after Flutter is no longer using it.
-
- 19 Jul, 2022 1 commit
-
-
Danny Tuppeny authored
Provide more useful error message if a non-compliant DAP tool (or user) sends bad input to DAP server (#107827)
-
- 12 Jul, 2022 1 commit
-
-
Danny Tuppeny authored
* [flutter_tools] [dap] Add support for passing env variables to spawned processes * Use named args * Use in-memory fs and FakePlatform * Pass filesystem style to MemoryFileSystem
-
- 21 Jun, 2022 1 commit
-
-
Danny Tuppeny authored
-
- 26 May, 2022 1 commit
-
-
Danny Tuppeny authored
* Fix issues running integration tests through DAP These adapters were incorrectly trying to connect a DDS instance even when Flutter would create its own. This change disables DDS in the DAP layer and leaves it to Flutter (although it passes `--no-dds` on to Flutter if provided to the DAP process). Also fixes an issue where we would unnecessarily connect the VM Service for tests even in 'noDebug' mode because of a change/fix that now includes a 'vmServiceUri' in the `test.startedProcess` event.
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 11 Apr, 2022 1 commit
-
-
Danny Tuppeny authored
-
- 06 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 31 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 23 Mar, 2022 1 commit
-
-
Danny Tuppeny authored
* Don't terminate Dart process pids from VM Service These processes may be on another device, and in the case of attach the debugee should not be terminated anyway.
-
- 22 Mar, 2022 1 commit
-
-
Danny Tuppeny authored
-
- 17 Mar, 2022 1 commit
-
-
Danny Tuppeny authored
-
- 25 Feb, 2022 1 commit
-
-
Danny Tuppeny authored
-
- 18 Feb, 2022 1 commit
-
-
Ben Konyi authored
-
- 07 Feb, 2022 1 commit
-
-
Danny Tuppeny authored
* Add support for attachRequest in DAP, which runs "flutter attach" * Update DAP docs for attachRequest * Improve doc comments * Fix comments * Remove noDebug from attach + create a getter for `debug` * Fix indent
-
- 15 Dec, 2021 1 commit
-
-
Danny Tuppeny authored
-
- 23 Nov, 2021 1 commit
-
-
Danny Tuppeny authored
-
- 28 Oct, 2021 1 commit
-
-
Danny Tuppeny authored
* Add support for running tests through debug-adapter * Improve comments about stdout + remove pedantic
-
- 27 Oct, 2021 1 commit
-
-
Danny Tuppeny authored
-