- 26 Jan, 2024 18 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/525bd7dcf7f3...65d1291c3add 2024-01-26 skia-flutter-autoroll@skia.org Roll Skia from ae73baacb793 to cbdf09d69efc (1 revision) (flutter/engine#50085) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LongCatIsLooong authored
These should the the last remaining `MediaQueryData.textScaleFactor` and `TextScaler.textScaleFactor` references.
-
Michael Goderbauer authored
The existing `runApp` bootstraps the widget tree and renders the provided widget into the default view (which is currently the implicit View from `PlatformDispatcher.implicitView` and - in the future - may be a default-created window). Apps, that want more control over the View they are rendered in, need a new way to bootstrap the widget tree: `runWidget`. It does not make any assumptions about the View the provided widget is rendered into. Instead, it is up to the caller to include a View widget in the provided widget tree that specifies where content should be rendered. In the future, this may enable developers to create a custom window for their app instead of relying on the default-created one.
-
Jenn Magder authored
The archiving was running in devicelab because certs are needed to codesign (see #73577). However now the certs are available in chromium bots. Move the archiving test into the existing tool integration test, and delete the devicelab variant. arm64: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8757886514651624673/+/u/run_test.dart_for_tool_host_cross_arch_tests_shard_and_subshard_None/test_stdout#L6074_4 x64: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8757886514651624689/+/u/run_test.dart_for_tool_host_cross_arch_tests_shard_and_subshard_None/test_stdout#L6389_2 Part of https://github.com/flutter/flutter/issues/142070
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/61d841cf6c6d...525bd7dcf7f3 2024-01-26 skia-flutter-autoroll@skia.org Roll Skia from ea260ac426c3 to ae73baacb793 (2 revisions) (flutter/engine#50084) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/de64dff38b10...61d841cf6c6d 2024-01-26 skia-flutter-autoroll@skia.org Roll Skia from cc5124317c18 to ea260ac426c3 (10 revisions) (flutter/engine#50083) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/21b5abba7958...cbe810031b88 2024-01-25 barpac02@gmail.com Update README of `package:process` (flutter/packages#5475) 2024-01-25 engine-flutter-autoroll@skia.org Roll Flutter from 19b06f4e to a8efa771 (38 revisions) (flutter/packages#5969) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bf0cda33122b...de64dff38b10 2024-01-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 6ff9926232bd to 5636e338e0b9 (1 revision) (flutter/engine#50081) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8a81e53e60a2...bf0cda33122b 2024-01-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 6f8bcd5b48ab to 6ff9926232bd (1 revision) (flutter/engine#50079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bartek Pacia authored
This PR fixes 2 small mistakes in `FlutterExtension`: - all fields must be `public` in order to be used in Gradle Kotlin DSL the same as in Gradle Groovy DSL - using `logger` instead of `project.logger` throws an error when executed This PR re-adds a subset of changes from #141541 which broke the tree and has been reverted.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9142fc4f16a5...8a81e53e60a2 2024-01-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 00784f1f22b5 to 6f8bcd5b48ab (1 revision) (flutter/engine#50074) 2024-01-26 ditman@gmail.com [web] Add `views` proxy and `getInitialData`. (flutter/engine#49320) 2024-01-26 ditman@gmail.com [web] Prevent re-rendering disposed views when the engine hot restarts. (flutter/engine#49958) 2024-01-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 2fb950853f06 to 00784f1f22b5 (3 revisions) (flutter/engine#50068) 2024-01-26 matanlurey@users.noreply.github.com Avoid sizing `ImageReaderSurfaceProducer` smaller than 1x1 (flutter/engine#50066) 2024-01-26 jonahwilliams@google.com Use clamp sampling mode in external texture. (flutter/engine#50063) 2024-01-26 john@johnmccutchan.com Reland Optimizations for TLHC frame rate and jank (flutter/engine#50065) 2024-01-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Igt2rE-R6rgfmTRaF... to WHlwlOwznFknNm5IS... (flutter/engine#50059) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Igt2rE-R6rgf to WHlwlOwznFkn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
Manual roll requested by zra@google.com https://github.com/flutter/engine/compare/4b145d041560...9142fc4f16a5 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Optimizations for TLHC frame rate and jank" (flutter/engine#50062) 2024-01-25 bdero@google.com [Impeller] Fix advanced blend alpha issue, improve blend goldens. (flutter/engine#50035) 2024-01-25 127441427+eitanliu@users.noreply.github.com Fix android new engine in group (flutter/engine#49659) 2024-01-25 103135467+sealesj@users.noreply.github.com Remove fuchsia from allowed_hosts post-migration (flutter/engine#50013) 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 801bb44f2b09 to cc5124317c18 (1 revision) (flutter/engine#50054) 2024-01-25 leroux_bruno@yahoo.fr Fix a typo in ChannelBuffers documentation (flutter/engine#49928) 2024-01-25 dnfield@google.com Add include suggested by clang-tidy (flutter/engine#49898) 2024-01-25 smartercallum@gmail.com Refactor macOS trackpad gesture tracking (flutter/engine#49424) 2024-01-25 148634283+nikkivirtuoso@users.noreply.github.com winding order from tesellator.h to formats.h (flutter/engine#49865) 2024-01-25 ian@hixie.ch Roll webp to 1.3.2 (flutter/engine#49883) 2024-01-25 john@johnmccutchan.com Optimizations for TLHC frame rate and jank (flutter/engine#50033) 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Matan Lurey authored
Part 2 of https://github.com/flutter/flutter/issues/142178. Supersedes https://github.com/flutter/flutter/pull/142078. Feedback welcome to avoid reverts!
-
Polina Cherkasova authored
-
Qun Cheng authored
fix https://github.com/flutter/flutter/issues/121493 `SegmentedButton` uses `TextButton` for each segments. When we have `MaterialTapTargetSize.padded` for `TextButton`, we make sure the minimum tap target size is 48.0( this value can be adjusted by visual density), even tough the actual button size is smaller. When `SegmentedButton` paints segments by using `MultiChildRenderObjectWidget`, it also includes the tap target size so the button that it actually draws always has the same height as the height of the tap target size. To fix it, this PR firstly calculate the actual height of a text button in `SegmentedButton` class, then we can get the height delta if there is. Then the the value of (Segmented button render box height - the delta) would be the actual button size that we should see. For now, we are not able to customize the min, max, fixed size in [`SegmentedButton` style](https://api.flutter.dev/flutter/material/SegmentedButton/style.html). So the standard button height is always 40 and can only be customized by `style.visualDensity` and `style.tapTargetSize`; `SegmentedButton` only simulates the `TextButton` behavior when `TextButton`'s height is its default value.  https://github.com/flutter/flutter/assets/36861262/15ca6034-e6e0-4cc6-8fe3-808b4bd6a920
-
godofredoc authored
This is to reuse the global emulator configurations and make it easier to identify this test is running on an emulator.
-
Pierrick Bouvier authored
It's now possible to natively compile a flutter app for windows-arm64. Cross-compilation is not yet implemented. Uses arm64 artifacts now available for Dart/Flutter. Platform detection is based on Abi class, provided by Dart. Depending if Dart is an arm64 or x64 binary, the Abi is set accordingly. Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking PROCESSOR_ARCHITECTURE environment variable, which is the way to detect host architecture on Windows. This is available only for master channel (on other channels, it fallbacks to windows-x64). On windows-x64, it produces an x64 app. On windows-arm64, it produces an arm64 app.
-
- 25 Jan, 2024 22 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#142264 Initiated by: zanderso This change reverts the following previous change: Original Description: https://github.com/flutter/engine/compare/4b145d041560...44f26274bfbe 2024-01-25 dnfield@google.com Add include suggested by clang-tidy (flutter/engine#49898) 2024-01-25 smartercallum@gmail.com Refactor macOS trackpad gesture tracking (flutter/engine#49424) 2024-01-25 148634283+nikkivirtuoso@users.noreply.github.com winding order from tesellator.h to formats.h (flutter/engine#49865) 2024-01-25 ian@hixie.ch Roll webp to 1.3.2 (flutter/engine#49883) 2024-01-25 john@johnmccutchan.com Optimizations for TLHC frame rate and jank (flutter/engine#50033) 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
godofredoc authored
Note: some benchmarks will require to be rebaselined.
-
derdilla authored
Fixes a layout bug when using an EditableText and something containing an Ink widget.
-
dependabot[bot] authored
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.4 to 3.1.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p> <blockquote> <h2>v3.1.5</h2> <h2>What's Changed</h2> <ul> <li>action.yml: Update to Node.js 20 by <a href="https://github.com/hallabro"><code>@âhallabro</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1228">codecov/codecov-action#1228</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/hallabro"><code>@âhallabro</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1228">codecov/codecov-action#1228</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.4...v3.1.5">https://github.com/codecov/codecov-action/compare/v3.1.4...v3.1.5</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/codecov/codecov-action/commit/4fe8c5f003fae66aa5ebb77cfd3e7bfbbda0b6b0"><code>4fe8c5f</code></a> chore(release): bump to 3.1.5</li> <li><a href="https://github.com/codecov/codecov-action/commit/9140fdcf549f069e1ad6cc2bf17ee0251b024bfb"><code>9140fdc</code></a> action.yml: Update to Node.js 20 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1228">#1228</a>)</li> <li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/eaaf4bedf32dbdc6b720b63067d99c4d77d6047d...4fe8c5f003fae66aa5ebb77cfd3e7bfbbda0b6b0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4b145d041560...44f26274bfbe 2024-01-25 dnfield@google.com Add include suggested by clang-tidy (flutter/engine#49898) 2024-01-25 smartercallum@gmail.com Refactor macOS trackpad gesture tracking (flutter/engine#49424) 2024-01-25 148634283+nikkivirtuoso@users.noreply.github.com winding order from tesellator.h to formats.h (flutter/engine#49865) 2024-01-25 ian@hixie.ch Roll webp to 1.3.2 (flutter/engine#49883) 2024-01-25 john@johnmccutchan.com Optimizations for TLHC frame rate and jank (flutter/engine#50033) 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts "Reverts "Rename `integration_tests/external_ui` but do not touch anything else..."" (#142268) Reverts flutter/flutter#142265 Initiated by: matanlurey This change reverts the following previous change: Original Description: Reverts flutter/flutter#142238 Initiated by: eliasyishak This change reverts the following previous change: Original Description: Part of https://github.com/flutter/flutter/issues/142178.
-
auto-submit[bot] authored
Reverts flutter/flutter#142238 Initiated by: eliasyishak This change reverts the following previous change: Original Description: Part of https://github.com/flutter/flutter/issues/142178.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b2167a93c1a0...4b145d041560 2024-01-25 jonahwilliams@google.com [Impeller] Fix mipmap generation for Vulkan render target textures. (flutter/engine#49848) 2024-01-25 jason-simmons@users.noreply.github.com [Impeller] Do not emit metadata for structs that are not part of the shader's interface (flutter/engine#50029) 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from de46a989e0ca to 29b545e4356b (1 revision) (flutter/engine#50047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Nate authored
Refactors code to use the new `switch` expressions.
-
Matan Lurey authored
Part of https://github.com/flutter/flutter/issues/142178.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/55eefd5bd255...b2167a93c1a0 2024-01-25 jonahwilliams@google.com [Impeller] write vertices geometry data to host buffer. (flutter/engine#49741) 2024-01-25 jonahwilliams@google.com Revert "[Impeller] round up subpass coverage when it is close to (and smaller) than root pass size." (flutter/engine#50041) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3b4779324b44...55eefd5bd255 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from bcc2e8b6105a to de46a989e0ca (1 revision) (flutter/engine#50046) 2024-01-25 30870216+gaaclarke@users.noreply.github.com [Impeller] turned on vulkan validation for all but one golden test (flutter/engine#50045) 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 56c06ee7a252 to bcc2e8b6105a (2 revisions) (flutter/engine#50042) 2024-01-25 jonahwilliams@google.com [Impeller] call shutdown method in Android context. (flutter/engine#49992) 2024-01-25 maRci002@users.noreply.github.com [web] add support for AppLifecycleState changes (flutter/engine#44720) 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 416d7b0e5ba1 to 56c06ee7a252 (1 revision) (flutter/engine#50040) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LouiseHsu authored
Fixes https://github.com/flutter/flutter/issues/141764 Translation suggestion here: https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8222331119728136330&language=zh-CN ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.
-
Justin McCandless authored
Attempting to help users understand how to build a confirmation dialog when exiting a route.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1d3f16b0d62e...3b4779324b44 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 699ee2b7cf34 to 416d7b0e5ba1 (2 revisions) (flutter/engine#50039) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/8fbdf65d0235...21b5abba7958 2024-01-24 pageli328@gmail.com Add rfw widgets (flutter/packages#5661) 2024-01-24 50643541+Mairramer@users.noreply.github.com [camera] add heif support image iOS (flutter/packages#4586) 2024-01-24 jsharp83@gmail.com [webview_flutter_android] Add javascript panel interface for android (flutter/packages#5796) 2024-01-24 43054281+camsim99@users.noreply.github.com [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset (flutter/packages#5659) 2024-01-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/packages#5967) 2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter from 5b673c28 to 19b06f4e (21 revisions) (flutter/packages#5968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Sigurd Meldgaard authored
The legacy welcome message would be printed even if `CI=true` confusing parsers of the output. This fixes: https://github.com/flutter/flutter/issues/139737 --------- Co-authored-by:
eliasyishak <42216813+eliasyishak@users.noreply.github.com>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7c4ed15cb271...1d3f16b0d62e 2024-01-25 skia-flutter-autoroll@skia.org Roll Dart SDK from beb003009a4d to 2fb950853f06 (1 revision) (flutter/engine#50037) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e2014f007f61...7c4ed15cb271 2024-01-25 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49940) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5fa2e2920274...e2014f007f61 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 21c53af2e9f5 to 699ee2b7cf34 (1 revision) (flutter/engine#50034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Andrew Kolos authored
Part of work on [#101077](https://github.com/flutter/flutter/pull/141194). This is done as a separate PR to avoid a massive diff. ## Context 1. The `FakeCommand` class accepts a list of patterns that's used to match a command given to its `FakeProcessManager`. Since `FakeCommand` can match a list of patterns, not just specifically strings, it can be used to match commands where the exact value of some arguments can't (easily) known ahead of time. For example, a part of the tool may invoke a command with an argument that is the path of a temporarily file that has a randomly-generated basename. 2. The `FakeCommand` class provides on `onRun` parameter, which is a callback that is run when the `FakeProcessManager` runs a command that matches the `FakeCommand` in question. ## Issue In the event that a `FakeCommand` is constructed using patterns, the test code can't know the exact values used for arguments in the command. This PR proposes changing the type of `onRun` from `VoidCallback?` to `void Function(List<String>)?`. When run, the value `List<String>` parameter will be the full command that the `FakeCommand` matched. Example: ```dart FakeCommand( command: <Pattern>[ artifacts.getArtifactPath(Artifact.engineDartBinary), 'run', 'vector_graphics_compiler', RegExp(r'--input=/.*\.temp'), RegExp(r'--output=/.*\.temp'), ], onRun: (List<String> command) { final outputPath = (() { // code to parse `--output` from `command` })(); testFileSystem.file(outputPath).createSync(recursive: true); }, ) ```
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c346fd3d9ca1...5fa2e2920274 2024-01-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 6211fedca10c to beb003009a4d (1 revision) (flutter/engine#50032) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
![auto-submit[bot]'s avatar](https://secure.gravatar.com/avatar/266ceac20512ae5366aafb5e5452ef8b?s=80&d=identicon "auto-submit[bot]")
![dependabot[bot]'s avatar](https://secure.gravatar.com/avatar/48ea49be76d0c68403a7f3df87e3487d?s=80&d=identicon "dependabot[bot]")
