- 11 Mar, 2015 9 commits
-
-
Viet-Trung Luu authored
Also: * Fix consecutive spaces (don't collapse them). * Add support for ^L. Still doesn't work: * Totally blank lines. (I know why, but I don't know why I can't seem to fix it.) R=erg@chromium.org Review URL: https://codereview.chromium.org/997873004
-
Viet-Trung Luu authored
D'oh. TBR=erg@chromium.org Review URL: https://codereview.chromium.org/998103002
-
Viet-Trung Luu authored
(Together with an app that echoes stuff from the terminal.) R=erg@chromium.org Review URL: https://codereview.chromium.org/999193002
-
Adam Barth authored
To accomplish this, I made the following changes: 1) Material is now in charge of drawing the material shadows. 2) In order to mix in the style for the shadow, Element now takes a list of Styles instead of a single style. 3) Update all clients of Element#style to understand that we now have a list. 4) Update components that drawer shadows to have Material do that work instead. a) One exception: FloatingActionButton draws its own shadow because of its crazy clip requirements. We'll probably want to find a better way for FloatingActionButton to clip in the future. I've also added a widgets-fn example to demo the fn material widgets. This CL introduces a bug into Drawer whereby you can get ink splashes everywhere in the drawer. In the future, we'll need to separate out the different material aspects to get non-splashable materials. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1003553002
-
Eric Seidel authored
We're not actively developing these at the moment. I could also just delete them, not sure if we're ready for that yet. TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/999873002
-
Adam Barth authored
We don't yet reset the scroll offset, so sometimes you can't see your search results properly. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1002453003
-
Adam Barth authored
R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/996213004
-
Adam Barth authored
Instead of MaterialComponent being a base class, components that want material behavior simply create a MaterialComponent during their render function. This approach gives the component more flexibility as to its structure and gives MaterialComponent more flexibility has to how the components it generates are related to the existing children. Also, I've improved some of the event delegation code. There's no reason to attach event handlers to the root component you emit during |render| because the framework already delegates events from your root component to you. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/983903003
-
Adam Barth authored
The search field doesn't do anything, but it's there. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/998803002
-
- 10 Mar, 2015 7 commits
-
-
Adam Barth authored
Moving these files into sky/framework will make them easier to use from the SDK. Also, this CL also splits up the giant "widgets" library into smaller libraries, one per component. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/993033003
-
Adam Barth authored
The implementation details are in sky/framework/editing. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/983213005
-
Adam Barth authored
We don't yet have a focus controller, which means once this control becomes focused there's no way for it to lose focus. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/999553002
-
Eric Seidel authored
http://www.google.com/design/spec/components/lists.html#lists-behavior R=abarth@chromium.org Review URL: https://codereview.chromium.org/993093004
-
Eric Seidel authored
54px on small screens: http://www.google.com/design/spec/layout/metrics-keylines.html#metrics-keylines-keylines-spacing TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/995133002
-
Adam Barth authored
This CL factors EditableString out of EditableText and implements more of the InputConnection functions. As a result, EditableText now basically works. This CL also paves the way to make EditableText stateless by using EditableString as its state object. However, there's still a bit more work to do to make that a reality (e.g., factoring out the cursor blink timer and the connection to the keyboard). R=eseidel@chromium.org Review URL: https://codereview.chromium.org/995073002
-
Rafael Weinstein authored
This patch allows for an initial delay before an animation begins and also adds an Animation class which encapsulates a value which is long-lived, can be explicitly set and also animated from its current value to another value. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/994143002
-
- 09 Mar, 2015 3 commits
-
-
Adam Barth authored
This CL introduces a new keyboard service that understands Android IME and starts work on a Input component that interacts with this service to provide an editing control. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/995613002
-
Rafael Weinstein authored
"Render" is misleading. "Build" may not be the best word either, it's closer to what's actually happening. R=ojan@chromium.org TBR=abarth BUG= Review URL: https://codereview.chromium.org/992033002
-
Rafael Weinstein authored
Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable to inspect heights rather than having the passed in BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/994553003
-
- 06 Mar, 2015 5 commits
-
-
Rafael Weinstein authored
TBR=eseidel BUG= Review URL: https://codereview.chromium.org/987833002
-
Rafael Weinstein authored
This patch changes the timing of the unmount call until after the component is removed (and marked as such) and allows setState to be called after this point. If this happens, setState will still invoke the closer to do any neccesary cleanup, but doesn't schedule the component for render R=eseidel@chromium.org, eseidel BUG= Review URL: https://codereview.chromium.org/985853002
-
Rafael Weinstein authored
TBR=eseidel BUG= Review URL: https://codereview.chromium.org/983173003
-
Adam Barth authored
This provokes a rendering bug in MojoShell but not in SkyShell. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/984793002
-
Eric Seidel authored
To test: sky/tools/shelldb analyze sky/examples/stocks-fn/stocksapp.dart It prints 600+ warnings about the "native" keyword, and after this change only a couple warnings about missing library names which I don't fully understand. R=abarth@chromium.org Review URL: https://codereview.chromium.org/987613002
-
- 05 Mar, 2015 12 commits
-
-
Hixie authored
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980043005
-
Adam Barth authored
That's where it belongs. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/979283002
-
Adam Barth authored
It's awkward to work on fn.dart in the examples directory so this CL moves it to /sky/framework. Also, I've merged the whole library into one file instead of using the |part| mechanism. The whole thing isn't that big. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/987463002
-
Adam Barth authored
These examples don't work anymore and have been replaced with color-chooser.sky. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/987443002
-
Adam Barth authored
This CL changes the duration of the drawer animation to match the values used by the Android framework. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/976193002
-
Adam Barth authored
- Removed out-of-date README.md - Moved fling-curve into the animation directory because it's part of the animation behavior of the system. - Moved view-configuration into the theme directory because it's a collection of constants similar in flavor to the colors and the shadows. Eventually we'll want to make the theme configurable and have these all together will hopefully make that easier. - Moved dom-serializer into tests/resources because it is used only by tests. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980423002
-
Adam Barth authored
Instead, we can just use the existing animation/curves.dart file in the framework. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/976373003
-
Adam Barth authored
This CL removes the hard-coded colors and shadows from the fn widgets and replaces them with compile-time constants. The color values are from the material spec: http://www.google.com/design/spec/style/color.html#color-color-palette R=eseidel@chromium.org Review URL: https://codereview.chromium.org/983733003
-
Adam Barth authored
Instead of duplicating fling-curve.dart in fn, we now share the existing copy in sky/framework. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/976363003
-
Adam Barth authored
Previously, the two versions of this sample app had separate copies of the stock data. This CL moves the common data to the common data directory so that they can share. Also, I've switched the data files to be |dart| files rather than |sky| files to make them easier to use from fn examples. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980953002
-
Adam Barth authored
This CL removes a bunch of examples that don't actually work in the current engine. I've also renamed example-element to custom-element and example-scrollable to scrolling because the word "example" in the name is redundant with the name of the directory. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980323003
-
Adam Barth authored
This CL changes how events work in fn. Previously, event listeners were passed in as constructor arguments. Now Nodes hold an |events| object, which contains all the event registrations. When a Component renders, all its |events| are copied onto the Node it produces. When an Element syncs, it walks its |events| and adds them as event listeners on the underlying sky.Element. The net result of this change is increased flexibility in how events are registered. Now components don't need to enumerate all the possible events that they support. Instead, the parent component can listen for whatever events it likes. Also, I've cleaned up the association between DrawerAnimation and Drawer. Now the constructor for Drawer accepts an |animation| object and wires up its internal event handlers itself instead of requiring the constructor to do all the wiring. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975863003
-
- 04 Mar, 2015 3 commits
-
-
Adam Barth authored
This CL adds license blocks and cleans up a number of Dart idioms in fn. Specifically, I've marked several fields as |final| and used Map#putIfAbsent in some appropriate places. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/973613004
-
Rafael Weinstein authored
-
Adam Barth authored
R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/970393002
-
- 03 Mar, 2015 1 commit
-
-
Adam Barth authored
If there is jank, we might not get a frame time that's just after the last frame, which means we'll stop generating animation frames before hitting 1.0 exactly. In this CL, we introduce state to takeWhile to cancel the stream after emitting the 1.0. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975153002
-