1. 16 Aug, 2019 1 commit
    • Nurhan Turgut's avatar
      Navigator change backup (#38494) · c2e2f093
      Nurhan Turgut authored
      * Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route
      
      * Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route
      
      * Reverting all unrelated formatting changes.
      
      * Adding unit tests. Adding more comments.
      
      * Changing string method names with constant strings.
      
      * Fixing a constant strings.
      
      * Fixing analyzer error.
      
      * Fixing more white space.
      
      * Changing the method names. Adding comments to the SystemChannels
      
      * Comment and code name fixes
      
      * replacing the comment with reviewer suggestion.
      
      * addinf systemchannels.navigation mock to test bindings
      
      * Adding a new class for sending route change notrifications. The nottifications are only sent on web. This should fix breaking android/ios
      
      * using new class RouteNotificationMessages in navigator
      
      * Fixing analyzer issues.
      
      * fixing cycle dependency
      
      * fixing github analyze error
      
      * dartfmt two new classes. trying to fix anayze errors
      
      * Update route_notification_messages.dart
      
      * trying to fix white space errors
      c2e2f093
  2. 09 Aug, 2019 2 commits
  3. 19 Jul, 2019 1 commit
  4. 16 Jul, 2019 1 commit
  5. 02 Jul, 2019 1 commit
  6. 28 Jun, 2019 1 commit
    • David Shuckerow's avatar
      Make it possible to override the FLUTTER_TEST env variable (#34301) · df6e4d48
      David Shuckerow authored
      * Make it possible to override the FLUTTER_TEST env variable without unsetting it.
      
      * Switch to using platform instead of Platform.
      
      * Document the bindings, and introduce tests that initialize multiple WidgetsBindings with different environments.
      
      * Add tests for the flutter platform test.
      
      * Add license headers
      
      * Fix lints
      
      * Remove trailing whitespace
      
      * Respond to Jonahs comments
      
      * Respond to Ians comments
      
      * Mock out the HttpServer in flutter_platform_test
      
      * Mock out the HttpServer in flutter_platform_test
      
      * Explain why we mock out the HttpServer in flutter_platform_test
      df6e4d48
  7. 26 Jun, 2019 1 commit
  8. 22 Jun, 2019 1 commit
    • Todd Volkert's avatar
      Prepare for HttpClientResponse Uint8List SDK change (#34863) · e8270ff6
      Todd Volkert authored
      * Prepare for HttpClientResponse Uint8List SDK change
      
      An upcoming change in the Dart SDK will change `HttpClientResponse`
      from implementing `Stream<List<int>>` to instead implement
      `Stream<Uint8List>`.
      
      This forwards-compatible change to `_MockHttpClientResponse` is being
      made to allow for a smooth rollout of that SDK breaking change. The
      current structure of the class is as follows:
      
      ```dart
      _MockHttpClientResponse extends Stream<List<int>> implements HttpClientResponse {
        ...
      }
      ```
      
      This structure would require that the Dart SDK change land atomically
      a change to the class (`extends Stream<Uint8List>`). This atomic landing
      requirement doesn't play well at all with Flutter's roll model vis-a-vis
      the Dart SDK's roll model to Google's internal repo.  As such, this commit
      changes the structure of `_MockHttpClientResponse` to be:
      
      ```dart
      _MockHttpClientResponse implements HttpClientResponse {
        final Stream<Uint8List> _delegate;
      
        ...
      }
      ```
      
      Once the Dart SDK change has fully rolled out, we can simplify this class
      back to its former structure.
      
      https://github.com/dart-lang/sdk/issues/36900
      
      * Review comment
      e8270ff6
  9. 13 Jun, 2019 1 commit
  10. 12 Jun, 2019 1 commit
  11. 07 Jun, 2019 1 commit
  12. 03 Jun, 2019 1 commit
  13. 01 Jun, 2019 1 commit
  14. 28 May, 2019 1 commit
  15. 20 May, 2019 1 commit
  16. 17 May, 2019 1 commit
  17. 13 May, 2019 1 commit
    • Greg Spencer's avatar
      Fix transforms for things with RenderPointerListeners (#32535) · a5053bfb
      Greg Spencer authored
      This fixes #32525, because it now marks the compositing bits as needing to be recalculated if the mouse tracker changes its idea of whether or not a mouse is attached.
      
      This bug occurred because the test framework was leaking state from one test to the next (the state about whether a mouse pointer was active), and so even though there was a "passing" test when run in order with the other tests in the file, when the test was run individually (or first), it would have failed and caught the bug.
      
      This adds an assert to make sure that after each test there are no simulated mouse pointers connected, and now calls removePointer in all of the tests where this was a problem.
      a5053bfb
  18. 01 May, 2019 1 commit
  19. 30 Apr, 2019 1 commit
  20. 25 Apr, 2019 2 commits
  21. 23 Apr, 2019 1 commit
  22. 22 Apr, 2019 1 commit
    • Greg Spencer's avatar
      Implement focus traversal for desktop platforms, shoehorn edition. (#30040) · 4218c0bc
      Greg Spencer authored
      Implements focus traversal for desktop platforms, including re-implementing the existing focus manager and focus tree.
      
      This implements a Focus widget that can be put into a widget tree to allow input focus to be given to a particular part of a widget tree.
      
      It incorporates with the existing FocusScope and FocusNode infrastructure, and has minimal breakage to the API, although FocusScope.reparentIfNeeded is removed, replaced by a call to FocusAttachment.reparent(), so this is a breaking change:
      
      FocusScopeNodes must now be attached to the focus tree using FocusScopeNode.attach, which takes a context and an optional onKey callback, and returns a FocusAttachment that should be kept by the widget that hosts the FocusScopeNode. This is necessary because of the need to make sure that the focus tree reflects the widget hierarchy.
      
      Callers that used to call FocusScope(context).reparentIfNeeded in their build method will call reparent  on a FocusAttachment instead, which they will obtain by calling FocusScopeNode.attach in their initState method. Widgets that own FocusNodes will need to call dispose on the focus node in their dispose method.
      
      Addresses #11344, #1608, #13264, and #1678
      Fixes #30084
      Fixes #26704
      4218c0bc
  23. 18 Apr, 2019 1 commit
  24. 15 Apr, 2019 1 commit
  25. 10 Apr, 2019 1 commit
  26. 22 Mar, 2019 1 commit
  27. 09 Mar, 2019 1 commit
  28. 08 Mar, 2019 1 commit
  29. 06 Mar, 2019 2 commits
  30. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  31. 21 Feb, 2019 1 commit
  32. 15 Feb, 2019 1 commit
  33. 05 Feb, 2019 1 commit
  34. 30 Jan, 2019 1 commit
  35. 29 Jan, 2019 2 commits
  36. 22 Jan, 2019 1 commit