- 02 Oct, 2018 1 commit
-
-
jensjoha authored
-
- 01 Oct, 2018 3 commits
-
-
Alexandre Ardhuin authored
-
Jonah Williams authored
This reverts commit b07d986f.
-
Chris Bracken authored
Eliminates the --snapshot and --depfile parameters from the flutter bundle command. The snapshot parameter is unused in Dart 2 -- code is built to kernel .dill files and for profile/release builds, then AOT compiled. While depfiles are still used in Dart 2 (e.g. by the kernel compiler), there are enough assumptions in the code that they lie in the default location (e.g. in the Gradle build) and no reasons to support user-cusomisation that it makes sense to eliminate the --depfile option as well, and always use the default location. This commit also renames 'depFilePath' to 'depfilePath' for consistency across the codebase.
-
- 20 Sep, 2018 2 commits
-
-
Greg Spencer authored
This changes the compiler output for gradle to be less verbose and more easily read. This only applies to compilation error messages: other gradle messages will continue to print as before. It also fixes a small problem with the performance measurement printing (see that "7.1s" on it's own line in the original?) so that if something is expected to have multiple lines of output, it prints an initial line, and a "Done" line with the elapsed time, so that it's possible to know what the time applies to. It also updates the spinner to be fancier, at least on platforms other than Windows (which is missing a lot of symbols in its console font). Addresses #17307
-
Alexander Markov authored
-
- 19 Sep, 2018 1 commit
-
-
Greg Spencer authored
This adds support to AnsiTerminal for colored output, and makes all tool output written to stderr (with the printError function) colored red. No color codes are sent if the terminal doesn't support color (or isn't a terminal). Also makes "progress" output print the elapsed time when not connected to a terminal, so that redirected output and terminal output match (redirected output doesn't print the spinner, however). Addresses #17307
-
- 14 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 11 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Sep, 2018 2 commits
-
-
Chris Bracken authored
This tickled a bug in KernelCompiler.compile() where the fingerprinter doesn't include the outputFilePath in its list of dependencies. As such, if the output .dill file is missing or corrupted, the fingerprint still matches and re-compile is skipped, even though it shouldn't be. I'll fix that in a followup, then look at how this triggered that issue. My hypothesis is that that it's due to the aot kernel compile and bundle kernel compile have separate output directories for the .dill files (build/ vs build/aot) but the same output directory for the associated depfiles (due to this patch). This reverts commit 43a106e9.
-
Chris Bracken authored
The --snapshot argument was only necessary in Dart 1. The --depfile argument was only used in Dart 2 mode to pass to the kernel compiler, but was inconsistent with the 'build aot' command, where the depfile was always set to build/kernel_compile.d. This patch updates 'build bundle' to emit the depfile to a location consistent with the 'build aot' command; since it's not intended to be user-configurable and flutter.gradle hardcodes the location to build/kernel_compile.d either way, this patch also eliminates the ability to configure the filename altogether.
-
- 04 Sep, 2018 1 commit
-
-
jensjoha authored
-
- 31 Aug, 2018 1 commit
-
-
Chris Bracken authored
Its type uses a generic type which is limited to library-visibility. Eliminating compilationQueue from ResidentCompiler's public interface makes it possible to mock in tests.
-
- 29 Aug, 2018 1 commit
-
-
Alexander Aprelev authored
Workaround is not needed since real fix has landed in dart sdk: https://dart-review.googlesource.com/c/sdk/+/62729.
-
- 21 Aug, 2018 1 commit
-
-
Ian Hickson authored
Fixes the pattern for some TODOs to match our style guide. (Also, a couple of minor code order fixes.)
-
- 16 Aug, 2018 1 commit
-
-
Stanislav Baranov authored
-
- 15 Aug, 2018 2 commits
-
-
Jonah Williams authored
* Revert "iOS Dialog blur, brightness, and layout (#18381)" This reverts commit 21bc9f1b. * Revert "Flutter tool support for dynamic code. (#20543)" This reverts commit 25ba90aa.
-
Stanislav Baranov authored
-
- 12 Jul, 2018 1 commit
-
-
Alexander Aprelev authored
* Preserve original kernel file for isolate spawn requests. This change gives incremental kernel files ".incremental.dill" extension thereby preserving original kernel file. Bug: https://github.com/flutter/flutter/issues/16084 Bug: https://github.com/flutter/flutter/issues/17012 Bug: https://github.com/flutter/flutter/issues/17983 * Factor out naming logic into separate function * Fix string vs uri
-
- 29 Jun, 2018 1 commit
-
-
sjindel-google authored
Fixes #18829
-
- 28 Jun, 2018 1 commit
-
-
Alexander Aprelev authored
-
- 22 Jun, 2018 1 commit
-
-
Alexander Aprelev authored
* Suppress stdout compile diagnostic when compile expressions. This fixes https://github.com/flutter/flutter/issues/18574. * Use equal sign for default values
-
- 21 Jun, 2018 1 commit
-
-
Alexander Aprelev authored
* Serialize compilation requests.
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 11 Jun, 2018 1 commit
-
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 07 Jun, 2018 1 commit
-
-
Chris Bracken authored
Thie field is never used outside of the class and has a private type, making it impossible to subclass/mock.
-
- 05 Jun, 2018 2 commits
-
-
Alexander Aprelev authored
This registers compile-expression service that is used by dart vm to evaluate expressions when debugging flutter applications.
-
Alexandre Ardhuin authored
-
- 30 May, 2018 2 commits
-
-
Greg Spencer authored
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041) This reverts commit 32586020.
-
Greg Spencer authored
Fixes #18028 Just changes typedef declarations, no logic changes.
-
- 29 May, 2018 1 commit
-
-
Mikkel Nygaard Ravn authored
-
- 28 May, 2018 1 commit
-
-
Florian Loitsch authored
Enable --sync-async in Flutter. Fixes #16801
-
- 24 May, 2018 2 commits
-
-
Mikkel Nygaard Ravn authored
This reverts commit 39d7f22a.
-
Florian Loitsch authored
-
- 09 May, 2018 1 commit
-
-
Chris Bracken authored
We've always cached kernel compiles during bundle builds. This adds caching for kernel compiles during AOT builds by moving caching into the KernelCompiler.compile() method rather than around each invocation of it. This also filters buildbot paths included by the kernel compile that are not present on the local machine at paths /b/build/slave/Linux_Engine/... The kernel compiler should probably include an option to not emit these paths in the depfile, since these are used both by Gradle and the Fingerprinter class.
-
- 26 Apr, 2018 1 commit
-
-
Todd Volkert authored
-
- 24 Apr, 2018 2 commits
-
-
Chris Bracken authored
CompilerOutput values should never be mutated. Also includes minor formatting change to the compile() method signature in line with the style guide. Minor housekeeping while I'm touching other bits of nearby code.
-
Chris Bracken authored
Wraps the compile function in a class injected via the global context, which makes it easier to mock in unit tests -- specifically tests for AOT snapshotting, which already require pretty significant amounts of mock inputs.
-
- 20 Apr, 2018 1 commit
-
-
Michael Goderbauer authored
-