1. 02 Oct, 2018 1 commit
  2. 01 Oct, 2018 3 commits
  3. 20 Sep, 2018 2 commits
    • Greg Spencer's avatar
      Simplify Gradle compiler output. (#21760) · efcd9a80
      Greg Spencer authored
      This changes the compiler output for gradle to be less verbose and more easily read.
      
      This only applies to compilation error messages: other gradle messages will continue to print as before.
      
      It also fixes a small problem with the performance measurement printing (see that "7.1s" on it's own line in the original?) so that if something is expected to have multiple lines of output, it prints an initial line, and a "Done" line with the elapsed time, so that it's possible to know what the time applies to.
      
      It also updates the spinner to be fancier, at least on platforms other than Windows (which is missing a lot of symbols in its console font).
      
      Addresses #17307
      efcd9a80
    • Alexander Markov's avatar
      83cdb573
  4. 19 Sep, 2018 1 commit
    • Greg Spencer's avatar
      Added more extensive ANSI color printing support on terminals. (#20958) · 7caa6594
      Greg Spencer authored
      This adds support to AnsiTerminal for colored output, and makes all tool output written to stderr (with the printError function) colored red.
      
      No color codes are sent if the terminal doesn't support color (or isn't a terminal).
      
      Also makes "progress" output print the elapsed time when not connected to a terminal, so that redirected output and terminal output match (redirected output doesn't print the spinner, however).
      
      Addresses #17307
      7caa6594
  5. 14 Sep, 2018 1 commit
  6. 12 Sep, 2018 1 commit
  7. 11 Sep, 2018 1 commit
  8. 07 Sep, 2018 2 commits
    • Chris Bracken's avatar
      Revert "Eliminate snapshot/depfile options to build bundle (#21507)" (#21563) · 5ab9e707
      Chris Bracken authored
      This tickled a bug in KernelCompiler.compile() where the fingerprinter
      doesn't include the outputFilePath in its list of dependencies. As such,
      if the output .dill file is missing or corrupted, the fingerprint still
      matches and re-compile is skipped, even though it shouldn't be. I'll fix
      that in a followup, then look at how this triggered that issue. My
      hypothesis is that that it's due to the aot kernel compile and bundle
      kernel compile have separate output directories for the .dill files
      (build/ vs build/aot) but the same output directory for the associated
      depfiles (due to this patch).
      
      This reverts commit 43a106e9.
      5ab9e707
    • Chris Bracken's avatar
      Eliminate snapshot/depfile options to build bundle (#21507) · 43a106e9
      Chris Bracken authored
      The --snapshot argument was only necessary in Dart 1. The --depfile
      argument was only used in Dart 2 mode to pass to the kernel compiler,
      but was inconsistent with the 'build aot' command, where the depfile was
      always set to build/kernel_compile.d.
      
      This patch updates 'build bundle' to emit the depfile to a location
      consistent with the 'build aot' command; since it's not intended to be
      user-configurable and flutter.gradle hardcodes the location to
      build/kernel_compile.d either way, this patch also eliminates the
      ability to configure the filename altogether.
      43a106e9
  9. 04 Sep, 2018 1 commit
  10. 31 Aug, 2018 1 commit
  11. 29 Aug, 2018 1 commit
  12. 21 Aug, 2018 1 commit
  13. 16 Aug, 2018 1 commit
  14. 15 Aug, 2018 2 commits
  15. 12 Jul, 2018 1 commit
  16. 29 Jun, 2018 1 commit
  17. 28 Jun, 2018 1 commit
  18. 22 Jun, 2018 1 commit
  19. 21 Jun, 2018 1 commit
  20. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  21. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  22. 07 Jun, 2018 1 commit
  23. 05 Jun, 2018 2 commits
  24. 30 May, 2018 2 commits
  25. 29 May, 2018 1 commit
  26. 28 May, 2018 1 commit
  27. 24 May, 2018 2 commits
  28. 09 May, 2018 1 commit
    • Chris Bracken's avatar
      Add caching for kernel compiles during AOT builds (#17439) · 5d8d14b7
      Chris Bracken authored
      We've always cached kernel compiles during bundle builds. This adds
      caching for kernel compiles during AOT builds by moving caching into the
      KernelCompiler.compile() method rather than around each invocation of it.
      
      This also filters buildbot paths included by the kernel compile that are
      not present on the local machine at paths /b/build/slave/Linux_Engine/...
      The kernel compiler should probably include an option to not emit these
      paths in the depfile, since these are used both by Gradle and the
      Fingerprinter class.
      5d8d14b7
  29. 26 Apr, 2018 1 commit
  30. 24 Apr, 2018 2 commits
    • Chris Bracken's avatar
      Make CompilerOutput immutable (#16942) · 4ad190e7
      Chris Bracken authored
      CompilerOutput values should never be mutated. Also includes minor
      formatting change to the compile() method signature in line with the
      style guide.
      
      Minor housekeeping while I'm touching other bits of nearby code.
      4ad190e7
    • Chris Bracken's avatar
      Extract KernelCompiler class (#16937) · 7ffcd3d2
      Chris Bracken authored
      Wraps the compile function in a class injected via the global context,
      which makes it easier to mock in unit tests -- specifically tests for
      AOT snapshotting, which already require pretty significant amounts of
      mock inputs.
      7ffcd3d2
  31. 20 Apr, 2018 1 commit