Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
39d7f22a
Commit
39d7f22a
authored
May 24, 2018
by
Florian Loitsch
Committed by
Mikkel Nygaard Ravn
May 24, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable --sync-async in Flutter. (#17866)
parent
d5a10340
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
16 additions
and
2 deletions
+16
-2
exception_handling_expectation.txt
...ted_tests/flutter_test/exception_handling_expectation.txt
+4
-1
test_async_utils_guarded_test.dart
...ted_tests/flutter_test/test_async_utils_guarded_test.dart
+4
-1
binding.dart
packages/flutter_test/lib/src/binding.dart
+6
-0
compile.dart
packages/flutter_tools/lib/src/compile.dart
+2
-0
No files found.
dev/automated_tests/flutter_test/exception_handling_expectation.txt
View file @
39d7f22a
...
...
@@ -43,7 +43,10 @@ Who lives, who dies, who tells your story\?
When the exception was thrown, this was the stack:
#[0-9]+ +main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]flutter_test[/\\]exception_handling_test\.dart:16:9\)
#[0-9]+ +main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]flutter_test[/\\]exception_handling_test\.dart:15:77\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]binding.dart:[0-9]+:[0-9]+\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]binding.dart:[0-9]+:[0-9]+\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]binding.dart:[0-9]+:[0-9]+\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]binding.dart:[0-9]+:[0-9]+\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\)
<<skip until matching line>>
^\(elided [0-9]+ .+\)$
...
...
dev/automated_tests/flutter_test/test_async_utils_guarded_test.dart
View file @
39d7f22a
...
...
@@ -14,7 +14,10 @@ class TestTestBinding extends AutomatedTestWidgetsFlutterBinding {
Future
<
Null
>
guardedHelper
(
WidgetTester
tester
)
{
return
TestAsyncUtils
.
guard
(()
async
{
await
tester
.
pumpWidget
(
const
Text
(
'Hello'
));
await
tester
.
pumpWidget
(
const
Directionality
(
textDirection:
TextDirection
.
ltr
,
child:
const
Text
(
'Hello'
),
));
});
}
...
...
packages/flutter_test/lib/src/binding.dart
View file @
39d7f22a
...
...
@@ -767,6 +767,12 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
});
return
new
Future
<
Null
>.
microtask
(()
async
{
// Run all queued microtasks.
await
new
Future
<
Null
>.
microtask
(()
{});
// When the test had an exception, the test-framework already
// ran the teardown functions, removing the _fakeAsync function.
if
(
_fakeAsync
==
null
)
return
null
;
// Resolve interplay between fake async and real async calls.
_fakeAsync
.
flushMicrotasks
();
while
(
_pendingAsyncTasks
!=
null
)
{
...
...
packages/flutter_tools/lib/src/compile.dart
View file @
39d7f22a
...
...
@@ -120,6 +120,7 @@ class KernelCompiler {
'--sdk-root'
,
sdkRoot
,
'--strong'
,
'--sync-async'
,
'--target=flutter'
,
];
if
(
trackWidgetCreation
)
...
...
@@ -252,6 +253,7 @@ class ResidentCompiler {
_sdkRoot
,
'--incremental'
,
'--strong'
,
'--sync-async'
,
'--target=flutter'
,
];
if
(
outputPath
!=
null
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment