Commit 39d7f22a authored by Florian Loitsch's avatar Florian Loitsch Committed by Mikkel Nygaard Ravn

Enable --sync-async in Flutter. (#17866)

parent d5a10340
......@@ -43,7 +43,10 @@ Who lives, who dies, who tells your story\?
When the exception was thrown, this was the stack:
#[0-9]+ +main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]flutter_test[/\\]exception_handling_test\.dart:16:9\)
#[0-9]+ +main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]flutter_test[/\\]exception_handling_test\.dart:15:77\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]binding.dart:[0-9]+:[0-9]+\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]binding.dart:[0-9]+:[0-9]+\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]binding.dart:[0-9]+:[0-9]+\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]binding.dart:[0-9]+:[0-9]+\)
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\)
<<skip until matching line>>
^\(elided [0-9]+ .+\)$
......
......@@ -14,7 +14,10 @@ class TestTestBinding extends AutomatedTestWidgetsFlutterBinding {
Future<Null> guardedHelper(WidgetTester tester) {
return TestAsyncUtils.guard(() async {
await tester.pumpWidget(const Text('Hello'));
await tester.pumpWidget(const Directionality(
textDirection: TextDirection.ltr,
child: const Text('Hello'),
));
});
}
......
......@@ -767,6 +767,12 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
});
return new Future<Null>.microtask(() async {
// Run all queued microtasks.
await new Future<Null>.microtask(() {});
// When the test had an exception, the test-framework already
// ran the teardown functions, removing the _fakeAsync function.
if (_fakeAsync == null)
return null;
// Resolve interplay between fake async and real async calls.
_fakeAsync.flushMicrotasks();
while (_pendingAsyncTasks != null) {
......
......@@ -120,6 +120,7 @@ class KernelCompiler {
'--sdk-root',
sdkRoot,
'--strong',
'--sync-async',
'--target=flutter',
];
if (trackWidgetCreation)
......@@ -252,6 +253,7 @@ class ResidentCompiler {
_sdkRoot,
'--incremental',
'--strong',
'--sync-async',
'--target=flutter',
];
if (outputPath != null) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment