Commits · 0386f910d1448333d30d3cd0793f46e315103178 · abdullh.alsoleman / Front-End

31 Jul, 2023 6 commits

[flutter_tools/dap] Improve rendering of structured errors via DAP (#131251) · 0386f910

Danny Tuppeny authored Jul 31, 2023

In the legacy VS Code DAP, we would deserialise the Flutter.Error event
and provide some basic colouring (eg. stack frames are faded if not from
user code and the text is split between stdout/stderr to allow the
client to colour it).

In the new DAPs we originally used `renderedErrorText` which didn't
support either of these. This change adds changes to use the structured
data (with some basic parsing because the source classes are in
package:flutter and not accessible here) to provide a similar
experience.

It would be nicer if we could use the real underlying Flutter classes
for this deserialisation, but extracting them from `package:flutter` and
removing all dependencies on Flutter is a much larger job and I don't
think should hold up providing improved error formatting for the new
DAPs.

Some comparisons:


![1_comparison](https://github.com/flutter/flutter/assets/1078012/74e7e6d6-c8d0-471f-b584-37ae148b0ce7)


![2_comparison](https://github.com/flutter/flutter/assets/1078012/21888934-6f2f-4048-86d7-bdf92d5c7301)

0386f910

[doc] Fix module_test_ios comments (#131470) · fceaa005
Daco Harkes authored Jul 31, 2023

fceaa005

Use Flutter app project's NDK version from FFI plugin (#131141) · c05c3d39

Donghyun Kim authored Jul 31, 2023

<img width="1119" alt="image" src="https://github.com/flutter/flutter/assets/66480156/e2e8eed1-3bef-436c-b21f-3891bdbe05bb">

In most cases, a FFI plugin doesn't need its own specific Android NDK version. Just following the Flutter app project's NDK version is enough.

If a Flutter app project depends on multiple FFI plugins that use different Android NDK versions, it can be quite wasteful and use excessive disk space due to multiple NDK installations.

Using Flutter app project's NDK version is also less error-prone because upgrading the Flutter SDK would be enough when upgrading FFI plugins(If project's `ndkVersion` is `flutter.ndkVersion`), without messing with Android NDK installations.

This problem was discussed in some actual FFI plugin repositories, and they are striving to find their own solutions:
- https://github.com/superlistapp/super_native_extensions/issues/143#issuecomment-1646207706
- https://github.com/cunarist/rust-in-flutter/discussions/60#discussioncomment-6484218
- https://github.com/rive-app/rive-flutter/issues/320
- https://github.com/juicycleff/flutter-unity-view-widget/issues/832

c05c3d39

Roll Flutter Engine from 22f9aad5aba5 to b11a832ea7d4 (2 revisions) (#131597) · f43755d3

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/engine/compare/22f9aad5aba5...b11a832ea7d4

2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 91b838fe533d to 6ee21fa70879 (1 revision) (flutter/engine#44160)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 1146dd2212ba to 91b838fe533d (1 revision) (flutter/engine#44159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f43755d3

Roll Flutter Engine from b84c93601684 to 22f9aad5aba5 (3 revisions) (#131592) · af5d9c19

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/engine/compare/b84c93601684...22f9aad5aba5

2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 3febb7d97cb0 to 1146dd2212ba (1 revision) (flutter/engine#44158)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 0e62d11175aa to 3febb7d97cb0 (1 revision) (flutter/engine#44156)
2023-07-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5tPeR3pmLZVAbR1iy... to SqCbKBft29XeD2Qvw... (flutter/engine#44155)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 5tPeR3pmLZVA to SqCbKBft29Xe

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

af5d9c19

Roll Flutter Engine from d95adb9c8bc6 to b84c93601684 (1 revision) (#131585) · 46f83ce6

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/engine/compare/d95adb9c8bc6...b84c93601684

2023-07-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 17au0GOALWDVfQnwu... to c0Pr9uG-46yC83ZVy... (flutter/engine#44154)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 17au0GOALWDV to c0Pr9uG-46yC

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

46f83ce6

30 Jul, 2023 5 commits

Roll Flutter Engine from 0ccff9a2bad3 to d95adb9c8bc6 (1 revision) (#131578) · 1d44fbd8

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/0ccff9a2bad3...d95adb9c8bc6

2023-07-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 38hspwoyzrqU6GbsM... to 5tPeR3pmLZVAbR1iy... (flutter/engine#44152)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 38hspwoyzrqU to 5tPeR3pmLZVA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1d44fbd8

Roll Flutter Engine from f3d1e004f7b1 to 0ccff9a2bad3 (1 revision) (#131571) · 063d68b1

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/f3d1e004f7b1...0ccff9a2bad3

2023-07-30 skia-flutter-autoroll@skia.org Roll Skia from 01451297ae1b to 0e62d11175aa (1 revision) (flutter/engine#44151)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

063d68b1

Roll Flutter Engine from 9d4bf38f987f to f3d1e004f7b1 (1 revision) (#131569) · 7d258cb4

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/9d4bf38f987f...f3d1e004f7b1

2023-07-30 skia-flutter-autoroll@skia.org Roll Skia from c33c0619b892 to 01451297ae1b (1 revision) (flutter/engine#44150)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7d258cb4

Roll Flutter Engine from 12ce9f013cef to 9d4bf38f987f (1 revision) (#131564) · 9758d773

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/12ce9f013cef...9d4bf38f987f

2023-07-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VIjw2bdybUo-rgC0t... to 17au0GOALWDVfQnwu... (flutter/engine#44148)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from VIjw2bdybUo- to 17au0GOALWDV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9758d773

Roll Flutter Engine from 590ff28649eb to 12ce9f013cef (2 revisions) (#131562) · 4d245a84

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/590ff28649eb...12ce9f013cef

2023-07-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -5L2wI7BjRNgnccfl... to 38hspwoyzrqU6GbsM... (flutter/engine#44145)
2023-07-30 skia-flutter-autoroll@skia.org Roll ANGLE from 0abd6f549ff1 to 143fa68f50b7 (1 revision) (flutter/engine#44144)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from -5L2wI7BjRNg to 38hspwoyzrqU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d245a84

29 Jul, 2023 11 commits

Roll Flutter Engine from 2b1af6df4e7c to 590ff28649eb (1 revision) (#131561) · 068efb3a

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/2b1af6df4e7c...590ff28649eb

2023-07-29 chinmaygarde@google.com [Impeller] Update documentation on RenderDoc frame capture. (flutter/engine#44124)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

068efb3a

Roll Flutter Engine from 5184062f7543 to 2b1af6df4e7c (1 revision) (#131560) · c973f3ae

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/5184062f7543...2b1af6df4e7c

2023-07-29 skia-flutter-autoroll@skia.org Roll Skia from 72348f7deb8d to c33c0619b892 (1 revision) (flutter/engine#44140)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c973f3ae

Roll Flutter Engine from 24ccd8fffbcb to 5184062f7543 (2 revisions) (#131554) · c2b40ca7

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/24ccd8fffbcb...5184062f7543

2023-07-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from vTivaP4a62tRMYue1... to VIjw2bdybUo-rgC0t... (flutter/engine#44137)
2023-07-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1KABCKdr8VToJTlt-... to -5L2wI7BjRNgnccfl... (flutter/engine#44136)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 1KABCKdr8VTo to -5L2wI7BjRNg
fuchsia/sdk/core/mac-amd64 from vTivaP4a62tR to VIjw2bdybUo-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c2b40ca7

Roll Flutter Engine from 90bc483524fe to 24ccd8fffbcb (1 revision) (#131540) · e94e185c

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/90bc483524fe...24ccd8fffbcb

2023-07-29 skia-flutter-autoroll@skia.org Roll Skia from 2c964e925435 to 72348f7deb8d (1 revision) (flutter/engine#44130)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e94e185c

Roll Flutter Engine from 27128f29a066 to 90bc483524fe (2 revisions) (#131535) · cc0cce75

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/27128f29a066...90bc483524fe

2023-07-29 skia-flutter-autoroll@skia.org Roll Dart SDK from c2dadcad3224 to 4fd35600b477 (1 revision) (flutter/engine#44129)
2023-07-29 skia-flutter-autoroll@skia.org Roll Skia from 7dca9cd5bf70 to 2c964e925435 (1 revision) (flutter/engine#44128)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc0cce75

Roll Flutter Engine from 69b5b77edaf7 to 27128f29a066 (1 revision) (#131533) · 12924d37

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/69b5b77edaf7...27128f29a066

2023-07-29 skia-flutter-autoroll@skia.org Roll Skia from 7fe2e36ea05e to 7dca9cd5bf70 (1 revision) (flutter/engine#44126)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12924d37

Roll Flutter Engine from b854fdea2715 to 69b5b77edaf7 (1 revision) (#131532) · 75c7cafa

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/b854fdea2715...69b5b77edaf7

2023-07-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 69c96c505f05 to c2dadcad3224 (1 revision) (flutter/engine#44125)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

75c7cafa

Roll Flutter Engine from 0a5b2f521539 to b854fdea2715 (1 revision) (#131530) · 7c27b63c

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/0a5b2f521539...b854fdea2715

2023-07-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from OMmwdXn8XxipooPBo... to 1KABCKdr8VToJTlt-... (flutter/engine#44123)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from OMmwdXn8Xxip to 1KABCKdr8VTo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c27b63c

Bump github/codeql-action from 2.21.0 to 2.21.2 (#131512) · 0693d14b

dependabot[bot] authored Jul 29, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.0 to 2.21.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.21.2 - 28 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.1. <a href="https://redirect.github.com/github/codeql-action/pull/1797">#1797</a></li>
<li>Avoid duplicating the analysis summary within the logs. <a href="https://redirect.github.com/github/codeql-action/pull/1811">#1811</a></li>
</ul>
<h2>2.21.1 - 26 Jul 2023</h2>
<ul>
<li>Improve the handling of fatal errors from the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1795">#1795</a></li>
<li>Add the <code>sarif-output</code> output to the analyze action that contains the path to the directory of the generated SARIF. <a href="https://redirect.github.com/github/codeql-action/pull/1799">#1799</a></li>
</ul>
<h2>2.21.0 - 19 Jul 2023</h2>
<ul>
<li>CodeQL Action now requires CodeQL CLI 2.9.4 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.20.4. <a href="https://redirect.github.com/github/codeql-action/pull/1724">#1724</a></li>
</ul>
<h2>2.20.4 - 14 Jul 2023</h2>
<ul>
<li>This is the last release of the Action that supports CodeQL CLI versions 2.8.5 to 2.9.3. These versions of the CodeQL CLI were deprecated on June 20, 2023 alongside GitHub Enterprise Server 3.5 and will not be supported by the next release of the CodeQL Action (2.21.0).
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.9.4 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.8.5 and 2.9.3, you can replace 'github/codeql-action/<em><a href="https://github.com/v2"><code>@âv2</code></a>' by 'github/codeql-action/</em><a href="https://github.com/v2"><code>@âv2</code></a>.20.4' in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>We are rolling out a feature in July 2023 that will slightly reduce the default amount of RAM used for query execution, in proportion to the runner's total memory. This will help to avoid out-of-memory failures on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1760">#1760</a></li>
<li>Update default CodeQL bundle version to 2.14.0. <a href="https://redirect.github.com/github/codeql-action/pull/1762">#1762</a></li>
</ul>
<h2>2.20.3 - 06 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.5. <a href="https://redirect.github.com/github/codeql-action/pull/1743">#1743</a></li>
</ul>
<h2>2.20.2 - 03 Jul 2023</h2>
<p>No user facing changes.</p>
<h2>2.20.1 - 21 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.4. <a href="https://redirect.github.com/github/codeql-action/pull/1721">#1721</a></li>
<li>Experimental: add a new <code>resolve-environment</code> action which attempts to infer a configuration for the build environment that is required to build a given project. Do not use this in production as it is part of an internal experiment and subject to change at any time.</li>
</ul>
<h2>2.20.0 - 13 Jun 2023</h2>
<ul>
<li>Bump the version of the Action to 2.20.0. This ensures that users who received a Dependabot upgrade to <a href="https://github.com/github/codeql-action/commit/cdcdbb579706841c47f7063dda365e292e5cad7a"><code>cdcdbb5</code></a>, which was mistakenly marked as Action version 2.13.4, continue to receive updates to the CodeQL Action. Full details in <a href="https://redirect.github.com/github/codeql-action/pull/1729">#1729</a></li>
</ul>
<h2>2.3.6 - 01 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.3. <a href="https://redirect.github.com/github/codeql-action/pull/1698">#1698</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/0ba4244466797eb048eb91a6cd43d5c03ca8bd05"><code>0ba4244</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1813">#1813</a> from github/update-v2.21.2-10c6bfee1</li>
<li><a href="https://github.com/github/codeql-action/commit/a9a416c8f416ad4eb757d9dfb734f7c7c2135b59"><code>a9a416c</code></a> Update changelog for v2.21.2</li>
<li><a href="https://github.com/github/codeql-action/commit/10c6bfee1203aaee088328bf6c8b5e1a68b10d52"><code>10c6bfe</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1811">#1811</a> from github/henrymercer/print-summary-once</li>
<li><a href="https://github.com/github/codeql-action/commit/feea86eed3312cf8448c22bc5a887f26f4023c78"><code>feea86e</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1810">#1810</a> from github/henrymercer/ci/use-platform-specific-bun...</li>
<li><a href="https://github.com/github/codeql-action/commit/2e6f8c08c115f4741890e32679542130a51f53d1"><code>2e6f8c0</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/8342844ea722dd44af414e7eed5ced0e67fe5c44"><code>8342844</code></a> Only print the analysis summary once</li>
<li><a href="https://github.com/github/codeql-action/commit/679aac1b20947026d7575616383725ec2d5928cf"><code>679aac1</code></a> Use platform specific bundles in PR checks</li>
<li><a href="https://github.com/github/codeql-action/commit/de6681ceb7967227f8760bfad7bde8540662f894"><code>de6681c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1797">#1797</a> from github/update-bundle/codeql-bundle-v2.14.1</li>
<li><a href="https://github.com/github/codeql-action/commit/f6fe5c5c7031df5b91cc10eab7f02444d9880834"><code>f6fe5c5</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.14.1</li>
<li><a href="https://github.com/github/codeql-action/commit/62762170e1531f7cbc3cfc2d654408173f80d3ca"><code>6276217</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1808">#1808</a> from github/mergeback/v2.21.1-to-main-6ca1aa8c</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/1813ca74c3faaa3a2da2070b9b8a0b3e7373a0d8...0ba4244466797eb048eb91a6cd43d5c03ca8bd05">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.21.0&new-version=2.21.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

0693d14b

Roll Flutter Engine from f5c17f0e2406 to 0a5b2f521539 (2 revisions) (#131529) · ee9ee5b6

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/f5c17f0e2406...0a5b2f521539

2023-07-28 skia-flutter-autoroll@skia.org Roll Skia from 4c3594988d77 to 7fe2e36ea05e (1 revision) (flutter/engine#44120)
2023-07-28 jonahwilliams@google.com [Impeller] revert removal of wait until scheduled. (flutter/engine#44121)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ee9ee5b6

Roll Flutter Engine from b4bf592279d6 to f5c17f0e2406 (1 revision) (#131525) · 6ae6dae3

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/b4bf592279d6...f5c17f0e2406

2023-07-28 skia-flutter-autoroll@skia.org Roll Skia from 8f734fbb34a7 to 4c3594988d77 (9 revisions) (flutter/engine#44119)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6ae6dae3

28 Jul, 2023 18 commits

Roll Flutter Engine from da3721adba65 to b4bf592279d6 (2 revisions) (#131519) · d32c9ed5

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/da3721adba65...b4bf592279d6

2023-07-28 jason-simmons@users.noreply.github.com Set the required Android API level when Vulkan validation layers are automatically enabled for android_debug_unopt_arm64 builds (flutter/engine#44116)
2023-07-28 skia-flutter-autoroll@skia.org Roll Dart SDK from e9bdbe308478 to 69c96c505f05 (1 revision) (flutter/engine#44118)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d32c9ed5

Roll Flutter Engine from aa1278eb7b84 to da3721adba65 (5 revisions) (#131514) · 7f99e334

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/aa1278eb7b84...da3721adba65

2023-07-28 109111084+yaakovschectman@users.noreply.github.com Listen to window notifications to update application lifecycle (flutter/engine#43558)
2023-07-28 skia-flutter-autoroll@skia.org Roll ANGLE from 391bfa35798d to 0abd6f549ff1 (2 revisions) (flutter/engine#44114)
2023-07-28 dkwingsmt@users.noreply.github.com Remove a temporary lint ignore (flutter/engine#44091)
2023-07-28 skia-flutter-autoroll@skia.org Roll ANGLE from c319f34c4c8c to 391bfa35798d (1 revision) (flutter/engine#44112)
2023-07-28 43054281+camsim99@users.noreply.github.com [Android] Removes handling of Flutter splash screen (flutter/engine#44047)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f99e334

Reland - Fix floating SnackBar throws when FAB is on the top (#131475) · 7b6af17f

Bruno Leroux authored Jul 28, 2023

## Description

This PR is a reland of https://github.com/flutter/flutter/pull/129274 with a fix and new test related to the revert (https://github.com/flutter/flutter/pull/131303).

It updates how a floating snack bar is positionned when a `Scaffold` defines a FAB with `Scaffold.floatingActionButtonLocation` sets to one of the top locations.

**Before this PR:**
- When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` can't be displayed and an assert throws in debug mode.

**After this PR:**
- When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` will be displayed at the bottom of the screen, above a `NavigationBar` for instance (the top FAB is ignored when computing the floating snack bar position).

![image](https://github.com/flutter/flutter/assets/840911/08fcee6c-b286-4749-ad0b-ba09e653bd94)

## Motivation

This is a edge case related to a discrepancy between the Material spec and the Flutter `Scaffold` customizability:
- Material spec states that a floating `SnackBar` should be displayed above a FAB. But, in Material spec, FABs are expected to be on the bottom.
- Since https://github.com/flutter/flutter/issues/51465, Flutter `Scaffold` makes it valid to show a FAB on the top of the `Scaffold`.

## Related Issue

fixes https://github.com/flutter/flutter/issues/128150

## Tests

Adds 2 tests.

7b6af17f

Device discovery output cleanup (#131223) · 3396ec7b
Ian Hickson authored Jul 28, 2023
```
Fixes https://github.com/flutter/flutter/issues/6538
```
3396ec7b

Roll Flutter Engine from 182e1189873b to aa1278eb7b84 (2 revisions) (#131500) · 096b7c3c

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/182e1189873b...aa1278eb7b84

2023-07-28 skia-flutter-autoroll@skia.org Roll ANGLE from 99f1178a9e81 to c319f34c4c8c (1 revision) (flutter/engine#44109)
2023-07-28 skia-flutter-autoroll@skia.org Roll Skia from c98a755dff8e to 8f734fbb34a7 (3 revisions) (flutter/engine#44108)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

096b7c3c

Update `BottomSheet.enableDrag` & `BottomSheet.showDragHandle` docs for... · 48d47ade

Taha Tesser authored Jul 28, 2023

Update `BottomSheet.enableDrag`  & `BottomSheet.showDragHandle` docs for animation controller (#131484)

fixes [`AnimationController` must be provided when `BottomSheet.enableDrag` or `BottomSheet.showDragHandle` is true](https://github.com/flutter/flutter/issues/127093)

48d47ade

Deprecate `useMaterial3` parameter in `ThemeData.copyWith()` (#131455) · 3567140d
Qun Cheng authored Jul 28, 2023

3567140d

Roll Flutter Engine from 73615d66b2fe to 182e1189873b (2 revisions) (#131492) · 9cdde86f

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/73615d66b2fe...182e1189873b

2023-07-28 dnfield@google.com [Impeller] Avoid culling when the current matrix has perspective. (flutter/engine#44089)
2023-07-28 jacksongardner@google.com Roll Chrome to 115 (flutter/engine#44076)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9cdde86f

Add `CheckedPopupMenuItem‎.labelTextStyle` and update default text style for Material 3 (#131060) · 038ec62b

Taha Tesser authored Jul 28, 2023

fixes [Update `CheckedPopupMenuItemâ` for Material 3](https://github.com/flutter/flutter/issues/128576)

### Description

- This adds the missing ``CheckedPopupMenuItemâ.labelTextStyle` parameter
- Fixes default text style for `CheckedPopupMenuItemâ`. 
It used `ListTile`'s  `bodyLarge` instead of `LabelLarge` similar to `PopupMenuItem`.

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        useMaterial3: true,
        textTheme: const TextTheme(
          labelLarge: TextStyle(
            fontWeight: FontWeight.bold,
            fontStyle: FontStyle.italic,
            letterSpacing: 5.0,
          ),
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
        actions: <Widget>[
          PopupMenuButton<String>(
            icon: const Icon(Icons.more_vert),
            itemBuilder: (BuildContext context) => <PopupMenuEntry<String>>[
              const CheckedPopupMenuItem<String>(
                // labelTextStyle: MaterialStateProperty.resolveWith(
                //     (Set<MaterialState> states) {
                //   if (states.contains(MaterialState.selected)) {
                //     return const TextStyle(
                //       color: Colors.red,
                //       fontStyle: FontStyle.italic,
                //       fontWeight: FontWeight.bold,
                //     );
                //   }

                //   return const TextStyle(
                //     color: Colors.amber,
                //     fontStyle: FontStyle.italic,
                //     fontWeight: FontWeight.bold,
                //   );
                // }),
                child: Text('Mild'),
              ),
              const CheckedPopupMenuItem<String>(
                checked: true,
                // labelTextStyle: MaterialStateProperty.resolveWith(
                //     (Set<MaterialState> states) {
                //   if (states.contains(MaterialState.selected)) {
                //     return const TextStyle(
                //       color: Colors.red,
                //       fontStyle: FontStyle.italic,
                //       fontWeight: FontWeight.bold,
                //     );
                //   }

                //   return const TextStyle(
                //     color: Colors.amber,
                //     fontStyle: FontStyle.italic,
                //     fontWeight: FontWeight.bold,
                //   );
                // }),
                child: Text('Spicy'),
              ),
              const PopupMenuDivider(),
              const PopupMenuItem<String>(
                value: 'Close',
                child: Text('Close'),
              ),
            ],
          )
        ],
      ),
    );
  }
}

``` 
	
</details>

### Customized `textTheme.labelLarge` text theme.
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/2672438d-b2da-479b-a5d3-d239ef646365" /> | <img src="https://github.com/flutter/flutter/assets/48603081/b9f83719-dede-4c2f-8247-18f74e63eb29"  /> |

### New `CheckedPopupMenuItemâ.labelTextStyle` parameter with material states support
<img src="https://github.com/flutter/flutter/assets/48603081/ef0a88aa-9811-42b1-a3aa-53b90c8d43fb" height="450" />

038ec62b

Remove obsolete `complex_layout_ios__compile.dart` test (#131487) · 79033ed8
Chris Yang authored Jul 28, 2023
```
The test is obsolete.
```
79033ed8

Roll Flutter Engine from e97014c71014 to 73615d66b2fe (3 revisions) (#131485) · d822f662

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/e97014c71014...73615d66b2fe

2023-07-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b85515a995b to e9bdbe308478 (1 revision) (flutter/engine#44104)
2023-07-28 skia-flutter-autoroll@skia.org Roll Skia from f538575451a8 to c98a755dff8e (1 revision) (flutter/engine#44103)
2023-07-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from e_QdQPRjE5lCfa2Hy... to vTivaP4a62tRMYue1... (flutter/engine#44102)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from e_QdQPRjE5lC to vTivaP4a62tR

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d822f662

Shared state to support multi screen inspection (#129452) · f0163c0c

Daniel Chevalier authored Jul 28, 2023

![](https://media.giphy.com/media/KY2dtJNlGPH08w41FN/giphy.gif)

Fixes https://github.com/flutter/devtools/issues/5931

With Multi View applications on the way, we need to be able to manage
the state of multiple Inspector widgets in a consistent way.

Previously each Widget inspector would manage the state of it's own
inspection. This made for a confusing and inconsistent experience when
clicking on the widget inspector of different views.

This PR changes the state management to the WidgetInspectorService
static instance so that all widget inspectors can share that state.

# Demo


https://github.com/flutter/flutter/assets/1386322/70fd18dc-5827-4dcd-8cb7-ef20e6221291

f0163c0c

Roll Packages from f4ae9336ebb7 to 10aab445d985 (4 revisions) (#131483) · 6b6f5f06

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/packages/compare/f4ae9336ebb7...10aab445d985

2023-07-28 tarrinneal@gmail.com remove unneeded imports (flutter/packages#4579)
2023-07-27 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for image capture, image analysis, and preview (flutter/packages#4523)
2023-07-27 50643541+Mairramer@users.noreply.github.com [camera_android] Provides a default exposure point if null. (flutter/packages#3851)
2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter from 61fd11db to dd9764ec (5 revisions) (flutter/packages#4577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b6f5f06

Move ios_app_with_extensions_test to host only (#131441) · 3c8c3004

Chris Yang authored Jul 28, 2023

`ios_app_with_extensions_test` only builds the artifact, it does not need a device to run.
This PR adds the copies of these tests to run hostonly. When the new tests pass in post submit, we should remove the old ones.

3c8c3004

Update `Card.color` documentation for Material 3 (#131468) · 058f1660

Taha Tesser authored Jul 28, 2023

fixes [Card color parameter not respected while using Material 3](https://github.com/flutter/flutter/issues/122177)

058f1660

Update Chrome to 115, and remove `bringup: true` from skwasm benchmarks. (#131430) · e81907e0
Jackson Gardner authored Jul 28, 2023
```
Recent changes to binaryen cause us to need to update to Chrome 115 for our wasm benchmarks.
```
e81907e0

Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor`... · 7d89617a

Taha Tesser authored Jul 28, 2023

Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (#131253)

fixes [`TimePicker` color and visual issues](https://github.com/flutter/flutter/issues/127035)

## Description

- fixes default text style for `TimePicker`s  `hourMinuteTextStyle` and added a todo for https://github.com/flutter/flutter/issues/131247
- fixes correct default color not being accessed for  `dayPeriodTextColor`
-  Updates tests

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            showTimePicker(
              context: context,
              orientation: Orientation.portrait,
              initialEntryMode: TimePickerEntryMode.input,
              initialTime: TimeOfDay.now(),
              builder: (BuildContext context, Widget? child) {
                return MediaQuery(
                  data: MediaQuery.of(context)
                      .copyWith(alwaysUse24HourFormat: true),
                  child: child!,
                );
              },
            );
          },
          child: const Text('Open Time Picker'),
        ),
      ),
    );
  }
}

``` 
	
</details>

### Before

![ezgif com-video-to-gif](https://github.com/flutter/flutter/assets/48603081/b791501f-aed3-44f3-8f75-70a1e28038c6)

### After

![ezgif com-video-to-gif (1)](https://github.com/flutter/flutter/assets/48603081/1bb32064-a9b1-416d-8290-7d22b0d4fdb9)

7d89617a

Roll Flutter Engine from cfa5427dc452 to e97014c71014 (3 revisions) (#131477) · e4ce8e05

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/cfa5427dc452...e97014c71014

2023-07-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wgkZmRBHTT7DehhUL... to OMmwdXn8XxipooPBo... (flutter/engine#44101)
2023-07-28 skia-flutter-autoroll@skia.org Roll Skia from 8739fd6d422c to f538575451a8 (1 revision) (flutter/engine#44100)
2023-07-28 skia-flutter-autoroll@skia.org Roll ANGLE from 613eefa3a70f to 99f1178a9e81 (1 revision) (flutter/engine#44098)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from wgkZmRBHTT7D to OMmwdXn8Xxip

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e4ce8e05