- 11 Dec, 2023 19 commits
-
-
Christopher Fujino authored
Help debug https://github.com/flutter/flutter/issues/139597
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5c1f13e1e535...d001419b436e 2023-12-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" (flutter/engine#48895) 2023-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 611fca7f0c20 to 53dfedb82222 (1 revision) (flutter/engine#48891) 2023-12-11 skia-flutter-autoroll@skia.org Roll Skia from e55567fceb5f to 17bd70326a49 (22 revisions) (flutter/engine#48890) 2023-12-11 43054281+camsim99@users.noreply.github.com [Android] Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34 (flutter/engine#48811) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Tim Maffett authored
The doc comment for `useInheritedMediaQuery` has a typo of 'not' instead of 'now' and it is confusing at the `@Deprecated()` message clearly states it is *now* ignored. (and indeed checking the code you can verify that it *is* indeed ignored) existing code before PR: ```dart /// {@template flutter.widgets.widgetsApp.useInheritedMediaQuery} /// Deprecated. This setting is not ignored. /// ^^^ /// The widget never introduces its own [MediaQuery]; the [View] widget takes /// care of that. /// {@endtemplate} @Deprecated( 'This setting is now ignored. ' 'WidgetsApp never introduces its own MediaQuery; the View widget takes care of that. ' 'This feature was deprecated after v3.7.0-29.0.pre.' ) final bool useInheritedMediaQuery; ``` - [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. -
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4c309195b79d...5c1f13e1e535 2023-12-11 matanlurey@users.noreply.github.com Move `third_party/stb` to `flutter/third_party`. (flutter/engine#48845) 2023-12-11 chillers@google.com [ci.yaml] Add DEPS to emulator tests runIf (flutter/engine#48885) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Nate authored
Thanks so much for approving the previous PR (#139048) a couple weeks ago! This one is the same, except it's covering files in `examples/` and `packages/flutter/lib/src/animation/`. (solving issue #136139)
-
Tirth authored
Tests for `app_bar.0`, `app_bar.1`, `app_bar.2`, `app_bar.3`, `sliver_app_bar.1` and `sliver_app_bar.4` were already present. But directory name was `appbar` rather than `app_bar`. I've renamed the directory to `app_bar` since example files uses that only. Part of #130459
-
Greg Spencer authored
## Description This starts the deprecation of the `RawKeyEvent`/`RawKeyboard` event system that has been replaced by the `KeyEvent`/`HardwareKeyboard` event system. Migration guide is available here: https://docs.flutter.dev/release/breaking-changes/key-event-migration ## Related Issues - https://github.com/flutter/flutter/issues/136419 ## Related PRs - https://github.com/flutter/website/pull/9889
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5587d26aa2d4...4c309195b79d 2023-12-11 mdebbar@google.com [web] PointerBinding per view (flutter/engine#48248) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Renzo Olivares authored
This change fixes issues with screen order comparison logic when rects are encompassed within each other. This was causing issues when trying to select text that includes inline `WidgetSpan`s inside of a `SelectionArea`. * Adds `boundingBoxes` to `Selectable` for a more precise hit testing region. Fixes #132821 Fixes updating selection edge by word boundary when widget spans are involved. Fixes crash when sending select word selection event to an unselectable element.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9b85b76db0de...5587d26aa2d4 2023-12-11 zanderso@users.noreply.github.com Fix _availability_version_check for iOS 11 and 12 (flutter/engine#48624) 2023-12-11 jonahwilliams@google.com [Impeller] remove trace events that have outlived their usefulness. (flutter/engine#48856) 2023-12-11 15619084+vashworth@users.noreply.github.com Fix css changes with macOS 13 and Safari (flutter/engine#48807) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7eb6b7cab60c...9b85b76db0de 2023-12-11 30870216+gaaclarke@users.noreply.github.com [Impeller] made the blur entity test able to use the new blur (flutter/engine#48881) 2023-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from cc0067095755 to 611fca7f0c20 (1 revision) (flutter/engine#48880) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LongCatIsLooong authored
Extacted from #130101, dropped the `@_debugAssert` stuff from that PR so it's easier to review.
-
flutter-pub-roller-bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
hangyu authored
Fix #137033 This happens when go_router updates the navigator pages during a user gesture. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by:
chunhtai <47866232+chunhtai@users.noreply.github.com>
-
Bartek Pacia authored
This PR adds `String? identifier` to `Semantics` and `SemanticsProperties`. The `identifier` will be exposed on Android as `resource-id` and on iOS as `accessibilityIdentifier`. Mainly targeted at #17988 Initial Engine PR with Android support: https://github.com/flutter/engine/pull/47961 iOS Engine PR: https://github.com/flutter/engine/pull/48858 ### Migration This change breaks the SemanticsUpdateBuilder API which is on the Framework<-->Engine border. For more details see [engine PR](https://github.com/flutter/engine/pull/47961). Steps: part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961 **part 2: [flutter] use `SemanticsUpdateBuilderNew`** <-- we are here part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew`* part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again. part 5: [engine] remove `SemanticsBuilderNew`
-
hgraceb authored
The previous test for #128137 does not effectively regress and verify #123313 because the issue is specific to desktop platforms.
-
Mateus Felipe C. C. Pinto authored
Adds an `enabled` property to `ExpansionTile` that allows the user to disable the internal `ListTile`, so that we can prevent user interaction. Fixes #135770.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/6cd0657c4500...cb6dbcdd2305 2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529) 2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623) 2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612) 2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629) 2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614) 2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619) 2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625) 2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580) 2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered by a user action (flutter/packages#5143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bc0222b64c96...7eb6b7cab60c 2023-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 79cdacec8bb3 to cc0067095755 (1 revision) (flutter/engine#48874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 10 Dec, 2023 1 commit
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fb80aafd259b...bc0222b64c96 2023-12-10 skia-flutter-autoroll@skia.org Roll Dart SDK from ad72e1a31a83 to 79cdacec8bb3 (1 revision) (flutter/engine#48872) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 09 Dec, 2023 6 commits
-
-
flutter-pub-roller-bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b75960a5820a...fb80aafd259b 2023-12-09 skia-flutter-autoroll@skia.org Roll Dart SDK from e349db99706d to ad72e1a31a83 (1 revision) (flutter/engine#48867) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e80c090d09c6...b75960a5820a 2023-12-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 9acc6e29b779 to e349db99706d (2 revisions) (flutter/engine#48864) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/101396fd3b82...e80c090d09c6 2023-12-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Clamp new blur sigma (flutter/engine#48813) 2023-12-09 matanlurey@users.noreply.github.com Move `//third_party/tinygltf` to `//flutter/third_party/tinygltf` (flutter/engine#48852) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/503584615fd7...101396fd3b82 2023-12-08 matanlurey@users.noreply.github.com Roll `buildroot`, deleting `colorama`. (flutter/engine#48854) 2023-12-08 skia-flutter-autoroll@skia.org Roll Dart SDK from feb35ba49cd7 to 9acc6e29b779 (1 revision) (flutter/engine#48853) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e9cb19fa637a...503584615fd7 2023-12-08 flar@google.com [Impeller] Directly tessellate filled ellipses (flutter/engine#48770) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 08 Dec, 2023 14 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7dc51b85a634...e9cb19fa637a 2023-12-08 jonahwilliams@google.com [Impeller] dont allocate capture strings in release mode. (flutter/engine#48760) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Xilai Zhang authored
context: https://github.com/flutter/flutter/pull/139524#discussion_r1416052456 Adds a pull request template for automated flutter cherry picks. This template is adapted from [web form cherry pick issue template](https://cs.opensource.google/flutter/flutter/+/master:.github/ISSUE_TEMPLATE/7_cherry_pick.yml) since PR template doesn't support web form. This would provide the template to allow https://github.com/flutter/flutter/pull/139524 to land
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/03c5f016e919...7dc51b85a634 2023-12-08 john@johnmccutchan.com Add a new external texture type to Android embedder (flutter/engine#48803) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Towards https://github.com/flutter/flutter/issues/137875. The convenient `Overlay.wrap` function makes it easy to wrap a child with an Overlay so other visual elements can float on top of the child. This is useful if you want to get things like text selection working (i.e. with a SelectionArea) without using a Navigator.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/72da960e2ef2...03c5f016e919 2023-12-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 422e0bcdcf96 to feb35ba49cd7 (2 revisions) (flutter/engine#48839) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5dd2619c282b...72da960e2ef2 2023-12-08 zanderso@users.noreply.github.com Run full clang_tidy in presubmit (flutter/engine#48831) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/035a0cadb952...5dd2619c282b 2023-12-08 skia-flutter-autoroll@skia.org Roll Skia from 13c286972ea3 to e55567fceb5f (4 revisions) (flutter/engine#48834) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
flutter-pub-roller-bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e9e0ff02eb6e...035a0cadb952 2023-12-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 2c928cc12f94 to 422e0bcdcf96 (1 revision) (flutter/engine#48822) 2023-12-08 skia-flutter-autoroll@skia.org Roll Skia from 9e89d96899f4 to 13c286972ea3 (1 revision) (flutter/engine#48821) 2023-12-08 jacksongardner@google.com Add the `flutter_js` target as a dep to `web_sdk`. (flutter/engine#48814) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Victoria Ashworth authored
For CoreDevices we use a combination of mDNS and device logs to find the Dart VM url. If mDNS fails first, it will cause the launch to fail even though the device logs may be able to find the url. So if one of the methods fails, wait for the other method before failing the launch. Fixes https://github.com/flutter/flutter/issues/139685.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6a687bef2c18...e9e0ff02eb6e 2023-12-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Clang from 00396e6a1a0b to 725656bdd885" (flutter/engine#48832) 2023-12-08 skia-flutter-autoroll@skia.org Roll Dart SDK from be8a95b6717d to 2c928cc12f94 (6 revisions) (flutter/engine#48818) 2023-12-08 skia-flutter-autoroll@skia.org Roll Clang from 00396e6a1a0b to 725656bdd885 (flutter/engine#48817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/15584a394d36...6cd0657c4500 2023-12-08 ditman@gmail.com [gis_web] Correct pub.dev changelog entry. (flutter/packages#5613) 2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add the ability to run web_benchmarks with Wasm (flutter/packages#5611) 2023-12-08 stuartmorgan@google.com [google_sign_in] Endorse macOS implementation (flutter/packages#5600) 2023-12-07 clairepdavis@gmail.com [go_router_builder] add support to `go_router_builder` for initializing a `ShellRoute` with `observers` (flutter/packages#5563) 2023-12-07 41113988+MarinMikael@users.noreply.github.com [go_router] Fix(docs): Typo in Update navigation.md (flutter/packages#5545) 2023-12-07 katelovett@google.com [two_dimensional_scrollables] Expose addAutomaticKeepAlives in Table delegates (flutter/packages#5597) 2023-12-07 cepadilla@google.com [pigeon] Fix pigeon issue_tracker link (flutter/packages#5505) 2023-12-07 louisehsu@google.com Pointer interceptor implementations (flutter/packages#5594) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bruno Leroux authored
## Description This PR adds the 'Share' button to the text selection toolbar on Android. ## Related Issue Fixes https://github.com/flutter/flutter/issues/138728 ## Tests Refactor a lot of existing tests in order to: - make them more readable (avoid duplication by introducing helper functions, specify explictly check which buttons are expected). - make them more accurate (check that expected buttons are visible instead of just checking the number of buttons). For instance, previous tests contained sections such as: ```dart // Collapsed toolbar shows 3 buttons. expect( find.byType(CupertinoButton), isContextMenuProvidedByPlatform ? findsNothing : isTargetPlatformIOS ? findsNWidgets(6) : findsNWidgets(3) ); ``` Where the comment is obsolete, the two cases (6 widgets and 3 widgets) are not explicit (which buttons are expected?), and not accurate (will pass if the number of buttons is right but the buttons are the wrong ones).
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/105120 I also exposed the relevant dart:ui types which had the effect of removing a large number of dart:ui imports from examples.
-
