- 01 Nov, 2017 1 commit
-
-
Ian Hickson authored
Various improvements (in particular a new painting fuzzer) to the text manual test. Some additional documentation. A fix to Stack to remove an LTR bias: make unpositioned children apply "alignment". Some more debugging information on RichText and Text. A fix to the flutter tool to not crash when an RPC call throws an exception.
-
- 05 Oct, 2017 1 commit
-
-
Adam Barth authored
Fixes #11930
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 03 Aug, 2017 1 commit
-
-
Jacob Richman authored
Add Diagnosticable base class and documentation
-
- 25 Jul, 2017 1 commit
-
-
Jacob Richman authored
Refactor RenderObject.toStringDeep and Widget.toStringDeep code to use DiagnosticsNode.
-
- 02 Jun, 2017 1 commit
-
-
Ian Hickson authored
This prevents some of our mixins from being subclassed. Also, move mixins to using 'extends' instead of 'implements' for future compatibility with Dart changes. Also, rename a class that had Mixin in the name but was not a mixin.
-
- 12 Apr, 2017 1 commit
-
-
Ian Hickson authored
* Manually fix every use of Point.x and Point.y Some of these were moved to dx/dy, but not all. * Manually convert uses of the old gradient API * Remove old reference to Point. * Mechanical changes I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g' git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g' git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g' git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g' git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g' git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g' git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g' git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g' git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g' git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g' git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g' git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g' git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g' git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g' git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g' git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g' * Mechanical changes - dartdocs I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g' git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g' * Further improvements and a test * Fix minor errors from rebasing... * Roll engine
-
- 08 Apr, 2017 1 commit
-
-
Ian Hickson authored
Nobody knew what a Block was.
-
- 19 Mar, 2017 1 commit
-
-
Adam Barth authored
Fixes #4301
-
- 10 Mar, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
Covers lib/ in package:flutter.
-
- 28 Jun, 2016 1 commit
-
-
Adam Barth authored
-
- 16 Jun, 2016 2 commits
-
-
pq authored
Prep to get us ready to pull in a new dev SDK and bump our analyzer DEP. * updates `crypto` (required by fresh analyzer) * fixes newly flagged dead code warnings * fixes switches that fall through and don't return
-
pq authored
Prep to get us ready to pull in a new dev SDK and bump our analyzer DEP. * updates `crypto` (required by fresh analyzer) * fixes newly flagged dead code warnings * fixes switches that fall through and don't return
-
- 08 Jun, 2016 1 commit
-
-
Ian Hickson authored
Also, make sure that the parent is notified when they change. Fixes #2298
-
- 01 Jun, 2016 1 commit
-
-
Ian Hickson authored
* Fix fallout from intrinsics changes * Move away from isInfinite in favor of isFinite
-
- 31 May, 2016 1 commit
-
-
Ian Hickson authored
-
- 27 May, 2016 1 commit
-
-
Adam Barth authored
There are still many more left before rendering.dart is complete.
-
- 12 May, 2016 1 commit
-
-
pq authored
It's safe to remove the unneeded `void`s from setters since the blocking issues in the `always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/). We can also safely flip the bit on `avoid_return_types_on_setters`.
-
- 15 Apr, 2016 1 commit
-
-
Ian Hickson authored
+ Add new demo to gallery to show data tables. (This currently doesn't use a Card; I'll create a Card version in a subsequent patch.) + Fix checkbox alignment. It now centers in its box regardless. + Add Colors.black54. + Some minor fixes to dartdocs. + DataTable, DataColumn, DataRow, DataCell + RowInkWell + Augment dartdocs of materia/debug.dart. + DropDownButtonHideUnderline to hide the underline in a drop-down when used in a DataTable. + Add new capabilities to InkResponse to support RowInkWell. + Augment dartdocs of materia/material.dart. + Add an assert to catch nested Blocks. + Fix a crash in RenderBox when you remove an object and an ancestor used its baseline. (https://github.com/flutter/flutter/issues/2874) + Fix (and redocument) RenderBaseline/Baseline. + Add flex support to IntrinsicColumnWidth. + Document more stuff on the RenderTable side. + Fix a bug with parentData handling on RenderTable children. + Completely rewrite the column width computations. The old logic made no sense at all. + Add dartdocs to widgets/debug.dart. + Add a toString for TableRow.
-
- 13 Apr, 2016 1 commit
-
-
Ian Hickson authored
* Fix Block intrinsic functions * Update block_test.dart Fix the test per travis
-
- 11 Apr, 2016 1 commit
-
-
Ian Hickson authored
I ran into a case where I was setting minHeight=∞ and then calling layout() with that constraint, which is all kinds of bad. To try to catch this earlier, this patch now provides a way to catch constraints that are requiring infinite values. We don't _always_ check this because there are valid uses for BoxConstraints.biggest, e.g. as an additionalConstraint.
-
- 09 Apr, 2016 1 commit
-
-
Hans Muller authored
* Remove ScrollableListPainter
-
- 07 Apr, 2016 1 commit
-
-
Adam Barth authored
Previously this was used by MixedViewport, but now we don't need it because LazyBlockViewport has replaced MixedViewport. I've also taken this opportunity to modernize RenderBlock.
-
- 05 Apr, 2016 1 commit
-
-
Adam Barth authored
LazyBlock is intended as a replacement for MixedViewport. Rather than maintaining a table of all the observed child sizes (like MixedViewport), LazyBlock works by dead reckoning the location of the children based on the existing viewport. This approach makes it easier to resize children because LazyBlock doesn't cache any additional information that would need to be invalidated. This patch contains a first draft of LazyBlock that works in a simple usage scenario. Subsequent patches will replace ScrollableMixedWidgetList with LazyBlock and port the existing ScrollableMixedWidgetList tests over to LazyBlock. Related to #3075
-
- 24 Mar, 2016 1 commit
-
-
Kris Giesing authored
Fixes #2723
-
- 14 Mar, 2016 1 commit
-
-
Hixie authored
-
- 12 Mar, 2016 2 commits
-
-
Adam Barth authored
Fixes #774
-
Adam Barth authored
Fixes #581
-
- 08 Mar, 2016 1 commit
-
-
Adam Barth authored
This patch tweaks the definition of max intrinsic size to give implementations more wiggle room to compute there intrinsic sizes more efficiently. Specifically, implementations can now ignore the incomming constraint in the cross axis if they prefer. This patch removes an assert that is no longer valid w.r.t. the new definition of intrinsic sizing. Fixes #2099
-
- 27 Feb, 2016 1 commit
-
-
Hixie authored
-
- 14 Feb, 2016 1 commit
-
-
Ian Hickson authored
...so that it's easier to copy/paste between the rendering and settings layers.
-
- 10 Feb, 2016 1 commit
-
-
Hixie authored
The asserting will continue until morale improves! * Convert all assert(*.isNormalized) checks to use the new debugAssertIsNormalized technology. * Convert CustomMultiChildLayout to use the new RenderingError technology to greatly improve the detail in errors you get when writing CustomMultiChildLayout delegates. * Add BoxConstraints.copyWith(). * Indent the descendants in the rendering exception data dump so that when you have multiple children it's clearer what's going on.
-
- 06 Feb, 2016 1 commit
-
-
Adam Barth authored
This patch includes documentation for transitions.dart and for scrollable.dart.
-
- 05 Feb, 2016 1 commit
-
-
Hixie authored
* Use actual exceptions rather than assertions containing code containing strings when trying to give messages to authors. * Introduce RenderingError which is an AssertionError that takes a string argument, to support the above. * Provide a BoxDimensions.hasBoundedWidth/hasBoundedHeight API. * Document BoxDimensions.isNormalized. * Provide more useful information when we assert isNormalized and find that it is false. * When finding the size is infinite, crawl the tree to figure out which render box is likely responsible for the infinite constraints. * Provide more information when size doesn't match the constraints. * Provide more information when intrinsic dimension methods violate the constraints. * Only spam a huge amount of information for the first exception from the rendering library. I've noticed a lot of people looking at the last exception printed rather than the first and that's very misleading -- after the rendering library hits an exception, all bets are off regarding what'll happen in the future. All kinds of asserts might fire. * Improve docs around the debug methods and flags for the above. * Make Block default to have no children. Previously, giving no children crashed with a confusing message about a null deref in an assert.
-
- 27 Jan, 2016 1 commit
-
-
Hixie authored
-
- 18 Jan, 2016 1 commit
-
-
Ian Hickson authored
RenderBlock wasn't constraining the results. RenderPadding wasn't constraining the results (which matters especially when the constraints can't fit the padding in the first place). RenderViewport wasn't constraining the results. Add a test for the block case. To catch this kind of thing in the future, add some asserts to debugDoesMeetConstraints() that all four intrinsic functions return values that are within the constraints. RenderBlockViewport doesn't support returning intrinsics, so turn off the "no intrinsic support" asserts (and return zero) when we're doing this new assert. This new assert screwed up the custom layout classes' tests, so adjust those tests to ignore the callbacks invoked from these asserts. Add to the _debugReportException() method a short summary of the descendants of this node. It's important to have this information when debugging errors like these intrinsic constraints contract violations because often nodes just pass the values through to their child so you have to go several steps down to find the actual problem. Fixes https://github.com/flutter/flutter/issues/1210
-
- 11 Jan, 2016 2 commits
-
-
Adam Barth authored
We use the ScrollDirection for more than just scrolling. Fixes #151
-
Adam Barth authored
Also, introduce alwaysNeedsCompositing to force the "needs compositing" bit to true without necessarily introducing a ContainerLayer into the layer tree. A future patch will make use of alwaysNeedsCompositing to optimize opacity layers.
-
- 07 Jan, 2016 1 commit
-
-
Adam Barth authored
We'll probably renaming ScrollDirection to Axis in a future patch. Fixes #151
-