- 26 Nov, 2019 8 commits
-
-
Greg Spencer authored
This adds the ability to scroll and page up/down in a Scrollable using the keyboard. Currently, the macOS bindings use Platform.isMacOS as a check, but we'll switch that to be defaultTargetPlatform == TargetPlatform.macOS once that exists.
-
Kate Lovett authored
-
Kate Lovett authored
-
Alexandre Ardhuin authored
-
Alexandre Ardhuin authored
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/gestures * address review comments
-
Dan Field authored
-
Greg Spencer authored
This fixes an unreported bug in the macOS key handling where for some remote access situations, the modifier mask is set to the "any modifier" mask without any side specified (e.g. modifierShift bit is specified and not modifierLeftShift bit).
-
- 25 Nov, 2019 3 commits
-
-
Kate Lovett authored
-
Kate Lovett authored
-
Jonah Williams authored
-
- 23 Nov, 2019 2 commits
-
-
Takeshi Tsukamoto authored
-
chunhtai authored
-
- 22 Nov, 2019 6 commits
-
-
Kate Lovett authored
-
Kate Lovett authored
-
Greg Spencer authored
No code changes, just comments: I spell-checked all the comments in the repo.
-
Alexandre Ardhuin authored
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic * make BuildContext.inheritFromWidgetOfExactType generic * make BuildContext.ancestorInheritedElementForWidgetOfExactType generic * make BuildContext.ancestorWidgetOfExactType generic * fix snippet * bump scoped_model on temp version * update names * Revert "bump scoped_model on temp version" This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0. * address review comments * fix ci * address review comments * repeat the deprecation notice * fix uppercase * use of recommanded deprecation syntax * address review comment
-
Todd Volkert authored
This reverts commit d285b884.
-
Todd Volkert authored
-
- 21 Nov, 2019 2 commits
-
-
Michael Goderbauer authored
-
Gary Qian authored
-
- 20 Nov, 2019 6 commits
-
-
chunhtai authored
-
Todd Volkert authored
This reverts commit 421bf647. Was causing severe breakages in Google.
-
Jonah Williams authored
This reverts commit 99324105. It was implicated in https://github.com/flutter/flutter/issues/45258
-
Anthony authored
Update the Slider and RangeSlider to the latest Material spec. This introduces an updated track, updated thumbs, updated tick marks, and a new value indicator shape. The old paddle value indicator shape is also updated so that text scaling works consistently.
-
Ian Hickson authored
-
Greg Spencer authored
Before this change, it was possible to move the focus onto a control that was no longer in the view using focus traversal. This changes that, so that when a control is focused, it makes sure that if it is the child of a scrollable, that the scrollable attempts to keep it in view. If it is already in view, then nothing scrolls. When asked to move in a direction, the focus traversal code tries to find a control to move to inside the scrollable first, and then looks for things outside of the scrollable only once the scrollable has reached its limit in that direction.
-
- 19 Nov, 2019 3 commits
-
-
chunhtai authored
* reland add lifecycle enum and fix the scheduleforcedframe
-
Greg Spencer authored
This fixes the sample code analysis to treat dartpad snippets in the same way as snippet snippets, which it wasn't until now (the snippet generator was treating them as "samples"), and some errors crept in. This PR also fixes those errors. Also, added a --verbose option to the sample analyzer.
-
Greg Spencer authored
This adds a FocusableActionDetector, a widget which combines the functionality of Actions, Shortcuts, MouseRegion and a Focus widget to create a detector that defines actions and key bindings, and will notify that the focus or hover highlights should be shown or not. This widget can be used to give a control the required detection modes for focus and hover handling on desktop and web platforms. I replaced a bunch of similar code in many of our widgets with this widget, and found that pretty much any control that wants to be focusable wants all of these features as well: focus highlights, hover highlights, and actions to activate it. Also eliminated an extra _hasFocus variable in FocusState that wasn't being used.
-
- 18 Nov, 2019 4 commits
-
-
Greg Spencer authored
GLFW key events set modifier flags based on what the modifier state was before the event, unlike every other platform. This modifies the GLFW key support to take that into account. As a small cleanup, I fixed a documentation macro reference for the modifier flags that was duplicate
-
Greg Spencer authored
This adds support for the command key for text selection/editing on macOS. I had ported the text editing code (in #42879), but forgot to add support for the command key itself. This also adds a test that tests the text editing on multiple platforms instead of just testing Android. There appears to still be a bug (filed #44135) where we're losing key events sometimes on macOS, leaving some keys "stuck" on, but this PR at least allows the right key combinations to be used.
-
chunhtai authored
-
- 16 Nov, 2019 1 commit
-
-
Ian Hickson authored
-
- 15 Nov, 2019 3 commits
-
-
Kate Lovett authored
* Init * Added error message to assert * Removing unrelated changes
-
LongCatIsLooong authored
Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)" (#44778) * Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)" This reverts commit 9aea03f4.
-
Kaushik Iska authored
This reverts commit f0794917.
-
- 14 Nov, 2019 2 commits
-
-
Ian Hickson authored