- 13 Apr, 2017 1 commit
-
-
Ian Hickson authored
I can't figure out if this is genius or a giant hack. This lets you use DefaultTextStyle.merge and IconTheme.merge without specifying a BuildContext. It automatically merges in at the appropriate place in the tree using a Builder widget.
-
- 12 Apr, 2017 3 commits
-
-
xster authored
Remove intermediate animation listener
-
Hans Muller authored
-
Ian Hickson authored
* Manually fix every use of Point.x and Point.y Some of these were moved to dx/dy, but not all. * Manually convert uses of the old gradient API * Remove old reference to Point. * Mechanical changes I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g' git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g' git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g' git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g' git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g' git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g' git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g' git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g' git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g' git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g' git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g' git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g' git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g' git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g' git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g' git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g' * Mechanical changes - dartdocs I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g' git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g' * Further improvements and a test * Fix minor errors from rebasing... * Roll engine
-
- 11 Apr, 2017 1 commit
-
-
xster authored
Rename State.config to State.widget Rename State.didUpdateConfig to State.didUpdateWidget Renamed all State subclasses' local variables named config to something else
-
- 10 Apr, 2017 2 commits
- 08 Apr, 2017 3 commits
-
-
Alexandre Ardhuin authored
* upgrade to linter-0.1.30 * add prefer_is_empty lint * add directives_ordering lint * add no_adjacent_strings_in_list lint * add no_duplicate_case_values lint * add prefer_collection_literals lint * add prefer_const_constructors lint * add prefer_contains lint * add prefer_initializing_formals lint * add unnecessary_null_aware_assignments lint * add unnecessary_null_in_if_null_operators lint
-
Ian Hickson authored
-
Ian Hickson authored
Nobody knew what a Block was.
-
- 07 Apr, 2017 1 commit
-
-
Ian Hickson authored
Aggressively apply the const lint.
-
- 06 Apr, 2017 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/pull/8643 Fixes https://github.com/flutter/flutter/issues/8804 by adding a test to verify that Material elevation changes animate. Also tweak some dartdocs, add some trailing commas, improve some toString output, make the inkwell test agnostic to the PhysicalModel logic, and move the material buttons test to the material test directory.
-
- 05 Apr, 2017 3 commits
-
-
Ian Hickson authored
Add some commentary around DefaultTabController.initialIndex. Fix typo (nuull) in TabBar. Make some asserts more detailed.
-
Ian Hickson authored
-
Hans Muller authored
-
- 04 Apr, 2017 6 commits
-
-
Jason Simmons authored
Fixes https://github.com/flutter/flutter/issues/9186
-
xster authored
* Just realized the creation order is the other way around * Works * Revert previous partial solution * Change pumpAndSettle to pump for gestures
-
Adam Barth authored
-
Adam Barth authored
TextFormField doesn't actually have many properties because it wraps a TextField. Rather than trying to document all the arguments in the constructor, we now refer to the docs for TextField, which explain the parameters in a more readable way. Fixes #7245
-
Adam Barth authored
This method seemed overly specific to the needs of one particular subclass. This patch duplicates some code but makes the API conceptually cleaner. Fixes #8267
-
Adam Barth authored
We should always use the maxWidth from the incomming constraints to size the text inside the editable because the EditableText itself always expands to fill its width. Also, make sure InputDecoration always expands horizontially (even when there's no icon) for consistency. Fixes #9149
-
- 03 Apr, 2017 3 commits
-
-
Hans Muller authored
-
xster authored
* Moved stuff around yet * Fix depedencies * Add more dartdoc comments to packages * Remove Cupertino dependency on material * Removed mountain_view package and added page transition test * Fix analyze warnings * Remove commented code * Partial solution. Still need to stop the animation on the previous page for modal * Some review notes * Move the cupertino back gesture controller’s lifecycle management back to its parent * Reviews * Add background color * Directional curves, full screen transition * Don’t perform the exit animation if the incoming page is a dialog * It works! * Test structures * Add a bunch of more tests and fix the gallery * One more comment * Review notes * final controller * Use that sweet sweet `is!` keyword * Play golf, because I’m bitter that there’s no nullable `as` or something in dart * Remove a space * Review notes * Remove the last deprecated test
-
xster authored
* Moved stuff around yet * Fix depedencies * Add more dartdoc comments to packages * Remove Cupertino dependency on material * Removed mountain_view package and added page transition test * Fix analyze warnings * Remove commented code * Some review notes * Move the cupertino back gesture controller’s lifecycle management back to its parent * Reviews * Add background color * final controller * Review notes
-
- 02 Apr, 2017 3 commits
-
-
Adam Barth authored
Also, fix an issue where hint text wasn't visible when the InputDecoration was collapsed. Fixes #8541
-
Adam Barth authored
-
Adam Barth authored
After this patch, there are three major text input widgets: * EditableText. This widget is a low-level editing control that interacts with the IME and displays a blinking cursor. * TextField. This widget is a Material Design text field, with all the bells and whistles. It is highly configurable and can be reduced down to a fairly simple control by setting its `decoration` property to null. * TextFormField. This widget is a FormField that wraps a TextField. This patch also replaces the InputValue data model for these widgets with a Listenable TextEditingController, which is much more flexible. Fixes #7031
-
- 31 Mar, 2017 3 commits
-
-
Adam Barth authored
We now have an explicit focus tree that we manage. Instead of using GlobalKeys to manage focus, we use FocusNode and FocusScopeNode objects. The FocusNode is Listenable and notifies when its focus state changes. Focus notifications trigger by tree mutations are now delayed by one frame, which is necessary to handle certain complex tree mutations. In the common case of focus changes being triggered by user input, the focus notificiation still arives in the same frame.
-
Alexandre Ardhuin authored
* add @required when there's an assert not null * address review comments
-
xster authored
* Add FadeTransition to Android page transition * Also move starting point up * Add test * Use const fractional offset
-
- 29 Mar, 2017 2 commits
-
-
Alexandre Ardhuin authored
-
xster authored
-
- 27 Mar, 2017 2 commits
-
-
Luke authored
* adds border radius to ink widgets. sets default ink border radius for material buttons with no background colors * tidying up code * add ink test stub * remove unused import
-
Viktor Lidholt authored
Fixes issue with removing and re-adding a toolbar which is connected to the same TabBarController (#9015)
-
- 26 Mar, 2017 1 commit
-
-
Adam Barth authored
Otherwise it's somewhat verbose to configure all the text themes.
-
- 24 Mar, 2017 2 commits
-
-
Collin Jackson authored
-
Hans Muller authored
-
- 23 Mar, 2017 1 commit
-
-
Luke authored
* adds highlight + splash color properties to material button * add states to raised button + flat button * fixes an issue where the custom highlight would not be properly set * Add preliminary tests for theme highlight + splash and via theme * documentation changes. tweaks per code review feedback * comment out unused variable * remove unused import * documentation updates. removed commented code
-
- 22 Mar, 2017 2 commits
-
-
Collin Jackson authored
* Improvements to CircleAvatar default color (for codelab) * use a transparent white instead of a solid one * Fix analyzer errors * fix tests
-
Hans Muller authored
-