- 01 Jun, 2016 2 commits
-
-
Ian Hickson authored
...and fix some grid and table intrinsic issues it uncovered.
-
Ian Hickson authored
* Fix fallout from intrinsics changes * Move away from isInfinite in favor of isFinite
-
- 31 May, 2016 1 commit
-
-
Ian Hickson authored
-
- 29 May, 2016 1 commit
-
-
Adam Barth authored
We used to use this mechanism to paint scrollbars, but it's awkward. The new approach to scrollbars is much cleaner. This mechanism has no other clients, so we should remove it.
-
- 27 May, 2016 1 commit
-
-
Adam Barth authored
There are still many more left before rendering.dart is complete.
-
- 12 May, 2016 1 commit
-
-
pq authored
It's safe to remove the unneeded `void`s from setters since the blocking issues in the `always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/). We can also safely flip the bit on `avoid_return_types_on_setters`.
-
- 11 Apr, 2016 1 commit
-
-
Ian Hickson authored
I ran into a case where I was setting minHeight=∞ and then calling layout() with that constraint, which is all kinds of bad. To try to catch this earlier, this patch now provides a way to catch constraints that are requiring infinite values. We don't _always_ check this because there are valid uses for BoxConstraints.biggest, e.g. as an additionalConstraint.
-
- 18 Mar, 2016 1 commit
-
-
Hixie authored
-
- 14 Mar, 2016 1 commit
-
-
Hixie authored
-
- 12 Mar, 2016 3 commits
-
-
Adam Barth authored
Fixes #1382
-
Adam Barth authored
Fixes #774
-
Adam Barth authored
Fixes #581
-
- 08 Mar, 2016 1 commit
-
-
Adam Barth authored
This patch tweaks the definition of max intrinsic size to give implementations more wiggle room to compute there intrinsic sizes more efficiently. Specifically, implementations can now ignore the incomming constraint in the cross axis if they prefer. This patch removes an assert that is no longer valid w.r.t. the new definition of intrinsic sizing. Fixes #2099
-
- 17 Feb, 2016 2 commits
-
-
Hans Muller authored
-
Hans Muller authored
-
- 10 Feb, 2016 1 commit
-
-
Hixie authored
The asserting will continue until morale improves! * Convert all assert(*.isNormalized) checks to use the new debugAssertIsNormalized technology. * Convert CustomMultiChildLayout to use the new RenderingError technology to greatly improve the detail in errors you get when writing CustomMultiChildLayout delegates. * Add BoxConstraints.copyWith(). * Indent the descendants in the rendering exception data dump so that when you have multiple children it's clearer what's going on.
-
- 09 Feb, 2016 2 commits
-
-
Adam Barth authored
These classes now share more code and have feature parity.
-
Adam Barth authored
There aren't any clients anymore. Fixes #1684
-
- 06 Feb, 2016 1 commit
-
-
Adam Barth authored
The virtual viewport machinery now handles all of these use cases. Previous clients of ScrollableWidgetList can use ScrollableLazyList instead.
-
- 05 Jan, 2016 1 commit
-
-
Adam Barth authored
ScrollableList2 uses the same pattern as ScrollableGrid, which requires the client to allocate widgets for every list item but doesn't inflate them unless they're actually needed for the view. It improves on the original ScrollableList by not requiring a rebuild of the whole visible portion of the list when scrolling. In fact, small scrolls can often be handled entirely by repainting.
-
- 04 Jan, 2016 1 commit
-
-
Adam Barth authored
We now support (vertically) scrollable grids with viewporting. If the scroll doesn't reveal any new rows, we execute the scroll with a repaint (i.e., no layout). If the scroll reveals a new row, we trigger a layout to change the set of materialized children in the viewport.
-
- 02 Jan, 2016 2 commits
-
-
Adam Barth authored
This patch make grid layout much more flexible. The behavior is factored out into a GridDelegate that's modeled after the custom layout delegates. The patch includes a MaxTileWidthGridDelegate that implements the old behavior and a FixedColumnCountGridDelegate that implements a grid layout with a fixed number of columns. Fixes #1048
-
Adam Barth authored
Previously we used Position, which makes it harder to accumulate offsets when walking the render tree.
-
- 09 Dec, 2015 1 commit
-
-
Ian Hickson authored
Add BoxConstraints.isNormalized feature. Use this feature in asserts in all the intrinsic dimension methods, in various relevant BoxConstraints methods, and in layout(). Wrap the _DebugSize logic in BoxConstraints.constrain() in an assert block to avoid a branch in release mode. Remove the logic in BoxConstraints.isSatisfiedBy() that dealt with non-normalized values. Add BoxConstraints.normalize(). Make RenderCustomOneChildLayoutBox.performLayout() only set parentUsesSize on the child if the constraints aren't tight.
-
- 19 Nov, 2015 1 commit
-
-
Adam Barth authored
This pattern breaks when using compositing because we need to lift those operations into the compositing tree. This patch removes all the ones I could find and adds an assert to help prevent more from getting introduced. Fixes #191
-
- 05 Nov, 2015 1 commit
-
-
Adam Barth authored
Now a RenderBox is considered hit if one of its children are hit or it itself decides that it's hit. In particular, empty space inside a flex won't be hit because none of the children are located there and a RenderFlex doesn't consider itself hittable. Fixes #53 Fixes #1221
-
- 12 Oct, 2015 1 commit
-
-
Hixie authored
Add type annotations in many places. Fix some identifiers to have more lint-satisfying names. Make all operator==s consistent in style. Reorder some functions for consistency. Make ParentData no longer dynamic, and fix all the code around that.
-
- 09 Oct, 2015 1 commit
-
-
Hixie authored
Now that you import a top-level file for each layer of the Flutter framework, within the framework we can use relative paths without being worried about the copy/pasta problem we used to have.
-
- 14 Sep, 2015 2 commits
-
-
Collin Jackson authored
This reverts commit 7592213df29066cd357eaa4fffe4a19ed3bae189.
-
Adam Barth authored
Almost done adding dartdoc to the rendering layer.
-
- 11 Sep, 2015 1 commit
-
-
Collin Jackson authored
-
- 02 Sep, 2015 1 commit
-
-
Adam Barth authored
Code outside of package:sky should import this code using package:sky/rendering.dart package:sky/widgets.dart Moving this code into the "src" directory is a convention that signifies that and it cleans up the generated dartdoc because the libraries in the src directory aren't included in the generated documentation. Instead, the classes are documented in the widgets.dart and rendering.dart libraries.
-
- 27 Aug, 2015 1 commit
-
-
Eric Seidel authored
@abarth
-
- 26 Aug, 2015 1 commit
-
-
Eric Seidel authored
I'll write the Widget wrapper in the next CL, including adding support for padding at the Widget layer. @Hixie
-