Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e85d3792
Commit
e85d3792
authored
Feb 28, 2017
by
Devon Carew
Committed by
GitHub
Feb 28, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix a doctor check for webstorm (#8450)
* fix a doctor check for webstorm * fix a missing reference
parent
9a9a3ffd
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
5 deletions
+11
-5
doctor.dart
packages/flutter_tools/lib/src/doctor.dart
+8
-1
ios_workflow.dart
packages/flutter_tools/lib/src/ios/ios_workflow.dart
+3
-4
No files found.
packages/flutter_tools/lib/src/doctor.dart
View file @
e85d3792
...
...
@@ -275,8 +275,13 @@ abstract class IntelliJValidator extends DoctorValidator {
int
installCount
=
0
;
if
(
_validateHasPackage
(
messages
,
'Dart'
,
'Dart'
))
if
(
isWebStorm
)
{
// Dart is bundled with WebStorm.
installCount
++;
}
else
{
if
(
_validateHasPackage
(
messages
,
'Dart'
,
'Dart'
))
installCount
++;
}
if
(
_validateHasPackage
(
messages
,
'flutter-intellij.jar'
,
'Flutter'
))
installCount
++;
...
...
@@ -295,6 +300,8 @@ abstract class IntelliJValidator extends DoctorValidator {
);
}
bool
get
isWebStorm
=>
title
==
'WebStorm'
;
bool
_validateHasPackage
(
List
<
ValidationMessage
>
messages
,
String
packageName
,
String
title
)
{
if
(!
hasPackage
(
packageName
))
{
messages
.
add
(
new
ValidationMessage
(
...
...
packages/flutter_tools/lib/src/ios/ios_workflow.dart
View file @
e85d3792
...
...
@@ -132,13 +132,12 @@ class IOSWorkflow extends DoctorValidator implements Workflow {
brewStatus
=
ValidationType
.
partial
;
if
(
hasIosDeploy
)
{
messages
.
add
(
new
ValidationMessage
.
error
(
'ios-deploy out of date
:
$iosDeployMinimumVersion
is required.
\n
'
'
U
pgrade via
\'
brew upgrade ios-deploy
\'
.'
'ios-deploy out of date
(
$iosDeployMinimumVersion
is required):
'
'
u
pgrade via
\'
brew upgrade ios-deploy
\'
.'
));
}
else
{
messages
.
add
(
new
ValidationMessage
.
error
(
'ios-deploy not installed:
$iosDeployMinimumVersion
is required.
\n
'
'Install via
\'
brew install ios-deploy
\'
.'
'ios-deploy not installed: install via
\'
brew install ios-deploy
\'
.'
));
}
}
else
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment