Commit e85d3792 authored by Devon Carew's avatar Devon Carew Committed by GitHub

fix a doctor check for webstorm (#8450)

* fix a doctor check for webstorm

* fix a missing reference
parent 9a9a3ffd
...@@ -275,8 +275,13 @@ abstract class IntelliJValidator extends DoctorValidator { ...@@ -275,8 +275,13 @@ abstract class IntelliJValidator extends DoctorValidator {
int installCount = 0; int installCount = 0;
if (_validateHasPackage(messages, 'Dart', 'Dart')) if (isWebStorm) {
// Dart is bundled with WebStorm.
installCount++; installCount++;
} else {
if (_validateHasPackage(messages, 'Dart', 'Dart'))
installCount++;
}
if (_validateHasPackage(messages, 'flutter-intellij.jar', 'Flutter')) if (_validateHasPackage(messages, 'flutter-intellij.jar', 'Flutter'))
installCount++; installCount++;
...@@ -295,6 +300,8 @@ abstract class IntelliJValidator extends DoctorValidator { ...@@ -295,6 +300,8 @@ abstract class IntelliJValidator extends DoctorValidator {
); );
} }
bool get isWebStorm => title == 'WebStorm';
bool _validateHasPackage(List<ValidationMessage> messages, String packageName, String title) { bool _validateHasPackage(List<ValidationMessage> messages, String packageName, String title) {
if (!hasPackage(packageName)) { if (!hasPackage(packageName)) {
messages.add(new ValidationMessage( messages.add(new ValidationMessage(
......
...@@ -132,13 +132,12 @@ class IOSWorkflow extends DoctorValidator implements Workflow { ...@@ -132,13 +132,12 @@ class IOSWorkflow extends DoctorValidator implements Workflow {
brewStatus = ValidationType.partial; brewStatus = ValidationType.partial;
if (hasIosDeploy) { if (hasIosDeploy) {
messages.add(new ValidationMessage.error( messages.add(new ValidationMessage.error(
'ios-deploy out of date: $iosDeployMinimumVersion is required.\n' 'ios-deploy out of date ($iosDeployMinimumVersion is required): '
'Upgrade via \'brew upgrade ios-deploy\'.' 'upgrade via \'brew upgrade ios-deploy\'.'
)); ));
} else { } else {
messages.add(new ValidationMessage.error( messages.add(new ValidationMessage.error(
'ios-deploy not installed: $iosDeployMinimumVersion is required.\n' 'ios-deploy not installed: install via \'brew install ios-deploy\'.'
'Install via \'brew install ios-deploy\'.'
)); ));
} }
} else { } else {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment