Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
cfd0743d
Unverified
Commit
cfd0743d
authored
Aug 31, 2021
by
Konstantin Scheglov
Committed by
GitHub
Aug 31, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix UNNECESSARY_TYPE_CHECK_TRUE violations. (#89186)
parent
db0c4fa9
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
4 deletions
+0
-4
test.dart
dev/bots/test.dart
+0
-3
manifest.dart
dev/devicelab/lib/framework/manifest.dart
+0
-1
No files found.
dev/bots/test.dart
View file @
cfd0743d
...
@@ -455,9 +455,6 @@ Future<void> _runBuildTests() async {
...
@@ -455,9 +455,6 @@ Future<void> _runBuildTests() async {
Future
<
void
>
_runExampleProjectBuildTests
(
Directory
exampleDirectory
,
[
File
?
mainFile
])
async
{
Future
<
void
>
_runExampleProjectBuildTests
(
Directory
exampleDirectory
,
[
File
?
mainFile
])
async
{
// Only verify caching with flutter gallery.
// Only verify caching with flutter gallery.
final
bool
verifyCaching
=
exampleDirectory
.
path
.
contains
(
'flutter_gallery'
);
final
bool
verifyCaching
=
exampleDirectory
.
path
.
contains
(
'flutter_gallery'
);
if
(
exampleDirectory
is
!
Directory
)
{
return
;
}
final
String
examplePath
=
exampleDirectory
.
path
;
final
String
examplePath
=
exampleDirectory
.
path
;
final
bool
hasNullSafety
=
File
(
path
.
join
(
examplePath
,
'null_safety'
)).
existsSync
();
final
bool
hasNullSafety
=
File
(
path
.
join
(
examplePath
,
'null_safety'
)).
existsSync
();
final
List
<
String
>
additionalArgs
=
<
String
>[
final
List
<
String
>
additionalArgs
=
<
String
>[
...
...
dev/devicelab/lib/framework/manifest.dart
View file @
cfd0743d
...
@@ -107,7 +107,6 @@ List<ManifestTask> _validateAndParseTasks(dynamic tasksYaml) {
...
@@ -107,7 +107,6 @@ List<ManifestTask> _validateAndParseTasks(dynamic tasksYaml) {
}
}
ManifestTask
_validateAndParseTask
(
String
taskName
,
dynamic
taskYaml
)
{
ManifestTask
_validateAndParseTask
(
String
taskName
,
dynamic
taskYaml
)
{
_checkType
(
taskName
is
String
,
taskName
,
'Task name'
,
'string'
);
_checkType
(
taskYaml
is
YamlMap
,
taskYaml
,
'Value of task "
$taskName
"'
,
'dictionary'
);
_checkType
(
taskYaml
is
YamlMap
,
taskYaml
,
'Value of task "
$taskName
"'
,
'dictionary'
);
_checkKeys
(
taskYaml
as
YamlMap
,
'Value of task "
$taskName
"'
,
const
<
String
>[
_checkKeys
(
taskYaml
as
YamlMap
,
'Value of task "
$taskName
"'
,
const
<
String
>[
'description'
,
'description'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment