Unverified Commit ad44b05c authored by Shi-Hao Hong's avatar Shi-Hao Hong Committed by GitHub

Revert "AlertDialog widget scrollable by default (#49848)" (#51886)

This reverts commit 28f2c96a.
parent f9c118b6
...@@ -259,7 +259,7 @@ class AlertDialog extends StatelessWidget { ...@@ -259,7 +259,7 @@ class AlertDialog extends StatelessWidget {
this.insetPadding = _defaultInsetPadding, this.insetPadding = _defaultInsetPadding,
this.clipBehavior = Clip.none, this.clipBehavior = Clip.none,
this.shape, this.shape,
this.scrollable = true, this.scrollable = false,
}) : assert(contentPadding != null), }) : assert(contentPadding != null),
assert(clipBehavior != null), assert(clipBehavior != null),
super(key: key); super(key: key);
......
...@@ -1100,6 +1100,7 @@ void main() { ...@@ -1100,6 +1100,7 @@ void main() {
color: Colors.green, color: Colors.green,
height: 1000, height: 1000,
), ),
scrollable: true,
); );
await tester.pumpWidget(_buildAppWithDialog(dialog)); await tester.pumpWidget(_buildAppWithDialog(dialog));
await tester.tap(find.text('X')); await tester.tap(find.text('X'));
...@@ -1119,6 +1120,7 @@ void main() { ...@@ -1119,6 +1120,7 @@ void main() {
color: Colors.orange, color: Colors.orange,
height: 1000, height: 1000,
), ),
scrollable: true,
); );
await tester.pumpWidget(_buildAppWithDialog(dialog)); await tester.pumpWidget(_buildAppWithDialog(dialog));
await tester.tap(find.text('X')); await tester.tap(find.text('X'));
...@@ -1144,6 +1146,7 @@ void main() { ...@@ -1144,6 +1146,7 @@ void main() {
color: Colors.orange, color: Colors.orange,
height: 400, height: 400,
), ),
scrollable: true,
); );
await tester.pumpWidget(_buildAppWithDialog(dialog)); await tester.pumpWidget(_buildAppWithDialog(dialog));
await tester.tap(find.text('X')); await tester.tap(find.text('X'));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment