Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ad44b05c
Unverified
Commit
ad44b05c
authored
Mar 03, 2020
by
Shi-Hao Hong
Committed by
GitHub
Mar 03, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "AlertDialog widget scrollable by default (#49848)" (#51886)
This reverts commit
28f2c96a
.
parent
f9c118b6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
1 deletion
+4
-1
dialog.dart
packages/flutter/lib/src/material/dialog.dart
+1
-1
dialog_test.dart
packages/flutter/test/material/dialog_test.dart
+3
-0
No files found.
packages/flutter/lib/src/material/dialog.dart
View file @
ad44b05c
...
...
@@ -259,7 +259,7 @@ class AlertDialog extends StatelessWidget {
this
.
insetPadding
=
_defaultInsetPadding
,
this
.
clipBehavior
=
Clip
.
none
,
this
.
shape
,
this
.
scrollable
=
tru
e
,
this
.
scrollable
=
fals
e
,
})
:
assert
(
contentPadding
!=
null
),
assert
(
clipBehavior
!=
null
),
super
(
key:
key
);
...
...
packages/flutter/test/material/dialog_test.dart
View file @
ad44b05c
...
...
@@ -1100,6 +1100,7 @@ void main() {
color:
Colors
.
green
,
height:
1000
,
),
scrollable:
true
,
);
await
tester
.
pumpWidget
(
_buildAppWithDialog
(
dialog
));
await
tester
.
tap
(
find
.
text
(
'X'
));
...
...
@@ -1119,6 +1120,7 @@ void main() {
color:
Colors
.
orange
,
height:
1000
,
),
scrollable:
true
,
);
await
tester
.
pumpWidget
(
_buildAppWithDialog
(
dialog
));
await
tester
.
tap
(
find
.
text
(
'X'
));
...
...
@@ -1144,6 +1146,7 @@ void main() {
color:
Colors
.
orange
,
height:
400
,
),
scrollable:
true
,
);
await
tester
.
pumpWidget
(
_buildAppWithDialog
(
dialog
));
await
tester
.
tap
(
find
.
text
(
'X'
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment