Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
aa012538
Unverified
Commit
aa012538
authored
Jul 11, 2020
by
Tong Wu
Committed by
GitHub
Jul 11, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[devicelab] This no-op change marks 3 tests to run on LUCI builders. (#61257)
parent
b267e7bd
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
1 deletion
+20
-1
manifest.dart
dev/devicelab/lib/framework/manifest.dart
+12
-0
manifest.yaml
dev/devicelab/manifest.yaml
+7
-0
manifest_test.dart
dev/devicelab/test/manifest_test.dart
+1
-1
No files found.
dev/devicelab/lib/framework/manifest.dart
View file @
aa012538
...
...
@@ -36,6 +36,7 @@ class ManifestTask {
@required
this
.
requiredAgentCapabilities
,
@required
this
.
isFlaky
,
@required
this
.
timeoutInMinutes
,
@required
this
.
onLuci
,
})
{
final
String
taskName
=
'task "
$name
"'
;
_checkIsNotBlank
(
name
,
'Task name'
,
taskName
);
...
...
@@ -64,6 +65,9 @@ class ManifestTask {
/// An optional custom timeout specified in minutes.
final
int
timeoutInMinutes
;
/// (Optional) Whether this test runs on LUCI.
final
bool
onLuci
;
/// Whether the task is supported by the current host platform
bool
isSupportedByHost
()
{
final
Set
<
String
>
supportedHosts
=
Set
<
String
>.
from
(
...
...
@@ -111,6 +115,7 @@ ManifestTask _validateAndParseTask(dynamic taskName, dynamic taskYaml) {
'required_agent_capabilities'
,
'flaky'
,
'timeout_in_minutes'
,
'on_luci'
,
]);
final
dynamic
isFlaky
=
taskYaml
[
'flaky'
];
...
...
@@ -124,6 +129,12 @@ ManifestTask _validateAndParseTask(dynamic taskName, dynamic taskYaml) {
}
final
List
<
dynamic
>
capabilities
=
_validateAndParseCapabilities
(
taskName
as
String
,
taskYaml
[
'required_agent_capabilities'
]);
final
dynamic
onLuci
=
taskYaml
[
'on_luci'
];
if
(
onLuci
!=
null
)
{
_checkType
(
onLuci
is
bool
,
onLuci
,
'on_luci'
,
'boolean'
);
}
return
ManifestTask
.
_
(
name:
taskName
as
String
,
description:
taskYaml
[
'description'
]
as
String
,
...
...
@@ -131,6 +142,7 @@ ManifestTask _validateAndParseTask(dynamic taskName, dynamic taskYaml) {
requiredAgentCapabilities:
capabilities
as
List
<
String
>,
isFlaky:
isFlaky
as
bool
??
false
,
timeoutInMinutes:
timeoutInMinutes
as
int
,
onLuci:
onLuci
as
bool
??
false
,
);
}
...
...
dev/devicelab/manifest.yaml
View file @
aa012538
...
...
@@ -30,6 +30,10 @@
# on should be hidden because they just cause confusion otherwise.
# * timeout_in_minutes: integer
# a custom task timeout, specified in minutes.
# * on_luci: boolean true or false
# whether the task runs on LUCI builders. Tests will be gradually marked on_luci during the
# devicelab to LUCI migration. And when the migration is complete, on_luci flag will be
# removed.
tasks
:
# Tests of compiling in a variety of modes
...
...
@@ -96,6 +100,7 @@ tasks:
Gallery for iOS from Mac.
stage
:
devicelab_ios
required_agent_capabilities
:
[
"
mac/ios"
]
on_luci
:
true
flutter_gallery_win__compile
:
description
:
>
...
...
@@ -224,6 +229,7 @@ tasks:
Checks that flavored builds work on Android.
stage
:
devicelab
required_agent_capabilities
:
[
"
mac/android"
]
on_luci
:
true
channels_integration_test
:
description
:
>
...
...
@@ -369,6 +375,7 @@ tasks:
Builds an APK with a --dart-define and verifies it can be used as a constant
stage
:
devicelab
required_agent_capabilities
:
[
"
linux/android"
]
on_luci
:
true
android_obfuscate_test
:
description
:
>
...
...
dev/devicelab/test/manifest_test.dart
View file @
aa012538
...
...
@@ -103,7 +103,7 @@ tasks:
testManifestError
(
'invalid task property'
,
'Unrecognized property "bar" in Value of task "foo". Allowed properties: description, stage, required_agent_capabilities, flaky, timeout_in_minutes'
,
'Unrecognized property "bar" in Value of task "foo". Allowed properties: description, stage, required_agent_capabilities, flaky, timeout_in_minutes
, on_luci
'
,
'''
tasks:
foo:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment