Unverified Commit aa012538 authored by Tong Wu's avatar Tong Wu Committed by GitHub

[devicelab] This no-op change marks 3 tests to run on LUCI builders. (#61257)

parent b267e7bd
...@@ -36,6 +36,7 @@ class ManifestTask { ...@@ -36,6 +36,7 @@ class ManifestTask {
@required this.requiredAgentCapabilities, @required this.requiredAgentCapabilities,
@required this.isFlaky, @required this.isFlaky,
@required this.timeoutInMinutes, @required this.timeoutInMinutes,
@required this.onLuci,
}) { }) {
final String taskName = 'task "$name"'; final String taskName = 'task "$name"';
_checkIsNotBlank(name, 'Task name', taskName); _checkIsNotBlank(name, 'Task name', taskName);
...@@ -64,6 +65,9 @@ class ManifestTask { ...@@ -64,6 +65,9 @@ class ManifestTask {
/// An optional custom timeout specified in minutes. /// An optional custom timeout specified in minutes.
final int timeoutInMinutes; final int timeoutInMinutes;
/// (Optional) Whether this test runs on LUCI.
final bool onLuci;
/// Whether the task is supported by the current host platform /// Whether the task is supported by the current host platform
bool isSupportedByHost() { bool isSupportedByHost() {
final Set<String> supportedHosts = Set<String>.from( final Set<String> supportedHosts = Set<String>.from(
...@@ -111,6 +115,7 @@ ManifestTask _validateAndParseTask(dynamic taskName, dynamic taskYaml) { ...@@ -111,6 +115,7 @@ ManifestTask _validateAndParseTask(dynamic taskName, dynamic taskYaml) {
'required_agent_capabilities', 'required_agent_capabilities',
'flaky', 'flaky',
'timeout_in_minutes', 'timeout_in_minutes',
'on_luci',
]); ]);
final dynamic isFlaky = taskYaml['flaky']; final dynamic isFlaky = taskYaml['flaky'];
...@@ -124,6 +129,12 @@ ManifestTask _validateAndParseTask(dynamic taskName, dynamic taskYaml) { ...@@ -124,6 +129,12 @@ ManifestTask _validateAndParseTask(dynamic taskName, dynamic taskYaml) {
} }
final List<dynamic> capabilities = _validateAndParseCapabilities(taskName as String, taskYaml['required_agent_capabilities']); final List<dynamic> capabilities = _validateAndParseCapabilities(taskName as String, taskYaml['required_agent_capabilities']);
final dynamic onLuci = taskYaml['on_luci'];
if (onLuci != null) {
_checkType(onLuci is bool, onLuci, 'on_luci', 'boolean');
}
return ManifestTask._( return ManifestTask._(
name: taskName as String, name: taskName as String,
description: taskYaml['description'] as String, description: taskYaml['description'] as String,
...@@ -131,6 +142,7 @@ ManifestTask _validateAndParseTask(dynamic taskName, dynamic taskYaml) { ...@@ -131,6 +142,7 @@ ManifestTask _validateAndParseTask(dynamic taskName, dynamic taskYaml) {
requiredAgentCapabilities: capabilities as List<String>, requiredAgentCapabilities: capabilities as List<String>,
isFlaky: isFlaky as bool ?? false, isFlaky: isFlaky as bool ?? false,
timeoutInMinutes: timeoutInMinutes as int, timeoutInMinutes: timeoutInMinutes as int,
onLuci: onLuci as bool ?? false,
); );
} }
......
...@@ -30,6 +30,10 @@ ...@@ -30,6 +30,10 @@
# on should be hidden because they just cause confusion otherwise. # on should be hidden because they just cause confusion otherwise.
# * timeout_in_minutes: integer # * timeout_in_minutes: integer
# a custom task timeout, specified in minutes. # a custom task timeout, specified in minutes.
# * on_luci: boolean true or false
# whether the task runs on LUCI builders. Tests will be gradually marked on_luci during the
# devicelab to LUCI migration. And when the migration is complete, on_luci flag will be
# removed.
tasks: tasks:
# Tests of compiling in a variety of modes # Tests of compiling in a variety of modes
...@@ -96,6 +100,7 @@ tasks: ...@@ -96,6 +100,7 @@ tasks:
Gallery for iOS from Mac. Gallery for iOS from Mac.
stage: devicelab_ios stage: devicelab_ios
required_agent_capabilities: ["mac/ios"] required_agent_capabilities: ["mac/ios"]
on_luci: true
flutter_gallery_win__compile: flutter_gallery_win__compile:
description: > description: >
...@@ -224,6 +229,7 @@ tasks: ...@@ -224,6 +229,7 @@ tasks:
Checks that flavored builds work on Android. Checks that flavored builds work on Android.
stage: devicelab stage: devicelab
required_agent_capabilities: ["mac/android"] required_agent_capabilities: ["mac/android"]
on_luci: true
channels_integration_test: channels_integration_test:
description: > description: >
...@@ -369,6 +375,7 @@ tasks: ...@@ -369,6 +375,7 @@ tasks:
Builds an APK with a --dart-define and verifies it can be used as a constant Builds an APK with a --dart-define and verifies it can be used as a constant
stage: devicelab stage: devicelab
required_agent_capabilities: ["linux/android"] required_agent_capabilities: ["linux/android"]
on_luci: true
android_obfuscate_test: android_obfuscate_test:
description: > description: >
......
...@@ -103,7 +103,7 @@ tasks: ...@@ -103,7 +103,7 @@ tasks:
testManifestError( testManifestError(
'invalid task property', 'invalid task property',
'Unrecognized property "bar" in Value of task "foo". Allowed properties: description, stage, required_agent_capabilities, flaky, timeout_in_minutes', 'Unrecognized property "bar" in Value of task "foo". Allowed properties: description, stage, required_agent_capabilities, flaky, timeout_in_minutes, on_luci',
''' '''
tasks: tasks:
foo: foo:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment