Unverified Commit 7a60b6ee authored by Christopher Fujino's avatar Christopher Fujino Committed by GitHub

[flutter_conductor] Fix conductor start branch point (#100170)

parent 6f6b5647
......@@ -397,7 +397,10 @@ class StartContext extends Context {
));
final String frameworkHead = await framework.reverseParse('HEAD');
final String branchPoint = await framework.branchPoint(candidateBranch, FrameworkRepository.defaultBranch);
final String branchPoint = await framework.branchPoint(
'${framework.upstreamRemote.name}/$candidateBranch',
'${framework.upstreamRemote.name}/${FrameworkRepository.defaultBranch}',
);
final bool atBranchPoint = branchPoint == frameworkHead;
final ReleaseType releaseType = computeReleaseType(lastVersion, atBranchPoint);
......
......@@ -277,7 +277,7 @@ void main() {
stdout: revision3,
),
const FakeCommand(
command: <String>['git', 'merge-base', candidateBranch, 'master'],
command: <String>['git', 'merge-base', 'upstream/$candidateBranch', 'upstream/master'],
stdout: branchPointRevision,
),
// check if commit is tagged, zero exit code means it is tagged
......@@ -465,7 +465,7 @@ void main() {
stdout: revision3,
),
const FakeCommand(
command: <String>['git', 'merge-base', candidateBranch, 'master'],
command: <String>['git', 'merge-base', 'upstream/$candidateBranch', 'upstream/master'],
stdout: branchPointRevision,
),
];
......@@ -639,7 +639,7 @@ void main() {
stdout: revision3,
),
const FakeCommand(
command: <String>['git', 'merge-base', candidateBranch, 'master'],
command: <String>['git', 'merge-base', 'upstream/$candidateBranch', 'upstream/master'],
stdout: branchPointRevision,
),
// check if commit is tagged, 0 exit code means it is tagged
......@@ -826,7 +826,7 @@ void main() {
stdout: revision3,
),
const FakeCommand(
command: <String>['git', 'merge-base', candidateBranch, 'master'],
command: <String>['git', 'merge-base', 'upstream/$candidateBranch', 'upstream/master'],
stdout: branchPointRevision,
),
// check if commit is tagged, 0 exit code thus it is tagged
......@@ -1014,7 +1014,7 @@ void main() {
stdout: branchPointRevision,
),
const FakeCommand(
command: <String>['git', 'merge-base', candidateBranch, 'master'],
command: <String>['git', 'merge-base', 'upstream/$candidateBranch', 'upstream/master'],
stdout: branchPointRevision,
),
// check if commit is tagged
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment