Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7a60b6ee
Unverified
Commit
7a60b6ee
authored
Mar 16, 2022
by
Christopher Fujino
Committed by
GitHub
Mar 16, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_conductor] Fix conductor start branch point (#100170)
parent
6f6b5647
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
6 deletions
+9
-6
start.dart
dev/conductor/core/lib/src/start.dart
+4
-1
start_test.dart
dev/conductor/core/test/start_test.dart
+5
-5
No files found.
dev/conductor/core/lib/src/start.dart
View file @
7a60b6ee
...
...
@@ -397,7 +397,10 @@ class StartContext extends Context {
));
final
String
frameworkHead
=
await
framework
.
reverseParse
(
'HEAD'
);
final
String
branchPoint
=
await
framework
.
branchPoint
(
candidateBranch
,
FrameworkRepository
.
defaultBranch
);
final
String
branchPoint
=
await
framework
.
branchPoint
(
'
${framework.upstreamRemote.name}
/
$candidateBranch
'
,
'
${framework.upstreamRemote.name}
/
${FrameworkRepository.defaultBranch}
'
,
);
final
bool
atBranchPoint
=
branchPoint
==
frameworkHead
;
final
ReleaseType
releaseType
=
computeReleaseType
(
lastVersion
,
atBranchPoint
);
...
...
dev/conductor/core/test/start_test.dart
View file @
7a60b6ee
...
...
@@ -277,7 +277,7 @@ void main() {
stdout:
revision3
,
),
const
FakeCommand
(
command:
<
String
>[
'git'
,
'merge-base'
,
candidateBranch
,
'
master'
],
command:
<
String
>[
'git'
,
'merge-base'
,
'upstream/
$candidateBranch
'
,
'upstream/
master'
],
stdout:
branchPointRevision
,
),
// check if commit is tagged, zero exit code means it is tagged
...
...
@@ -465,7 +465,7 @@ void main() {
stdout:
revision3
,
),
const
FakeCommand
(
command:
<
String
>[
'git'
,
'merge-base'
,
candidateBranch
,
'
master'
],
command:
<
String
>[
'git'
,
'merge-base'
,
'upstream/
$candidateBranch
'
,
'upstream/
master'
],
stdout:
branchPointRevision
,
),
];
...
...
@@ -639,7 +639,7 @@ void main() {
stdout:
revision3
,
),
const
FakeCommand
(
command:
<
String
>[
'git'
,
'merge-base'
,
candidateBranch
,
'
master'
],
command:
<
String
>[
'git'
,
'merge-base'
,
'upstream/
$candidateBranch
'
,
'upstream/
master'
],
stdout:
branchPointRevision
,
),
// check if commit is tagged, 0 exit code means it is tagged
...
...
@@ -826,7 +826,7 @@ void main() {
stdout:
revision3
,
),
const
FakeCommand
(
command:
<
String
>[
'git'
,
'merge-base'
,
candidateBranch
,
'
master'
],
command:
<
String
>[
'git'
,
'merge-base'
,
'upstream/
$candidateBranch
'
,
'upstream/
master'
],
stdout:
branchPointRevision
,
),
// check if commit is tagged, 0 exit code thus it is tagged
...
...
@@ -1014,7 +1014,7 @@ void main() {
stdout:
branchPointRevision
,
),
const
FakeCommand
(
command:
<
String
>[
'git'
,
'merge-base'
,
candidateBranch
,
'
master'
],
command:
<
String
>[
'git'
,
'merge-base'
,
'upstream/
$candidateBranch
'
,
'upstream/
master'
],
stdout:
branchPointRevision
,
),
// check if commit is tagged
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment