Unverified Commit 79f377da authored by Casey Hillers's avatar Casey Hillers Committed by GitHub

[devicelab] Only upload results on master (#87125)

parent 889ab838
......@@ -98,7 +98,10 @@ class Cocoon {
resultsJson['NewStatus'] = testStatus;
}
resultsJson['TestFlaky'] = isTestFlaky ?? false;
await _sendUpdateTaskRequest(resultsJson);
const List<String> supportedBranches = <String>['master'];
if(supportedBranches.contains(resultsJson['CommitBranch'])) {
await _sendUpdateTaskRequest(resultsJson);
}
}
/// Write the given parameters into an update task request and store the JSON in [resultsPath].
......
......@@ -178,6 +178,31 @@ void main() {
expect(() => cocoon.sendResultsPath(resultsPath: resultsPath),
throwsA(isA<ClientException>()));
});
test('does not upload results on non-supported branches', () async {
// Any network failure would cause the upoad to fail
mockClient = MockClient((Request request) async => Response('', 500));
cocoon = Cocoon(
serviceAccountTokenPath: serviceAccountTokenPath,
fs: fs,
httpClient: mockClient,
requestRetryLimit: 0,
);
const String resultsPath = 'results.json';
const String updateTaskJson = '{'
'"CommitBranch":"stable",'
'"CommitSha":"$commitSha",'
'"BuilderName":"builderAbc",'
'"NewStatus":"Succeeded",'
'"ResultData":{"i":0.0,"j":0.0,"not_a_metric":"something"},'
'"BenchmarkScoreKeys":["i","j"]}';
fs.file(resultsPath).writeAsStringSync(updateTaskJson);
// This will fail if it decided to upload results
await cocoon.sendResultsPath(resultsPath: resultsPath);
});
});
group('AuthenticatedCocoonClient', () {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment