Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
2e18cd34
Unverified
Commit
2e18cd34
authored
Mar 06, 2020
by
Christopher Fujino
Committed by
GitHub
Mar 06, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix simctl process exceptions not being caught (#51916)
parent
a42d38a2
Changes
5
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
442 additions
and
150 deletions
+442
-150
context_runner.dart
packages/flutter_tools/lib/src/context_runner.dart
+8
-2
device.dart
packages/flutter_tools/lib/src/device.dart
+1
-1
globals.dart
packages/flutter_tools/lib/src/globals.dart
+3
-0
simulators.dart
packages/flutter_tools/lib/src/ios/simulators.dart
+77
-41
simulators_test.dart
...flutter_tools/test/general.shard/ios/simulators_test.dart
+353
-106
No files found.
packages/flutter_tools/lib/src/context_runner.dart
View file @
2e18cd34
...
@@ -137,7 +137,10 @@ Future<T> runInContext<T>(
...
@@ -137,7 +137,10 @@ Future<T> runInContext<T>(
platform:
globals
.
platform
,
platform:
globals
.
platform
,
processManager:
globals
.
processManager
,
processManager:
globals
.
processManager
,
),
),
IOSSimulatorUtils:
()
=>
IOSSimulatorUtils
(),
IOSSimulatorUtils:
()
=>
IOSSimulatorUtils
(
simControl:
globals
.
simControl
,
xcode:
globals
.
xcode
,
),
IOSWorkflow:
()
=>
const
IOSWorkflow
(),
IOSWorkflow:
()
=>
const
IOSWorkflow
(),
KernelCompilerFactory:
()
=>
const
KernelCompilerFactory
(),
KernelCompilerFactory:
()
=>
const
KernelCompilerFactory
(),
Logger:
()
=>
globals
.
platform
.
isWindows
Logger:
()
=>
globals
.
platform
.
isWindows
...
@@ -174,7 +177,10 @@ Future<T> runInContext<T>(
...
@@ -174,7 +177,10 @@ Future<T> runInContext<T>(
Pub:
()
=>
const
Pub
(),
Pub:
()
=>
const
Pub
(),
ShutdownHooks:
()
=>
ShutdownHooks
(
logger:
globals
.
logger
),
ShutdownHooks:
()
=>
ShutdownHooks
(
logger:
globals
.
logger
),
Signals:
()
=>
Signals
(),
Signals:
()
=>
Signals
(),
SimControl:
()
=>
SimControl
(),
SimControl:
()
=>
SimControl
(
logger:
globals
.
logger
,
processManager:
globals
.
processManager
,
),
Stdio:
()
=>
Stdio
(),
Stdio:
()
=>
Stdio
(),
SystemClock:
()
=>
const
SystemClock
(),
SystemClock:
()
=>
const
SystemClock
(),
TimeoutConfiguration:
()
=>
const
TimeoutConfiguration
(),
TimeoutConfiguration:
()
=>
const
TimeoutConfiguration
(),
...
...
packages/flutter_tools/lib/src/device.dart
View file @
2e18cd34
...
@@ -71,7 +71,7 @@ class DeviceManager {
...
@@ -71,7 +71,7 @@ class DeviceManager {
final
List
<
DeviceDiscovery
>
_deviceDiscoverers
=
List
<
DeviceDiscovery
>.
unmodifiable
(<
DeviceDiscovery
>[
final
List
<
DeviceDiscovery
>
_deviceDiscoverers
=
List
<
DeviceDiscovery
>.
unmodifiable
(<
DeviceDiscovery
>[
AndroidDevices
(),
AndroidDevices
(),
IOSDevices
(),
IOSDevices
(),
IOSSimulators
(),
IOSSimulators
(
iosSimulatorUtils:
globals
.
iosSimulatorUtils
),
FuchsiaDevices
(),
FuchsiaDevices
(),
FlutterTesterDevices
(),
FlutterTesterDevices
(),
MacOSDevices
(),
MacOSDevices
(),
...
...
packages/flutter_tools/lib/src/globals.dart
View file @
2e18cd34
...
@@ -24,6 +24,7 @@ import 'cache.dart';
...
@@ -24,6 +24,7 @@ import 'cache.dart';
import
'ios/ios_deploy.dart'
;
import
'ios/ios_deploy.dart'
;
import
'ios/mac.dart'
;
import
'ios/mac.dart'
;
import
'ios/plist_parser.dart'
;
import
'ios/plist_parser.dart'
;
import
'ios/simulators.dart'
;
import
'macos/xcode.dart'
;
import
'macos/xcode.dart'
;
import
'persistent_tool_state.dart'
;
import
'persistent_tool_state.dart'
;
import
'reporting/reporting.dart'
;
import
'reporting/reporting.dart'
;
...
@@ -69,6 +70,8 @@ AndroidSdk get androidSdk => context.get<AndroidSdk>();
...
@@ -69,6 +70,8 @@ AndroidSdk get androidSdk => context.get<AndroidSdk>();
FlutterVersion
get
flutterVersion
=>
context
.
get
<
FlutterVersion
>();
FlutterVersion
get
flutterVersion
=>
context
.
get
<
FlutterVersion
>();
IMobileDevice
get
iMobileDevice
=>
context
.
get
<
IMobileDevice
>();
IMobileDevice
get
iMobileDevice
=>
context
.
get
<
IMobileDevice
>();
IOSDeploy
get
iosDeploy
=>
context
.
get
<
IOSDeploy
>();
IOSDeploy
get
iosDeploy
=>
context
.
get
<
IOSDeploy
>();
IOSSimulatorUtils
get
iosSimulatorUtils
=>
context
.
get
<
IOSSimulatorUtils
>();
SimControl
get
simControl
=>
context
.
get
<
SimControl
>();
UserMessages
get
userMessages
=>
context
.
get
<
UserMessages
>();
UserMessages
get
userMessages
=>
context
.
get
<
UserMessages
>();
Xcode
get
xcode
=>
context
.
get
<
Xcode
>();
Xcode
get
xcode
=>
context
.
get
<
Xcode
>();
...
...
packages/flutter_tools/lib/src/ios/simulators.dart
View file @
2e18cd34
This diff is collapsed.
Click to expand it.
packages/flutter_tools/test/general.shard/ios/simulators_test.dart
View file @
2e18cd34
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment