Unverified Commit 279f40d4 authored by Ian Hickson's avatar Ian Hickson Committed by GitHub

Clean up some old and obsolete TODOs of mine (#81631)

parent 3ce6c1f4
...@@ -221,7 +221,6 @@ class _AnimatedThemeState extends AnimatedWidgetBaseState<AnimatedTheme> { ...@@ -221,7 +221,6 @@ class _AnimatedThemeState extends AnimatedWidgetBaseState<AnimatedTheme> {
@override @override
void forEachTween(TweenVisitor<dynamic> visitor) { void forEachTween(TweenVisitor<dynamic> visitor) {
// TODO(ianh): Use constructor tear-offs when it becomes possible, https://github.com/dart-lang/sdk/issues/10659
_data = visitor(_data, widget.data, (dynamic value) => ThemeDataTween(begin: value as ThemeData))! as ThemeDataTween; _data = visitor(_data, widget.data, (dynamic value) => ThemeDataTween(begin: value as ThemeData))! as ThemeDataTween;
} }
......
...@@ -56,8 +56,7 @@ class RenderErrorBox extends RenderBox { ...@@ -56,8 +56,7 @@ class RenderErrorBox extends RenderBox {
/// The message to attempt to display at paint time. /// The message to attempt to display at paint time.
final String message; final String message;
// TODO(ianh): should be final late final ui.Paragraph? _paragraph;
ui.Paragraph? _paragraph;
@override @override
double computeMaxIntrinsicWidth(double height) { double computeMaxIntrinsicWidth(double height) {
......
...@@ -485,7 +485,6 @@ typedef AsyncWidgetBuilder<T> = Widget Function(BuildContext context, AsyncSnaps ...@@ -485,7 +485,6 @@ typedef AsyncWidgetBuilder<T> = Widget Function(BuildContext context, AsyncSnaps
/// [Stream]. /// [Stream].
/// * [StreamBuilderBase], which supports widget building based on a computation /// * [StreamBuilderBase], which supports widget building based on a computation
/// that spans all interactions made with the stream. /// that spans all interactions made with the stream.
// TODO(ianh): remove unreachable code above once https://github.com/dart-lang/linter/issues/1139 is fixed
class StreamBuilder<T> extends StreamBuilderBase<T, AsyncSnapshot<T>> { class StreamBuilder<T> extends StreamBuilderBase<T, AsyncSnapshot<T>> {
/// Creates a new [StreamBuilder] that builds itself based on the latest /// Creates a new [StreamBuilder] that builds itself based on the latest
/// snapshot of interaction with the specified [stream] and whose build /// snapshot of interaction with the specified [stream] and whose build
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment