Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
279f40d4
Unverified
Commit
279f40d4
authored
May 03, 2021
by
Ian Hickson
Committed by
GitHub
May 03, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean up some old and obsolete TODOs of mine (#81631)
parent
3ce6c1f4
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
4 deletions
+1
-4
theme.dart
packages/flutter/lib/src/material/theme.dart
+0
-1
error.dart
packages/flutter/lib/src/rendering/error.dart
+1
-2
async.dart
packages/flutter/lib/src/widgets/async.dart
+0
-1
No files found.
packages/flutter/lib/src/material/theme.dart
View file @
279f40d4
...
...
@@ -221,7 +221,6 @@ class _AnimatedThemeState extends AnimatedWidgetBaseState<AnimatedTheme> {
@override
void
forEachTween
(
TweenVisitor
<
dynamic
>
visitor
)
{
// TODO(ianh): Use constructor tear-offs when it becomes possible, https://github.com/dart-lang/sdk/issues/10659
_data
=
visitor
(
_data
,
widget
.
data
,
(
dynamic
value
)
=>
ThemeDataTween
(
begin:
value
as
ThemeData
))!
as
ThemeDataTween
;
}
...
...
packages/flutter/lib/src/rendering/error.dart
View file @
279f40d4
...
...
@@ -56,8 +56,7 @@ class RenderErrorBox extends RenderBox {
/// The message to attempt to display at paint time.
final
String
message
;
// TODO(ianh): should be final
ui
.
Paragraph
?
_paragraph
;
late
final
ui
.
Paragraph
?
_paragraph
;
@override
double
computeMaxIntrinsicWidth
(
double
height
)
{
...
...
packages/flutter/lib/src/widgets/async.dart
View file @
279f40d4
...
...
@@ -485,7 +485,6 @@ typedef AsyncWidgetBuilder<T> = Widget Function(BuildContext context, AsyncSnaps
/// [Stream].
/// * [StreamBuilderBase], which supports widget building based on a computation
/// that spans all interactions made with the stream.
// TODO(ianh): remove unreachable code above once https://github.com/dart-lang/linter/issues/1139 is fixed
class
StreamBuilder
<
T
>
extends
StreamBuilderBase
<
T
,
AsyncSnapshot
<
T
>>
{
/// Creates a new [StreamBuilder] that builds itself based on the latest
/// snapshot of interaction with the specified [stream] and whose build
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment