Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
210a905f
Unverified
Commit
210a905f
authored
Oct 14, 2021
by
Michael Goderbauer
Committed by
GitHub
Oct 14, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unused offset from Layer.addToScene/addChildrenToScene (#91753)
parent
5d587f95
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
60 additions
and
73 deletions
+60
-73
layer.dart
packages/flutter/lib/src/rendering/layer.dart
+52
-65
widget_inspector.dart
packages/flutter/lib/src/widgets/widget_inspector.dart
+6
-6
layer_annotations_test.dart
packages/flutter/test/rendering/layer_annotations_test.dart
+1
-1
layers_test.dart
packages/flutter/test/rendering/layers_test.dart
+1
-1
No files found.
packages/flutter/lib/src/rendering/layer.dart
View file @
210a905f
This diff is collapsed.
Click to expand it.
packages/flutter/lib/src/widgets/widget_inspector.dart
View file @
210a905f
...
...
@@ -54,8 +54,8 @@ class _ProxyLayer extends Layer {
final
Layer
_layer
;
@override
void
addToScene
(
ui
.
SceneBuilder
builder
,
[
Offset
layerOffset
=
Offset
.
zero
]
)
{
_layer
.
addToScene
(
builder
,
layerOffset
);
void
addToScene
(
ui
.
SceneBuilder
builder
)
{
_layer
.
addToScene
(
builder
);
}
@override
...
...
@@ -319,8 +319,8 @@ Rect _calculateSubtreeBounds(RenderObject object) {
/// screenshots render to the scene in the local coordinate system of the layer.
class
_ScreenshotContainerLayer
extends
OffsetLayer
{
@override
void
addToScene
(
ui
.
SceneBuilder
builder
,
[
Offset
layerOffset
=
Offset
.
zero
]
)
{
addChildrenToScene
(
builder
,
layerOffset
);
void
addToScene
(
ui
.
SceneBuilder
builder
)
{
addChildrenToScene
(
builder
);
}
}
...
...
@@ -2665,7 +2665,7 @@ class _InspectorOverlayLayer extends Layer {
double
?
_textPainterMaxWidth
;
@override
void
addToScene
(
ui
.
SceneBuilder
builder
,
[
Offset
layerOffset
=
Offset
.
zero
]
)
{
void
addToScene
(
ui
.
SceneBuilder
builder
)
{
if
(!
selection
.
active
)
return
;
...
...
@@ -2694,7 +2694,7 @@ class _InspectorOverlayLayer extends Layer {
_lastState
=
state
;
_picture
=
_buildPicture
(
state
);
}
builder
.
addPicture
(
layerOffset
,
_picture
);
builder
.
addPicture
(
Offset
.
zero
,
_picture
);
}
ui
.
Picture
_buildPicture
(
_InspectorOverlayRenderState
state
)
{
...
...
packages/flutter/test/rendering/layer_annotations_test.dart
View file @
210a905f
...
...
@@ -845,7 +845,7 @@ class _TestAnnotatedLayer extends Layer {
final
Size
?
size
;
@override
EngineLayer
?
addToScene
(
SceneBuilder
builder
,
[
Offset
layerOffset
=
Offset
.
zero
]
)
{
EngineLayer
?
addToScene
(
SceneBuilder
builder
)
{
return
null
;
}
...
...
packages/flutter/test/rendering/layers_test.dart
View file @
210a905f
...
...
@@ -608,7 +608,7 @@ class FakePicture extends Fake implements Picture {
class
ConcreteLayer
extends
Layer
{
@override
void
addToScene
(
SceneBuilder
builder
,
[
Offset
layerOffset
=
Offset
.
zero
]
)
{}
void
addToScene
(
SceneBuilder
builder
)
{}
}
class
_TestAlwaysNeedsAddToSceneLayer
extends
ContainerLayer
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment