build_apk_test.dart 17.4 KB
Newer Older
Ian Hickson's avatar
Ian Hickson committed
1
// Copyright 2014 The Flutter Authors. All rights reserved.
2 3 4 5 6
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:args/command_runner.dart';
import 'package:flutter_tools/src/android/android_builder.dart';
7
import 'package:flutter_tools/src/android/android_sdk.dart';
8
import 'package:flutter_tools/src/android/android_studio.dart';
9
import 'package:flutter_tools/src/android/java.dart';
10
import 'package:flutter_tools/src/base/file_system.dart';
11
import 'package:flutter_tools/src/base/logger.dart';
12
import 'package:flutter_tools/src/base/version.dart';
13 14
import 'package:flutter_tools/src/cache.dart';
import 'package:flutter_tools/src/commands/build_apk.dart';
15
import 'package:flutter_tools/src/globals.dart' as globals;
16
import 'package:flutter_tools/src/project.dart';
17
import 'package:flutter_tools/src/reporting/reporting.dart';
18
import 'package:test/fake.dart';
19

20
import '../../src/android_common.dart';
21 22
import '../../src/common.dart';
import '../../src/context.dart';
23
import '../../src/fake_process_manager.dart';
24
import '../../src/test_flutter_command_runner.dart';
25 26 27 28

void main() {
  Cache.disableLocking();

29
  group('Usage', () {
30 31
    late Directory tempDir;
    late TestUsage testUsage;
32 33

    setUp(() {
34
      testUsage = TestUsage();
35
      tempDir = globals.fs.systemTempDirectory.createTempSync('flutter_tools_packages_test.');
36 37 38 39 40 41 42 43 44
    });

    tearDown(() {
      tryToDelete(tempDir);
    });

    testUsingContext('indicate the default target platforms', () async {
      final String projectPath = await createProject(tempDir,
          arguments: <String>['--no-pub', '--template=app']);
45
      final BuildApkCommand command = await runBuildApkCommand(projectPath);
46

47
      expect((await command.usageValues).commandBuildApkTargetPlatform, 'android-arm,android-arm64,android-x64');
48 49 50

    }, overrides: <Type, Generator>{
      AndroidBuilder: () => FakeAndroidBuilder(),
51
    });
52 53 54 55 56

    testUsingContext('split per abi', () async {
      final String projectPath = await createProject(tempDir,
          arguments: <String>['--no-pub', '--template=app']);

57
      final BuildApkCommand commandWithFlag = await runBuildApkCommand(projectPath,
58
          arguments: <String>['--split-per-abi']);
59
      expect((await commandWithFlag.usageValues).commandBuildApkSplitPerAbi, true);
60

61
      final BuildApkCommand commandWithoutFlag = await runBuildApkCommand(projectPath);
62
      expect((await commandWithoutFlag.usageValues).commandBuildApkSplitPerAbi, false);
63 64 65

    }, overrides: <Type, Generator>{
      AndroidBuilder: () => FakeAndroidBuilder(),
66
    });
67 68 69 70 71

    testUsingContext('build type', () async {
      final String projectPath = await createProject(tempDir,
          arguments: <String>['--no-pub', '--template=app']);

72
      final BuildApkCommand commandDefault = await runBuildApkCommand(projectPath);
73
      expect((await commandDefault.usageValues).commandBuildApkBuildMode, 'release');
74

75
      final BuildApkCommand commandInRelease = await runBuildApkCommand(projectPath,
76
          arguments: <String>['--release']);
77
      expect((await commandInRelease.usageValues).commandBuildApkBuildMode, 'release');
78

79
      final BuildApkCommand commandInDebug = await runBuildApkCommand(projectPath,
80
          arguments: <String>['--debug']);
81
      expect((await commandInDebug.usageValues).commandBuildApkBuildMode, 'debug');
82

83
      final BuildApkCommand commandInProfile = await runBuildApkCommand(projectPath,
84
          arguments: <String>['--profile']);
85
      expect((await commandInProfile.usageValues).commandBuildApkBuildMode, 'profile');
86 87 88

    }, overrides: <Type, Generator>{
      AndroidBuilder: () => FakeAndroidBuilder(),
89
    });
90 91 92 93 94 95 96

    testUsingContext('logs success', () async {
      final String projectPath = await createProject(tempDir,
          arguments: <String>['--no-pub', '--template=app']);

      await runBuildApkCommand(projectPath);

97 98 99 100 101 102 103
      expect(testUsage.events, contains(
        const TestUsageEvent(
          'tool-command-result',
          'apk',
          label: 'success',
        ),
      ));
104 105 106
    },
    overrides: <Type, Generator>{
      AndroidBuilder: () => FakeAndroidBuilder(),
107
      Usage: () => testUsage,
108
    });
109
  });
110 111

  group('Gradle', () {
112 113 114 115 116
    late Directory tempDir;
    late FakeProcessManager processManager;
    late String gradlew;
    late AndroidSdk mockAndroidSdk;
    late TestUsage testUsage;
117 118

    setUp(() {
119
      testUsage = TestUsage();
120 121 122
      tempDir = globals.fs.systemTempDirectory.createTempSync('flutter_tools_packages_test.');
      gradlew = globals.fs.path.join(tempDir.path, 'flutter_project', 'android',
          globals.platform.isWindows ? 'gradlew.bat' : 'gradlew');
123
      processManager = FakeProcessManager.empty();
124
      mockAndroidSdk = FakeAndroidSdk(globals.fs.directory('irrelevant'));
125 126 127 128 129 130
    });

    tearDown(() {
      tryToDelete(tempDir);
    });

131
    group('AndroidSdk', () {
132
      testUsingContext('throws throwsToolExit if AndroidSdk is null', () async {
133
        final String projectPath = await createProject(tempDir, arguments: <String>['--no-pub', '--template=app', '--platform=android']);
134

135 136
        await expectLater(
          () => runBuildApkCommand(
137 138
            projectPath,
            arguments: <String>['--no-pub'],
139 140 141 142 143
          ),
          throwsToolExit(
            message: 'No Android SDK found. Try setting the ANDROID_SDK_ROOT environment variable',
          ),
        );
144 145 146
      },
      overrides: <Type, Generator>{
        AndroidSdk: () => null,
147
        Java: () => null,
148
        FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
149 150
        ProcessManager: () => processManager,
        AndroidStudio: () => FakeAndroidStudio(),
151 152 153
      });
    });

Emmanuel Garcia's avatar
Emmanuel Garcia committed
154
    testUsingContext('shrinking is enabled by default on release mode', () async {
155
      final String projectPath = await createProject(tempDir, arguments: <String>['--no-pub', '--template=app', '--platform=android']);
156 157
      processManager.addCommand(FakeCommand(
        command: <String>[
158 159
          gradlew,
          '-q',
160
          '-Ptarget-platform=android-arm,android-arm64,android-x64',
161
          '-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
162
          '-Pbase-application-name=android.app.Application',
163
          '-Pdart-obfuscation=false',
164
          '-Ptrack-widget-creation=true',
165
          '-Ptree-shake-icons=true',
166 167
          'assembleRelease',
        ],
168 169 170 171 172 173 174 175
        exitCode: 1,
      ));

      await expectLater(
        () => runBuildApkCommand(projectPath),
        throwsToolExit(message: 'Gradle task assembleRelease failed with exit code 1'),
      );
      expect(processManager, hasNoRemainingExpectations);
176 177 178
    },
    overrides: <Type, Generator>{
      AndroidSdk: () => mockAndroidSdk,
179
      Java: () => null,
180
      FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
181 182
      ProcessManager: () => processManager,
      AndroidStudio: () => FakeAndroidStudio(),
183
    });
184

185
    testUsingContext('--split-debug-info is enabled when an output directory is provided', () async {
186
      final String projectPath = await createProject(tempDir, arguments: <String>['--no-pub', '--template=app', '--platform=android']);
187 188
      processManager.addCommand(FakeCommand(
        command: <String>[
189 190
          gradlew,
          '-q',
191
          '-Ptarget-platform=android-arm,android-arm64,android-x64',
192
          '-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
193
          '-Pbase-application-name=android.app.Application',
194
          '-Pdart-obfuscation=false',
195
          '-Psplit-debug-info=${tempDir.path}',
196
          '-Ptrack-widget-creation=true',
197
          '-Ptree-shake-icons=true',
198 199
          'assembleRelease',
        ],
200 201 202 203 204 205 206 207
        exitCode: 1,
      ));

      await expectLater(
        () => runBuildApkCommand(projectPath, arguments: <String>['--split-debug-info=${tempDir.path}']),
        throwsToolExit(message: 'Gradle task assembleRelease failed with exit code 1'),
      );
      expect(processManager, hasNoRemainingExpectations);
208 209 210
    },
    overrides: <Type, Generator>{
      AndroidSdk: () => mockAndroidSdk,
211
      Java: () => null,
212
      FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
213 214
      ProcessManager: () => processManager,
      AndroidStudio: () => FakeAndroidStudio(),
215 216
    });

217
    testUsingContext('--extra-front-end-options are provided to gradle project', () async {
218
      final String projectPath = await createProject(tempDir, arguments: <String>['--no-pub', '--template=app', '--platform=android']);
219 220
      processManager.addCommand(FakeCommand(
        command: <String>[
221 222 223 224
          gradlew,
          '-q',
          '-Ptarget-platform=android-arm,android-arm64,android-x64',
          '-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
225
          '-Pbase-application-name=android.app.Application',
226
          '-Pdart-obfuscation=false',
227
          '-Pextra-front-end-options=foo,bar',
228
          '-Ptrack-widget-creation=true',
229
          '-Ptree-shake-icons=true',
230 231
          'assembleRelease',
        ],
232 233 234 235 236 237 238 239
        exitCode: 1,
      ));

      await expectLater(() => runBuildApkCommand(projectPath, arguments: <String>[
        '--extra-front-end-options=foo',
        '--extra-front-end-options=bar',
      ]), throwsToolExit(message: 'Gradle task assembleRelease failed with exit code 1'));
       expect(processManager, hasNoRemainingExpectations);
240 241 242
    },
    overrides: <Type, Generator>{
      AndroidSdk: () => mockAndroidSdk,
243
      Java: () => null,
244
      FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
245 246
      ProcessManager: () => processManager,
      AndroidStudio: () => FakeAndroidStudio(),
247 248
    });

Emmanuel Garcia's avatar
Emmanuel Garcia committed
249
    testUsingContext('shrinking is disabled when --no-shrink is passed', () async {
250
      final String projectPath = await createProject(tempDir, arguments: <String>['--no-pub', '--template=app', '--platform=android']);
251 252
      processManager.addCommand(FakeCommand(
        command: <String>[
253 254
          gradlew,
          '-q',
255
          '-Ptarget-platform=android-arm,android-arm64,android-x64',
256
          '-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
257
          '-Pbase-application-name=android.app.Application',
258
          '-Pdart-obfuscation=false',
259
          '-Ptrack-widget-creation=true',
260
          '-Ptree-shake-icons=true',
261 262
          'assembleRelease',
        ],
263 264 265 266 267 268 269 270 271 272 273
        exitCode: 1,
      ));

      await expectLater(
        () => runBuildApkCommand(
          projectPath,
          arguments: <String>['--no-shrink'],
        ),
        throwsToolExit(message: 'Gradle task assembleRelease failed with exit code 1'),
      );
      expect(processManager, hasNoRemainingExpectations);
274 275 276
    },
    overrides: <Type, Generator>{
      AndroidSdk: () => mockAndroidSdk,
277
      Java: () => null,
278
      FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
279 280
      ProcessManager: () => processManager,
      AndroidStudio: () => FakeAndroidStudio(),
281
    });
282

Emmanuel Garcia's avatar
Emmanuel Garcia committed
283
    testUsingContext('guides the user when the shrinker fails', () async {
284
      final String projectPath = await createProject(tempDir, arguments: <String>['--no-pub', '--template=app', '--platform=android']);
285 286 287 288 289
      const String r8StdoutWarning =
        "Execution failed for task ':app:transformClassesAndResourcesWithR8ForStageInternal'.\n"
        '> com.android.tools.r8.CompilationFailedException: Compilation failed to complete';
      processManager.addCommand(FakeCommand(
        command: <String>[
290 291
          gradlew,
          '-q',
292
          '-Ptarget-platform=android-arm,android-arm64,android-x64',
293
          '-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
294
          '-Pbase-application-name=android.app.Application',
295
          '-Pdart-obfuscation=false',
296
          '-Ptrack-widget-creation=true',
297
          '-Ptree-shake-icons=true',
298 299
          'assembleRelease',
        ],
300 301 302
        exitCode: 1,
        stdout: r8StdoutWarning,
      ));
303

304 305
      await expectLater(
        () => runBuildApkCommand(
306
          projectPath,
307 308
        ),
        throwsToolExit(message: 'Gradle task assembleRelease failed with exit code 1'),
309 310
      );
      expect(
311 312 313 314 315
        testLogger.statusText, allOf(
          containsIgnoringWhitespace('The shrinker may have failed to optimize the Java bytecode.'),
          containsIgnoringWhitespace('To disable the shrinker, pass the `--no-shrink` flag to this command.'),
          containsIgnoringWhitespace('To learn more, see: https://developer.android.com/studio/build/shrink-code'),
        )
316
      );
317 318 319
      expect(testUsage.events, contains(
        const TestUsageEvent(
          'build',
320
          'gradle',
321
          label: 'gradle-r8-failure',
322
          parameters: CustomDimensions(),
323 324
        ),
      ));
325
      expect(processManager, hasNoRemainingExpectations);
326 327 328
    },
    overrides: <Type, Generator>{
      AndroidSdk: () => mockAndroidSdk,
329
      Java: () => null,
330
      FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
331
      ProcessManager: () => processManager,
332
      Usage: () => testUsage,
333
      AndroidStudio: () => FakeAndroidStudio(),
334
    });
335

336
    testUsingContext("reports when the app isn't using AndroidX", () async {
337
      final String projectPath = await createProject(tempDir, arguments: <String>['--no-pub', '--template=app', '--platform=android']);
338 339 340 341 342 343
      // Simulate a non-androidx project.
      tempDir
        .childDirectory('flutter_project')
        .childDirectory('android')
        .childFile('gradle.properties')
        .writeAsStringSync('android.useAndroidX=false');
344 345
      processManager.addCommand(FakeCommand(
        command: <String>[
346 347
          gradlew,
          '-q',
348
          '-Ptarget-platform=android-arm,android-arm64,android-x64',
349
          '-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
350
          '-Pbase-application-name=android.app.Application',
351
          '-Pdart-obfuscation=false',
352
          '-Ptrack-widget-creation=true',
353
          '-Ptree-shake-icons=true',
354 355
          'assembleRelease',
        ],
356 357
      ));

358
      // The command throws a [ToolExit] because it expects an APK in the file system.
359
      await expectLater(() =>  runBuildApkCommand(projectPath), throwsToolExit());
360

361 362
      expect(
        testLogger.statusText,
363 364 365 366 367 368
        allOf(
          containsIgnoringWhitespace("Your app isn't using AndroidX"),
          containsIgnoringWhitespace(
            'To avoid potential build failures, you can quickly migrate your app by '
            'following the steps on https://goo.gl/CP92wY'
          ),
369
        ),
370
      );
371 372 373
      expect(testUsage.events, contains(
        const TestUsageEvent(
          'build',
374
          'gradle',
375
          label: 'app-not-using-android-x',
376
          parameters: CustomDimensions(),
377 378
        ),
      ));
379
      expect(processManager, hasNoRemainingExpectations);
380 381 382 383
    },
    overrides: <Type, Generator>{
      AndroidSdk: () => mockAndroidSdk,
      FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
384
      Java: () => null,
385
      ProcessManager: () => processManager,
386
      Usage: () => testUsage,
387
      AndroidStudio: () => FakeAndroidStudio(),
388
    });
389 390

    testUsingContext('reports when the app is using AndroidX', () async {
391
      final String projectPath = await createProject(tempDir, arguments: <String>['--no-pub', '--template=app', '--platform=android']);
392 393
      processManager.addCommand(FakeCommand(
        command: <String>[
394 395
          gradlew,
          '-q',
396
          '-Ptarget-platform=android-arm,android-arm64,android-x64',
397
          '-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
398
          '-Pbase-application-name=android.app.Application',
399
          '-Pdart-obfuscation=false',
400
          '-Ptrack-widget-creation=true',
401
          '-Ptree-shake-icons=true',
402 403
          'assembleRelease',
        ],
404 405
      ));

406
      // The command throws a [ToolExit] because it expects an APK in the file system.
407
      await expectLater(() => runBuildApkCommand(projectPath), throwsToolExit());
408 409

      expect(
410 411 412 413 414 415
        testLogger.statusText, allOf(
          isNot(contains("[!] Your app isn't using AndroidX")),
          isNot(contains(
            'To avoid potential build failures, you can quickly migrate your app by '
            'following the steps on https://goo.gl/CP92wY'
          ))
416 417
        ),
      );
418 419 420
      expect(testUsage.events, contains(
        const TestUsageEvent(
          'build',
421
          'gradle',
422
          label: 'app-using-android-x',
423
          parameters: CustomDimensions(),
424 425
        ),
      ));
426
      expect(processManager, hasNoRemainingExpectations);
427 428 429 430
    },
    overrides: <Type, Generator>{
      AndroidSdk: () => mockAndroidSdk,
      FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
431
      Java: () => null,
432
      ProcessManager: () => processManager,
433
      Usage: () => testUsage,
434
      AndroidStudio: () => FakeAndroidStudio(),
435
    });
436 437 438 439
  });
}

Future<BuildApkCommand> runBuildApkCommand(
440
  String target, {
441
  List<String>? arguments,
442
}) async {
443
  final BuildApkCommand command = BuildApkCommand(logger: BufferLogger.test());
444 445 446 447
  final CommandRunner<void> runner = createTestCommandRunner(command);
  await runner.run(<String>[
    'apk',
    ...?arguments,
448
    '--no-pub',
449
    globals.fs.path.join(target, 'lib', 'main.dart'),
450 451
  ]);
  return command;
452
}
453

454 455 456 457 458 459 460
class FakeAndroidSdk extends Fake implements AndroidSdk {
  FakeAndroidSdk(this.directory);

  @override
  final Directory directory;
}

461 462 463
class FakeAndroidStudio extends Fake implements AndroidStudio {
  @override
  String get javaPath => 'java';
464 465 466

  @override
  Version get version => Version(2021, 3, 1);
467
}