Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4bd5eb59
Unverified
Commit
4bd5eb59
authored
Oct 25, 2019
by
Jonah Williams
Committed by
GitHub
Oct 25, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable track widget creation on by default (#43471)
parent
02abd00e
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
9 additions
and
8 deletions
+9
-8
compile.dart
packages/flutter_tools/lib/src/compile.dart
+1
-1
flutter_command.dart
packages/flutter_tools/lib/src/runner/flutter_command.dart
+1
-1
test_test.dart
...lutter_tools/test/commands.shard/permeable/test_test.dart
+2
-1
build_apk_test.dart
...ter_tools/test/general.shard/commands/build_apk_test.dart
+5
-5
No files found.
packages/flutter_tools/lib/src/compile.dart
View file @
4bd5eb59
...
...
@@ -514,7 +514,7 @@ class DefaultResidentCompiler implements ResidentCompiler {
String
sdkRoot
,
{
@required
this
.
buildMode
,
this
.
causalAsyncStacks
=
true
,
this
.
trackWidgetCreation
=
fals
e
,
this
.
trackWidgetCreation
=
tru
e
,
this
.
packagesPath
,
this
.
fileSystemRoots
,
this
.
fileSystemScheme
,
...
...
packages/flutter_tools/lib/src/runner/flutter_command.dart
View file @
4bd5eb59
...
...
@@ -361,7 +361,7 @@ abstract class FlutterCommand extends Command<void> {
argParser
.
addFlag
(
'track-widget-creation'
,
hide:
!
hasEffect
&&
!
verboseHelp
,
defaultsTo:
false
,
// this will soon be changed to true
defaultsTo:
true
,
help:
'Track widget creation locations. This enables features such as the widget inspector. '
'This parameter is only functional in debug mode (i.e. when compiling JIT, not AOT).'
,
);
...
...
packages/flutter_tools/test/commands.shard/permeable/test_test.dart
View file @
4bd5eb59
...
...
@@ -62,7 +62,8 @@ void main() {
testUsingContext
(
'report which user created widget caused the error - no flag'
,
()
async
{
Cache
.
flutterRoot
=
'../..'
;
return
_testFile
(
'print_user_created_ancestor_no_flag'
,
automatedTestsDirectory
,
flutterTestDirectory
);
return
_testFile
(
'print_user_created_ancestor_no_flag'
,
automatedTestsDirectory
,
flutterTestDirectory
,
extraArguments:
const
<
String
>[
'--no-track-widget-creation'
]);
},
skip:
io
.
Platform
.
isWindows
);
// TODO(chunhtai): Dart on Windows has trouble with unicode characters in output (#35425).
testUsingContext
(
'report correct created widget caused the error'
,
()
async
{
...
...
packages/flutter_tools/test/general.shard/commands/build_apk_test.dart
View file @
4bd5eb59
...
...
@@ -209,7 +209,7 @@ flutter:
gradlew
,
'-q'
,
'-Ptarget=
${fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}
'
,
'-Ptrack-widget-creation=
fals
e'
,
'-Ptrack-widget-creation=
tru
e'
,
'-Pshrink=true'
,
'-Ptarget-platform=android-arm,android-arm64,android-x64'
,
'assembleRelease'
,
...
...
@@ -241,7 +241,7 @@ flutter:
gradlew
,
'-q'
,
'-Ptarget=
${fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}
'
,
'-Ptrack-widget-creation=
fals
e'
,
'-Ptrack-widget-creation=
tru
e'
,
'-Ptarget-platform=android-arm,android-arm64,android-x64'
,
'assembleRelease'
,
],
...
...
@@ -265,7 +265,7 @@ flutter:
gradlew
,
'-q'
,
'-Ptarget=
${fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}
'
,
'-Ptrack-widget-creation=
fals
e'
,
'-Ptrack-widget-creation=
tru
e'
,
'-Pshrink=true'
,
'-Ptarget-platform=android-arm,android-arm64,android-x64'
,
'assembleRelease'
,
...
...
@@ -321,7 +321,7 @@ flutter:
gradlew
,
'-q'
,
'-Ptarget=
${fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}
'
,
'-Ptrack-widget-creation=
fals
e'
,
'-Ptrack-widget-creation=
tru
e'
,
'-Pshrink=true'
,
'-Ptarget-platform=android-arm,android-arm64,android-x64'
,
'assembleRelease'
,
...
...
@@ -374,7 +374,7 @@ flutter:
gradlew
,
'-q'
,
'-Ptarget=
${fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}
'
,
'-Ptrack-widget-creation=
fals
e'
,
'-Ptrack-widget-creation=
tru
e'
,
'-Pshrink=true'
,
'-Ptarget-platform=android-arm,android-arm64,android-x64'
,
'assembleRelease'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment