• Taha Tesser's avatar
    Revert "Update `OutlinedButton` tests for Material 3 (#136809)" (#137242) · d0fe9f20
    Taha Tesser authored
    This reverts commit d36a8433
    (https://github.com/flutter/flutter/pull/136809)
    
    This fails even tho golden files were approved and `golden test` pending
    was cleared and green and `autosubmit` successfully merged the PR.
    
    
    ```console
    02:42 +4618 ~5: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/outlined_button_test.dart: Material3 - OutlinedButton, OutlinedButton.icon defaults
    ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
    The following SkiaException was thrown while running async test code:
    Skia Gold received an unapproved image in post-submit
    testing. Golden file images in flutter/flutter are triaged
    in pre-submit during code review for the given PR.
    
    Visit https://flutter-gold.skia.org/ to view and approve
    the image(s), or revert the associated change. For more
    information, visit the wiki:
    https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
    
    Debug information for Gold --------------------------------
    stdout: Given image with hash 37275e74c51f98d7abd7f301c5c94ac1 for test
    material.outlined_button.ink_sparkle.default
    Expectation for test: 531f5fa74908d2e6db2b8fd86a6b8662 (positive)
    Expectation for test: 683e368ff51d947a3d63c2a5f4568cf6 (positive)
    Expectation for test: 749241ff0fa21595b2c6cb551fd40b68 (positive)
    Expectation for test: aaf9ac1328614d6c9f4540308bc86f62 (positive)
    Expectation for test: b31a50440c7dd31b10cacd9e7b5c6b86 (positive)
    Expectation for test: c0a7c8c625b69ddc695a770f28abd403 (positive)
    Expectation for test: f1f66ce931c2ef33ebcb699a637025a6 (positive)
    Expectation for test: 2d32e34efc1d7ca4cd12965402fb76ff (positive)
    Untriaged or negative image:
    https://flutter-gold.skia.org/detail?grouping=name%3Dmaterial.outlined_button.ink_sparkle.default%26source_type%3Dflutter&digest=37275e74c51f98d7abd7f301c5c94ac1
    
    
    stderr: Test: material.outlined_button.ink_sparkle.default FAIL
    
    
    result-state.json: No result file found.
    
    When the exception was thrown, this was the stack:
    #0      SkiaGoldClient.imgtestAdd (package:flutter_goldens_client/skia_client.dart:243:7)
    <asynchronous suspension>
    #1      MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart:118:32)
    <asynchronous suspension>
    <asynchronous suspension>
    (elided one frame from dart:async)
    
    The exception was caught asynchronously.
    ════════════════════════════════════════════════════════════════════════════════════════════════════
    02:42 +4618 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_anchor_test.dart: Menu functions keyboard directional traversal works
    02:42 +4618 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/outlined_button_test.dart: Material3 - OutlinedButton, OutlinedButton.icon defaults [E]
      Test failed. See exception logs above.
      The test description was: Material3 - OutlinedButton, OutlinedButton.icon defaults
      
    02:42 +4619 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_anchor_test.dart: Menu functions keyboard directional traversal works
    ```
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    d0fe9f20
Name
Last commit
Last update
..
flutter Loading commit data...
flutter_driver Loading commit data...
flutter_goldens Loading commit data...
flutter_goldens_client Loading commit data...
flutter_localizations Loading commit data...
flutter_test Loading commit data...
flutter_tools Loading commit data...
flutter_web_plugins Loading commit data...
fuchsia_remote_debug_protocol Loading commit data...
integration_test Loading commit data...
analysis_options.yaml Loading commit data...