• Renzo Olivares's avatar
    Introduce ParagraphBoundary subclass for text editing (#116549) · 6c12e399
    Renzo Olivares authored
    * attempt to extend to paragraph
    
    * second attempt
    
    * clean up implementation
    
    * clean up
    
    * updates
    
    * updates
    
    * Fix implementation
    
    * remove old
    
    * update docs
    
    * update docs
    
    * fix analyzer
    
    * Fix bug where new line character was selected and backwards selection failed
    
    * remove print
    
    * Add test for paragraph boundary
    
    * Add text editing test for extending selection to paragraph for mac and ios
    
    * rename to ExtendSelectionToParagraphBoundaryIntent
    
    * fix analyzer
    
    * Should default to downstream when collapsing selection
    
    * get rid of _getParagraphAtOffset and move into getTextBoundaryAt
    
    * Search for all line terminators
    
    * iterate through code units instead of characters
    
    * Address some reviewer comments"
    
    * Add separate implementations for leading and trailing paragraph boundary methods
    
    * Do not break after a carriage return if it is followed by a line feed
    
    * test carriage return followed by a line feed
    
    * more tests
    
    * Do not continue if the line terminator is at the target text offset
    
    * add hack to extend highlight to line terminator
    
    * Revert "add hack to extend highlight to line terminator"
    
    This reverts commit b4d3c434539b66c3c81c215e87c645b425902825.
    
    * Revert "Do not continue if the line terminator is at the target text offset"
    
    This reverts commit 789e1b838e54e7c25600bfa8852e59431ccaf5dc.
    
    * Update ParagraphBoundary with latest TextBoundary changes
    
    * Update implementation to iterate through indexes
    
    * update getTrailingTextBoundaryAt to include the line terminator
    
    * Updates
    
    * more updates
    
    * more updates
    
    * updates
    
    * updates
    
    * Lets try this again
    
    * clean up
    
    * updates
    
    * more updates
    
    * updates
    
    * fix
    
    * Re-implement using custom paragraph boundary applying method
    
    * Revert "Re-implement using custom paragraph boundary applying method"
    
    This reverts commit cd2f7f4b6eb6726b28f82a43708812e06a49df95.
    
    * Revert "fix"
    
    This reverts commit 8ec1f8f58935cfb3eb86dc6afd2894537af4cf7b.
    
    * updates
    
    * Revert "updates"
    
    This reverts commit 9dcca4a0031fe18ada9d6ffbbe77ba09918e82ae.
    
    * Revert "Revert "fix""
    
    This reverts commit 9cc1332cd3041badc472d0d223a106203e46afb8.
    
    * Revert "Revert "Re-implement using custom paragraph boundary applying method""
    
    This reverts commit 1acb606fb743fd840da20cca26d9a7c26accb71d.
    
    * Fix paragraph boundaries
    
    * Add failing test
    
    * Address some comments
    
    * group tests and fix analyzer
    
    * fix typo
    
    * fix remaining test
    
    * updates
    
    * more fixes and logs
    
    * clean up and add another test
    
    * Fix last test
    
    * Add new test
    
    * Clean up
    
    * more clean up
    
    * clean up comments
    
    * address comments
    
    * updates
    
    * return null when position is out of bounds and 0 or end of text if appropriate
    
    * Clean up cases
    
    * Do not return null when OOB in the direction of iteration
    
    * clean up
    
    * simplify implementation thanks to LongCatIsLooong feedback
    
    * Address comments
    
    * Add line and paragraph separator
    
    * Use _moveBeyondTextBoundary instead of custom _moveToParagraphBoundary
    
    * Change some intent names and revert fromPosition change
    
    * clean up docs
    
    ---------
    Co-authored-by: 's avatarRenzo Olivares <roliv@google.com>
    6c12e399
Name
Last commit
Last update
..
_platform_selectable_region_context_menu_io.dart Loading commit data...
_platform_selectable_region_context_menu_web.dart Loading commit data...
actions.dart Loading commit data...
animated_cross_fade.dart Loading commit data...
animated_scroll_view.dart Loading commit data...
animated_size.dart Loading commit data...
animated_switcher.dart Loading commit data...
annotated_region.dart Loading commit data...
app.dart Loading commit data...
async.dart Loading commit data...
autocomplete.dart Loading commit data...
autofill.dart Loading commit data...
automatic_keep_alive.dart Loading commit data...
banner.dart Loading commit data...
basic.dart Loading commit data...
binding.dart Loading commit data...
bottom_navigation_bar_item.dart Loading commit data...
color_filter.dart Loading commit data...
constants.dart Loading commit data...
container.dart Loading commit data...
context_menu_button_item.dart Loading commit data...
context_menu_controller.dart Loading commit data...
debug.dart Loading commit data...
default_selection_style.dart Loading commit data...
default_text_editing_shortcuts.dart Loading commit data...
desktop_text_selection_toolbar_layout_delegate.dart Loading commit data...
dismissible.dart Loading commit data...
display_feature_sub_screen.dart Loading commit data...
disposable_build_context.dart Loading commit data...
drag_target.dart Loading commit data...
draggable_scrollable_sheet.dart Loading commit data...
dual_transition_builder.dart Loading commit data...
editable_text.dart Loading commit data...
fade_in_image.dart Loading commit data...
focus_manager.dart Loading commit data...
focus_scope.dart Loading commit data...
focus_traversal.dart Loading commit data...
form.dart Loading commit data...
framework.dart Loading commit data...
gesture_detector.dart Loading commit data...
grid_paper.dart Loading commit data...
heroes.dart Loading commit data...
icon.dart Loading commit data...
icon_data.dart Loading commit data...
icon_theme.dart Loading commit data...
icon_theme_data.dart Loading commit data...
image.dart Loading commit data...
image_filter.dart Loading commit data...
image_icon.dart Loading commit data...
implicit_animations.dart Loading commit data...
inherited_model.dart Loading commit data...
inherited_notifier.dart Loading commit data...
inherited_theme.dart Loading commit data...
interactive_viewer.dart Loading commit data...
keyboard_listener.dart Loading commit data...
layout_builder.dart Loading commit data...
list_wheel_scroll_view.dart Loading commit data...
localizations.dart Loading commit data...
lookup_boundary.dart Loading commit data...
magnifier.dart Loading commit data...
media_query.dart Loading commit data...
modal_barrier.dart Loading commit data...
navigation_toolbar.dart Loading commit data...
navigator.dart Loading commit data...
nested_scroll_view.dart Loading commit data...
notification_listener.dart Loading commit data...
orientation_builder.dart Loading commit data...
overflow_bar.dart Loading commit data...
overlay.dart Loading commit data...
overscroll_indicator.dart Loading commit data...
page_storage.dart Loading commit data...
page_view.dart Loading commit data...
pages.dart Loading commit data...
performance_overlay.dart Loading commit data...
placeholder.dart Loading commit data...
platform_menu_bar.dart Loading commit data...
platform_selectable_region_context_menu.dart Loading commit data...
platform_view.dart Loading commit data...
preferred_size.dart Loading commit data...
primary_scroll_controller.dart Loading commit data...
raw_keyboard_listener.dart Loading commit data...
reorderable_list.dart Loading commit data...
restoration.dart Loading commit data...
restoration_properties.dart Loading commit data...
router.dart Loading commit data...
routes.dart Loading commit data...
safe_area.dart Loading commit data...
scroll_activity.dart Loading commit data...
scroll_aware_image_provider.dart Loading commit data...
scroll_configuration.dart Loading commit data...
scroll_context.dart Loading commit data...
scroll_controller.dart Loading commit data...
scroll_metrics.dart Loading commit data...
scroll_notification.dart Loading commit data...
scroll_notification_observer.dart Loading commit data...
scroll_physics.dart Loading commit data...
scroll_position.dart Loading commit data...
scroll_position_with_single_context.dart Loading commit data...
scroll_simulation.dart Loading commit data...
scroll_view.dart Loading commit data...
scrollable.dart Loading commit data...
scrollbar.dart Loading commit data...
selectable_region.dart Loading commit data...
selection_container.dart Loading commit data...
semantics_debugger.dart Loading commit data...
service_extensions.dart Loading commit data...
shared_app_data.dart Loading commit data...
shortcuts.dart Loading commit data...
single_child_scroll_view.dart Loading commit data...
size_changed_layout_notifier.dart Loading commit data...
sliver.dart Loading commit data...
sliver_fill.dart Loading commit data...
sliver_layout_builder.dart Loading commit data...
sliver_persistent_header.dart Loading commit data...
sliver_prototype_extent_list.dart Loading commit data...
slotted_render_object_widget.dart Loading commit data...
snapshot_widget.dart Loading commit data...
spacer.dart Loading commit data...
spell_check.dart Loading commit data...
status_transitions.dart Loading commit data...
table.dart Loading commit data...
tap_and_drag_gestures.dart Loading commit data...
tap_region.dart Loading commit data...
text.dart Loading commit data...
text_editing_intents.dart Loading commit data...
text_selection.dart Loading commit data...
text_selection_toolbar_anchors.dart Loading commit data...
text_selection_toolbar_layout_delegate.dart Loading commit data...
texture.dart Loading commit data...
ticker_provider.dart Loading commit data...
title.dart Loading commit data...
transitions.dart Loading commit data...
tween_animation_builder.dart Loading commit data...
unique_widget.dart Loading commit data...
value_listenable_builder.dart Loading commit data...
view.dart Loading commit data...
viewport.dart Loading commit data...
visibility.dart Loading commit data...
widget_inspector.dart Loading commit data...
widget_span.dart Loading commit data...
will_pop_scope.dart Loading commit data...
window.dart Loading commit data...