• Chris Bracken's avatar
    Eliminate MethodCall hashCode and equals (#12277) · 4e2e6979
    Chris Bracken authored
    Since MethodCall equality checks are limited to test scenarios, this
    patch replaces them with an equivalent test matcher. At present
    MethodCalls are always used in scenarios where indentity-based
    equality/hashing is appropriate.
    
    This change avoids an assertion failure when MethodCall args are
    Iterable (possible since args are of type dyanmic), and hashValue() from
    dart:ui asserts that its input is not an Iterable.
    
    The alternative of implementing support for deep equality in dart:ui was
    rejected on the basis that if we're to encourage performant code,
    expensive checks should be obviously-expensive to the author.
    4e2e6979
Name
Last commit
Last update
.idea Loading commit data...
bin Loading commit data...
dev Loading commit data...
examples Loading commit data...
packages Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
ISSUE_TEMPLATE.md Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
analysis_options.yaml Loading commit data...
analysis_options_repo.yaml Loading commit data...
appveyor.yml Loading commit data...