• Chris Bracken's avatar
    Eliminate MethodCall hashCode and equals (#12277) · 4e2e6979
    Chris Bracken authored
    Since MethodCall equality checks are limited to test scenarios, this
    patch replaces them with an equivalent test matcher. At present
    MethodCalls are always used in scenarios where indentity-based
    equality/hashing is appropriate.
    
    This change avoids an assertion failure when MethodCall args are
    Iterable (possible since args are of type dyanmic), and hashValue() from
    dart:ui asserts that its input is not an Iterable.
    
    The alternative of implementing support for deep equality in dart:ui was
    rejected on the basis that if we're to encourage performant code,
    expensive checks should be obviously-expensive to the author.
    4e2e6979
Name
Last commit
Last update
..
animation Loading commit data...
cupertino Loading commit data...
engine Loading commit data...
examples Loading commit data...
foundation Loading commit data...
gestures Loading commit data...
harness Loading commit data...
material Loading commit data...
painting Loading commit data...
physics Loading commit data...
rendering Loading commit data...
scheduler Loading commit data...
semantics Loading commit data...
services Loading commit data...
widgets Loading commit data...