• Hixie's avatar
    [Effen] Only skip rows we're showing, when skipping past the rows that we've... · 23283319
    Hixie authored
    [Effen] Only skip rows we're showing, when skipping past the rows that we've scrolled beyond in the stock list.
    
    Currently, if you then scroll down N items with a filter set, we select which
    stock to show by taking the entire list of stocks, skipping the first N, then
    filtering the list, then selecting as many stocks as needed to fill the list.
    
    So suppose the list is A, B, Cx, Dx, Ex, F, and the filter is "x", and you've
    scrolled down 1 item.
    
    Currently we'd show Cx, Dx, Ex.
    
    Scroll down 1 again.
    
    We still show Cx, Dx, Ex.
    
    What we _should_ show is Dx, Ex if you've scrolled down 1, and just Ex if you've
    scrolled two.
    
    This patch fixes this. We now skip rows _after_ filtering. This fixes
    the bug whereby if you set a filter then fling the list, we show the
    same item over and over as if in a loop.
    
    R=eseidel@chromium.org
    
    Review URL: https://codereview.chromium.org/1057603006
    23283319
Name
Last commit
Last update
examples Loading commit data...
packages/flutter Loading commit data...