• Lau Ching Jun's avatar
    Avoid depending on files from build_system/targets other than from top level... · ac7879e2
    Lau Ching Jun authored
    Avoid depending on files from build_system/targets other than from top level entrypoints in flutter_tools. (#142760)
    
    Add a new `BuildTargets` class that provides commonly used build targets. And avoid importing files from `build_system/targets` except from the top level entrypoints or from top level commands.
    
    Also move `scene_importer.dart` and `shader_compiler.dart` into `build_system/tools` because they are not `Target` classes, but wrapper for certain tools.
    
    With this change, we can ignore all files in `build_system/targets` internally and make PR #142709 easier to land internally. See cl/603434066 for the corresponding internal change.
    
    Related to:
    https://github.com/flutter/flutter/pull/142709
    https://github.com/flutter/flutter/issues/142041
    
    Also note that I have opted to add a new variable in `globals.dart` for `BuildTargets` in this PR, but I know that we are trying to get rid of globals. Several alternatives that I was considering:
    
    1. Add a new field in `BuildSystem` that returns a `BuildTargets` instance. Since `BuildSystem` is already in `globals`, we can access build targets using `globals.buildSystem.buildTargets` without adding a new global variable.
    2. Properly inject the `BuildTargetsImpl` instance from the top level `executable.dart` and top level commands.
    
    Let me know if you want me to do one of the above instead. Thanks!
    ac7879e2
Name
Last commit
Last update
..
debug_adapter Loading commit data...
test_data Loading commit data...
README.md Loading commit data...
analyze_all_templates_test.dart Loading commit data...
analyze_once_test.dart Loading commit data...
analyze_size_test.dart Loading commit data...
analyze_suggestions_integration_test.dart Loading commit data...
android_e2e_api_test.dart Loading commit data...
android_gradle_deprecated_plugin_apply_test.dart Loading commit data...
android_gradle_java_version_test.dart Loading commit data...
android_gradle_outputs_app_link_settings_test.dart Loading commit data...
android_gradle_print_build_variants_test.dart Loading commit data...
android_plugin_compilesdkversion_mismatch_test.dart Loading commit data...
android_plugin_example_app_build_test.dart Loading commit data...
android_plugin_ndkversion_mismatch_test.dart Loading commit data...
android_plugin_new_output_dir_test.dart Loading commit data...
background_isolate_test.dart Loading commit data...
bash_entrypoint_test.dart Loading commit data...
batch_entrypoint_test.dart Loading commit data...
break_on_framework_exceptions_test.dart Loading commit data...
build_ios_config_only_test.dart Loading commit data...
build_macos_config_only_test.dart Loading commit data...
build_preview_test.dart Loading commit data...
cache_test.dart Loading commit data...
command_output_test.dart Loading commit data...
coverage_collection_test.dart Loading commit data...
daemon_mode_test.dart Loading commit data...
debugger_stepping_test.dart Loading commit data...
deferred_components_test.dart Loading commit data...
deprecated_gradle_settings_test.dart Loading commit data...
devtools_uri_test.dart Loading commit data...
downgrade_upgrade_integration_test.dart Loading commit data...
exit_code_test.dart Loading commit data...
expression_evaluation_test.dart Loading commit data...
flutter_attach_test.dart Loading commit data...
flutter_build_android_app_project_builddir_test.dart Loading commit data...
flutter_build_apk_verbose_test.dart Loading commit data...
flutter_build_config_only_test.dart Loading commit data...
flutter_build_wasm_test.dart Loading commit data...
flutter_build_windows_test.dart Loading commit data...
flutter_build_with_compilation_error_test.dart Loading commit data...
flutter_gen_test.dart Loading commit data...
flutter_run_test.dart Loading commit data...
flutter_run_with_error_test.dart Loading commit data...
forbidden_imports_test.dart Loading commit data...
gen_l10n_test.dart Loading commit data...
gradle_non_android_plugin_test.dart Loading commit data...
hot_reload_errors_test.dart Loading commit data...
hot_reload_test.dart Loading commit data...
hot_reload_with_asset_test.dart Loading commit data...
lifetime_test.dart Loading commit data...
native_assets_test.dart Loading commit data...
observatory_port_test.dart Loading commit data...
overall_experience_test.dart Loading commit data...
plist_parser_test.dart Loading commit data...
shader_compiler_test.dart Loading commit data...
stateless_stateful_hot_reload_test.dart Loading commit data...
template_manifest_test.dart Loading commit data...
test_driver.dart Loading commit data...
test_test.dart Loading commit data...
test_utils.dart Loading commit data...
timeline_test.dart Loading commit data...
tool_backend_test.dart Loading commit data...
transition_test_utils.dart Loading commit data...
unit_coverage_test.dart Loading commit data...
variable_expansion_windows.dart Loading commit data...
variable_expansion_windows_test.dart Loading commit data...
vmservice_integration_test.dart Loading commit data...
web_plugin_registrant_test.dart Loading commit data...
xcode_backend_test.dart Loading commit data...