• auto-submit[bot]'s avatar
    Reverts "Skip injecting Bonjour settings when port publication is disabled" (#136750) · 54c0a350
    auto-submit[bot] authored
    Reverts flutter/flutter#136562
    Initiated by: vashworth
    This change reverts the following previous change:
    Original Description:
    Some of our tests in CI are triggering the `NSLocalNetworkUsageDescription` dialog when they're not supposed to (https://github.com/flutter/flutter/issues/129836) since it's disabled via flags (`--no-publish-port` for flutter/flutter and `--disable-vm-service-publication` for flutter/engine).
    
    Normally, we inject `NSLocalNetworkUsageDescription` (and other bonjour settings) to the Info.plist during the project build for debug and profile mode since by default they will publish the VM Service port over mDNS.
    
    To help diagnose the issue, though, this PR changes it so that we don't inject `NSLocalNetworkUsageDescription` (and other bonjour settings) when port publication is disabled since it shouldn't be needed. Hopefully, this will give us better error messages or cause the app to crash and end the test early (rather than timeout after 30 minutes).
    54c0a350
Name
Last commit
Last update
..
analysis.dart Loading commit data...
android_choreographer_do_frame_test.dart Loading commit data...
android_lifecycles_test.dart Loading commit data...
build_test_task.dart Loading commit data...
dart_plugin_registry_tests.dart Loading commit data...
entrypoint_dart_registrant.dart Loading commit data...
flutter_tool_startup.dart Loading commit data...
gallery.dart Loading commit data...
hot_mode_tests.dart Loading commit data...
integration_tests.dart Loading commit data...
microbenchmarks.dart Loading commit data...
native_assets_test.dart Loading commit data...
new_gallery.dart Loading commit data...
perf_tests.dart Loading commit data...
platform_channels_benchmarks.dart Loading commit data...
plugin_tests.dart Loading commit data...
run_tests.dart Loading commit data...
web_benchmarks.dart Loading commit data...
web_dev_mode_tests.dart Loading commit data...