• Vyacheslav Egorov's avatar
    Strong mode fixes in tests (#14520) · 0556e14f
    Vyacheslav Egorov authored
    * Use explicit types for onClick handler in diagnostics_test.
    
    This test formats it to string and expects exact match.
    
    Before this change onClick had type () => dynamic in Dart 1 and () => Null in
    Dart 2.
    
    * Fix strong mode issues in packages/flutter/test/material/dropdown_test.dart
    
    Pass explicit type argument to renderObjectList(...) in expressions like
    
         List<RenderBox> l = tester.renderObjectList(...).toList();
    
    Dart 2 mode inference is not strong enough to infer RenderBox as a type argument
    fto renderObjectList and passes RenderObject instead, which later leads to
    runtime check failures (because List<RenderObject> is not List<RenderBox>).
    
    * Fix strong mode issues in packages/flutter/test/material/theme_test.dart.
    
    Pass type argument explicity to widgetList. Dart 2 type inference can't infer
    it by itself.
    
    * Fix strong mode issue packages/flutter/test/widgets/unique_widget_test.dart
    
    Pass correct type argument to GlobalKey.
    
    * Fix type annotation in packages/flutter/test/material/app_test.dart.
    
    pushNamed returns Future<Object> not Future<String>.
    0556e14f
Name
Last commit
Last update
..
about_test.dart Loading commit data...
animated_icons_private_test.dart Loading commit data...
animated_icons_test.dart Loading commit data...
app_bar_test.dart Loading commit data...
app_builder_test.dart Loading commit data...
app_test.dart Loading commit data...
arc_test.dart Loading commit data...
back_button_test.dart Loading commit data...
bottom_navigation_bar_test.dart Loading commit data...
button_bar_test.dart Loading commit data...
button_theme_test.dart Loading commit data...
buttons_test.dart Loading commit data...
card_test.dart Loading commit data...
checkbox_test.dart Loading commit data...
chip_test.dart Loading commit data...
circle_avatar_test.dart Loading commit data...
colors_test.dart Loading commit data...
control_list_tile_test.dart Loading commit data...
data_table_test.dart Loading commit data...
data_table_test_utils.dart Loading commit data...
date_picker_test.dart Loading commit data...
debug_test.dart Loading commit data...
dialog_test.dart Loading commit data...
divider_test.dart Loading commit data...
drawer_test.dart Loading commit data...
dropdown_test.dart Loading commit data...
expand_icon_test.dart Loading commit data...
expansion_panel_test.dart Loading commit data...
expansion_tile_test.dart Loading commit data...
feedback_test.dart Loading commit data...
feedback_tester.dart Loading commit data...
flat_button_test.dart Loading commit data...
flexible_space_bar_test.dart Loading commit data...
floating_action_button_test.dart Loading commit data...
grid_title_test.dart Loading commit data...
icon_button_test.dart Loading commit data...
icons.dart Loading commit data...
ink_paint_test.dart Loading commit data...
ink_well_test.dart Loading commit data...
input_decorator_test.dart Loading commit data...
list_tile_test.dart Loading commit data...
localizations_test.dart Loading commit data...
material_test.dart Loading commit data...
mergeable_material_test.dart Loading commit data...
modal_bottom_sheet_test.dart Loading commit data...
page_selector_test.dart Loading commit data...
page_test.dart Loading commit data...
paginated_data_table_test.dart Loading commit data...
persistent_bottom_sheet_test.dart Loading commit data...
popup_menu_test.dart Loading commit data...
progress_indicator_test.dart Loading commit data...
radio_test.dart Loading commit data...
refresh_indicator_test.dart Loading commit data...
scaffold_test.dart Loading commit data...
scrollbar_paint_test.dart Loading commit data...
scrollbar_test.dart Loading commit data...
slider_test.dart Loading commit data...
snack_bar_test.dart Loading commit data...
stepper_test.dart Loading commit data...
switch_test.dart Loading commit data...
tabbed_scrollview_warp_test.dart Loading commit data...
tabs_test.dart Loading commit data...
text_field_focus_test.dart Loading commit data...
text_field_splash_test.dart Loading commit data...
text_field_test.dart Loading commit data...
text_form_field_test.dart Loading commit data...
theme_data_test.dart Loading commit data...
theme_test.dart Loading commit data...
time_picker_test.dart Loading commit data...
time_test.dart Loading commit data...
tooltip_test.dart Loading commit data...
two_level_list_test.dart Loading commit data...
typography_test.dart Loading commit data...
user_accounts_drawer_header_test.dart Loading commit data...
will_pop_test.dart Loading commit data...