• Jonah Williams's avatar
    [flutter_tools] handle terminals that do not support single char mode in... · 039f1cf8
    Jonah Williams authored
    [flutter_tools] handle terminals that do not support single char mode in Terminal.promptForCharInput (#65418)
    
    Some terminals stdin do not support single char mode (like an emacs terminal buffer apparently). If this is the case, then the presented choice values would always have an appended newline \n which would prevent us from finding the value in the listed index (or using it as a signal for the default choice). To fix, treat '' as the default choice and always trim the choice value.
    
    While this has seemingly always been broken, it wasn't noticeable until the multi-device selection prompt was added a few months ago.
    
    Fixes #65267
    039f1cf8
Name
Last commit
Last update
..
android Loading commit data...
base Loading commit data...
build_runner Loading commit data...
build_system Loading commit data...
commands Loading commit data...
dart Loading commit data...
fuchsia Loading commit data...
intellij Loading commit data...
ios Loading commit data...
linux Loading commit data...
localizations Loading commit data...
macos Loading commit data...
reporting Loading commit data...
runner Loading commit data...
test Loading commit data...
tester Loading commit data...
vscode Loading commit data...
web Loading commit data...
windows Loading commit data...
aot.dart Loading commit data...
application_package.dart Loading commit data...
artifacts.dart Loading commit data...
asset.dart Loading commit data...
build_info.dart Loading commit data...
bundle.dart Loading commit data...
cache.dart Loading commit data...
cmake.dart Loading commit data...
compile.dart Loading commit data...
context_runner.dart Loading commit data...
convert.dart Loading commit data...
desktop_device.dart Loading commit data...
devfs.dart Loading commit data...
device.dart Loading commit data...
doctor.dart Loading commit data...
emulator.dart Loading commit data...
features.dart Loading commit data...
flutter_manifest.dart Loading commit data...
flutter_project_metadata.dart Loading commit data...
globals.dart Loading commit data...
mdns_discovery.dart Loading commit data...
persistent_tool_state.dart Loading commit data...
platform_plugins.dart Loading commit data...
plugins.dart Loading commit data...
project.dart Loading commit data...
protocol_discovery.dart Loading commit data...
proxy_validator.dart Loading commit data...
resident_runner.dart Loading commit data...
run_cold.dart Loading commit data...
run_hot.dart Loading commit data...
template.dart Loading commit data...
tracing.dart Loading commit data...
version.dart Loading commit data...
vmservice.dart Loading commit data...
widget_cache.dart Loading commit data...