1. 03 Jun, 2019 1 commit
  2. 29 May, 2019 1 commit
    • LongCatIsLooong's avatar
      Fix ScrollbarPainter thumbExtent calculation and add padding (#31763) · 22ea031e
      LongCatIsLooong authored
      - Fixed extentInside calculation in ScrollMetrics
      - Added asserts to extentInside getter, as well as ScrollPosition.applyContentDimensions to enforce minScrollExtent <= maxScrollExtent
      - Added padding to ScrollbarPainter, updated implementation. Took care of some edge cases.
      - Changed some scroll bar constants on Cupertino side.
      22ea031e
  3. 06 Mar, 2019 1 commit
  4. 28 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Fix spelling errors. (#28657) · ccdd5057
      Greg Spencer authored
      Fix the spelling errors in the dartdocs for the framework.
      
      There are no functionality changes here, just documentation fixes.
      ccdd5057
  5. 21 Feb, 2019 1 commit
  6. 30 Jan, 2019 1 commit
  7. 18 Dec, 2018 1 commit
  8. 07 Nov, 2018 1 commit
  9. 16 Oct, 2018 1 commit
  10. 12 Sep, 2018 1 commit
  11. 30 Jul, 2018 1 commit
  12. 07 Jun, 2018 1 commit
  13. 05 Jun, 2018 1 commit
  14. 18 May, 2018 1 commit
  15. 23 Apr, 2018 1 commit
    • Yegor's avatar
      a11y traversal: sort locally; use new sorting algorithm (#16253) · d3540962
      Yegor authored
      New a11y traversal:
      
      - sort direct sibling SemanticsNodes only
      - use new sorting algorithm
      - implement RTL
      - test semantics in traversal order by default
      - add AppBar traversal test
      - breaking: remove nextNodeId/previousNodeId from the framework
      - breaking: remove DebugSemanticsDumpOrder.geometricOrder
      d3540962
  16. 12 Mar, 2018 1 commit
  17. 02 Feb, 2018 1 commit
  18. 01 Feb, 2018 1 commit
  19. 25 Jan, 2018 1 commit
  20. 19 Jan, 2018 1 commit
  21. 17 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Fix spelling errors in all the dartdocs. (#13061) · 0259be90
      Greg Spencer authored
      I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.
      
      This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
      0259be90
  22. 14 Nov, 2017 1 commit
    • Jeff McGlynn's avatar
      PageView ballistics overshoot the page on some devices (#12884) · 473d75a6
      Jeff McGlynn authored
      * PageView ballistics overshoot the page on some devices
      
      On some devices, such as Cupertino “Plus”-sized devices, scrolling left on the first page of a PageView will overshoot the first page and land on the second page.
      
      The issue is that applyContentDimensions incorrectly detects a content size change due to a floating point comparison on certain screen sizes (18257.400000000005 vs 18257.4)
      
      To fix this, perform a nearEqual comparison in applyContentDimensions.
      
      * Apply style changes to nearEqual for code review feedback.
      473d75a6
  23. 31 Oct, 2017 1 commit
  24. 11 Oct, 2017 1 commit
  25. 21 Sep, 2017 1 commit
  26. 28 Jul, 2017 1 commit
  27. 21 Jul, 2017 1 commit
    • Ian Hickson's avatar
      Add documentation and clean up code. (#11330) · 8f56f6fd
      Ian Hickson authored
      Mainly, this adds documentation to members that were previously
      lacking documentation.
      
      It also adds a big block of documentation about improving performance
      of widgets.
      
      This also removes some references to package:collection and adds
      global setEquals and listEquals methods in foundation that we can use.
      (setEquals in particular should be much faster than the
      package:collection equivalent, though both should be faster as they
      avoid allocating new objects.) All remaining references now qualify
      the import so we know what our remaining dependencies are.
      
      Also lots of code reordering in Flutter driver to make the code
      consistent and apply the style guide more thoroughly.
      8f56f6fd
  28. 19 Jul, 2017 2 commits
  29. 09 Jun, 2017 1 commit
  30. 08 Jun, 2017 1 commit
  31. 06 Jun, 2017 1 commit
  32. 02 Jun, 2017 1 commit
  33. 23 May, 2017 1 commit
  34. 09 May, 2017 1 commit
  35. 05 May, 2017 1 commit
  36. 03 May, 2017 2 commits
  37. 02 May, 2017 1 commit
    • Ian Hickson's avatar
      Tapping a ScrollView during overscroll got it stuck. (#9721) · f64bfba8
      Ian Hickson authored
      Fixes https://github.com/flutter/flutter/issues/8476
      
      More detailed list of changes in this patch:
      
      * Replaced the didTouch special logic with more generic logic that
        uses Activities instead. Now instead when you tap down the
        Scrollable calls `hold()` which begins a HoldScrollActivity which is
        a hybrid of DragStartDetails and IdleScrollActivity and can be
        canceled. When you let go, it gets canceled and that goes ballistic.
      
      * Make DragGestureRecognizer more aggressive about grabbing pointers,
        otherwise a second pointer in a situation with competing horizontal
        and vertical recognizers always gets taken by the other one.
      
      * Fixed the _GestureSemantics widget to call the "down" callbacks so
        that it follows the same pattern as "real" interactions.
      
      * Added tests for the above.
      
      * Added a hashCode to ScrollActivity.toString (and subclasses).
      
      * Added a toString to ScrollDragController, and include it in
        DragScrollActivity's toString.
      
      * s/coorindator/coordinator/
      
      * Add a comment in DragStartDetails to distinguish it from the
        otherwise identical DragDownDetails, so we're not tempted to merge
        them.
      f64bfba8
  38. 27 Apr, 2017 1 commit
    • Adam Barth's avatar
      Shift more code to ScrollPosition (#9637) · 4bac2596
      Adam Barth authored
      Previously, ScrollPosition did not know about ScrollActivities. However, all
      the concrete subclasses of ScrollPosition that we know about need to use
      ScrollActivities, so they ended up with a bunch of delegate boilerplate code.
      
      This patch teaches ScrollPosition about ScrollActivities but doesn't have any
      opinion about how to start or interact with those activities.
      
      This patch is more refactoring to prepare for nested and linked scrolling.
      4bac2596