- 29 Apr, 2019 1 commit
-
-
Dan Field authored
* Re-enable const
-
- 17 Apr, 2019 1 commit
-
-
Gary Qian authored
Will cause golden and Scuba changes. Caret will become taller and shift upwards by 2 pixels.
-
- 16 Apr, 2019 2 commits
-
-
Gary Qian authored
- 11 Apr, 2019 2 commits
-
-
chunhtai authored
-
champeauxr authored
RenderTable._computeColumnWidths() had a logic error that caused flex columns to be collapsed to their minimum widths in certain situations dependent on the layout width constraint and the number of flex columns.
-
- 10 Apr, 2019 1 commit
-
-
Dan Field authored
* Check for invalid elevation usage in the layer tree
-
- 05 Apr, 2019 1 commit
-
-
chunhtai authored
-
- 22 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 Mar, 2019 2 commits
-
-
Mouad Debbar authored
-
Dan Field authored
* Composite physical layers even if elevation is 0
-
- 20 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* some space formattings * always use blocks in if-else if a block is used * format spaces in for and while * allow multiline if conditions * fix missing space
-
- 19 Mar, 2019 1 commit
-
- 18 Mar, 2019 1 commit
-
-
Dan Field authored
Reland composite physical layers and update tests
-
- 15 Mar, 2019 2 commits
-
-
Mouad Debbar authored
-
Justin McCandless authored
Adds the `minLines` and `expands` parameters for controlling text height. The original PR was reverted, so this one contains a few extra fixes for the tests that were broken.
-
- 14 Mar, 2019 1 commit
-
- 12 Mar, 2019 1 commit
-
-
Dan Field authored
* Always composite PhysicalModels * Update tests to check layer tree instead of canvas for Physical shadows
-
- 09 Mar, 2019 2 commits
-
-
Todd Volkert authored
This reverts commit 9e9f48da.
-
Alexandre Ardhuin authored
-
- 08 Mar, 2019 1 commit
-
-
Justin McCandless authored
* Create new TextField attribute to control maxLength behaviour * Create test case for maxLinesIncrementalHeight * fix maxLinesIncrementalHeight set method * fix editable_test.dart * Just introducing some proposed API additions, renaming to expands * Pass minLines and expands through to child widgets and validate * minLines can't be null, and expands can't be true when maxLines is 1 * Implement minLines and maxLines height sizing logic * Simplify minLines validation logic * expands parameter proof of concept * min/max mixup bug fix, and tests work with expands false * Test expands=true cases, and fix textPainter.height being out of date * Test all behavior matrix cases * min/max assertion more strict, can't be equal * Tests work that were missing expands serialization * Action sheet tests no longer fail due to rounding error * TextFieldFocus test no longer mysteriously fails * TODOs for making expands nullable. Will depend on how Expanded wrapping works * Expanded growth happens when expanded is true and maxLines is null * Test Expanded wrapper * No more overflow when wrapped in Expanded * Docs improvements * expands can be null * Simplify error cases to support existing behavior * Docs examples and other docs cleanup * Expansion up to perfectly meet the parent size * Fix analyze null error * Fix test after move to nullable expands * minLines defaults to null * expands is now exclusively for expanding to parent height and not growth between min and max * _layout rewritten to handle max height. Need to fix prefix tests and reenable expands * Tests for textfield overflowing parent * layoutLineBox is documented and private * expands works in new _layout * _layout return numbers seem to perfectly match original _layout * inputWidth comment after trying it out and failing tests * Fix analyze errors * WIP prefix/suffix do affect height * Prefix/suffix and icons affect height, tests pass, but I'm still visually verifying identical to original * Tall prefix test that verifies pixel perfect layout * Fix overflowing edge case and test it * Clean up comments, old code, and todos * Changing _expands causes relayout. Wasnt able to figure out how to test though... * Clean up code review comments * Fix misalignment when tall prefix and border, and clean up related test * Simple code review cleanup * Bring back inputWidth to _layout method * Fix rounding errors showing up in mac tests * Fix flake by reordering tests. Without this, the dreaded intrinsicwidth flake is reproducible 50% of the time on my machine. * Fix more rounding error mac tests
-
- 06 Mar, 2019 2 commits
-
-
Phil Quitslund authored
-
Alexandre Ardhuin authored
* fix some formatting issues * address review comments * fix indent
-
- 01 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add trailing commas on list/map/parameters * add trailing commas on Invocation with nb of arg>1 * add commas for widget containing widgets * add trailing commas if instantiation contains trailing comma * revert bad change
-
- 27 Feb, 2019 1 commit
-
-
liyuqian authored
## Description Also update the existing dart files with missing licenses. Without the fix, we'll emit the following error message ``` License headers cannot be found at the beginning of the following files. /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/lib/src/animation/tween_sequence.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/material/raw_material_button_test.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/async_lifecycle_test.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/sliver_constraints_test.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/app_test.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/test_border.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/physical_model_test.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/inherited_model.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/lib/src/base/user_messages.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/src/pubspec_schema.dart /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/ios/simulators_test.dart ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ``` ## Related Issues Fixes https://github.com/flutter/flutter/issues/28368 ## Checklist Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] My PR includes tests for *all* changed/updated/fixed behaviors (See [Test Coverage]). - [x] All existing and new tests are passing. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I am willing to follow-up on review comments in a timely manner. ## Breaking Change Does your PR require Flutter developers to manually update their apps to accommodate your change? - [ ] Yes, this is a breaking change (Please read [Handling breaking changes]). - [x] No, this is *not* a breaking change. <!-- Links --> [issue database]: https://github.com/flutter/flutter/issues [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
-
- 25 Feb, 2019 1 commit
-
-
xster authored
-
- 21 Feb, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Feb, 2019 2 commits
- 05 Feb, 2019 2 commits
-
-
xster authored
-
Matt Carroll authored
-
- 30 Jan, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 29 Jan, 2019 3 commits
-
-
Alexandre Ardhuin authored
-
Konstantin Scheglov authored
-
jslavitz authored
* Fixes cursor on iOS devices
-
- 23 Jan, 2019 1 commit
-
-
Alexandre Ardhuin authored
* fix some bad indentations * remove suspicious line
-
- 17 Jan, 2019 1 commit
-
-
Michael Goderbauer authored
Fixes #20893, the most-upvoted bug for framework. A detailed analysis explaining the cause of the bug has been posted at #20893 (comment).
-
- 16 Jan, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 09 Jan, 2019 1 commit
-
-
matthew-carroll authored
-
- 07 Jan, 2019 1 commit
-
-
Alexandre Ardhuin authored
-