1. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must not be null' comments from painting and rendering libraries. (#134993) · fe9a2c54
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the painting and rendering libraries.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      fe9a2c54
  2. 21 Jun, 2023 1 commit
  3. 25 May, 2023 1 commit
  4. 21 Jan, 2023 1 commit
  5. 25 May, 2022 1 commit
    • Pierre-Louis's avatar
      Use `curly_braces_in_flow_control_structures` for `foundation`, `gestures`,... · 9cc72df7
      Pierre-Louis authored
      Use `curly_braces_in_flow_control_structures` for `foundation`, `gestures`, `painting`, `physics` (#104610)
      
      * Use `curly_braces_in_flow_control_structures` for `foundation`
      
      * Use `curly_braces_in_flow_control_structures` for `gestures`
      
      * Use `curly_braces_in_flow_control_structures` for `painting`
      
      * Use `curly_braces_in_flow_control_structures` for `physics`
      
      * fix comments
      
      * remove trailing space
      
      * fix TODO style
      9cc72df7
  6. 18 May, 2022 1 commit
  7. 01 Mar, 2022 1 commit
  8. 28 Aug, 2020 1 commit
  9. 20 Aug, 2020 1 commit
  10. 12 Aug, 2020 1 commit
  11. 11 Jun, 2020 1 commit
  12. 05 Dec, 2019 1 commit
  13. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  14. 12 Sep, 2018 1 commit
  15. 05 Jun, 2018 1 commit
  16. 24 Sep, 2017 1 commit
    • Ian Hickson's avatar
      positionDependentBox (#12232) · 47c387b6
      Ian Hickson authored
      Fix the documentation (it was just wrong before).
      
      Add an explicit code path to handle horizontal overflow so that we
      don't have a left bias.
      47c387b6
  17. 23 Sep, 2017 1 commit
  18. 21 Aug, 2017 1 commit
    • Jacob Richman's avatar
      Bare bones widget inspector support. (#10332) · 5462ddb9
      Jacob Richman authored
      Bare bones widget inspector support.
      
      Toggle the widget inspector from the flutter tool by pressing 'i'.
      When the widget inspector is select mode:
      Pointer down to to inspect a widget.
      Pointer click to finalize selection of a widget. You can now interact
      with the application as you normally would but with the inspected widget
      highlighted.
      Click the inspect icon in bottom left corner of screen to reactivate
      select mode.
      5462ddb9