- 06 Sep, 2023 1 commit
-
-
Burak İmdat authored
The difference between header text style and subtitle text style and the reason why it doesn't work is the code difference below. If we make the subtitle text style the same as the title text style it will work <details> <summary>Title Text Style</summary> ### All Code ```dart TextStyle titleStyle = titleTextStyle ?? tileTheme.titleTextStyle ?? defaults.titleTextStyle!; final Color? titleColor = effectiveColor; titleStyle = titleStyle.copyWith( color: titleColor, fontSize: _isDenseLayout(theme, tileTheme) ? 13.0 : null, ); final Widget titleText = AnimatedDefaultTextStyle( style: titleStyle, duration: kThemeChangeDuration, child: title ?? const SizedBox(), ); ``` ## Different Code Section ```dart final Color? titleColor = effectiveColor; ``` </details> <details> <summary>Subtitle Text Style</summary> ## All Code ```dart subtitleStyle = subtitleTextStyle ?? tileTheme.subtitleTextStyle ?? defaults.subtitleTextStyle!; final Color? subtitleColor = effectiveColor ?? (theme.useMaterial3 ? null : theme.textTheme.bodySmall!.color); subtitleStyle = subtitleStyle.copyWith( color: subtitleColor, fontSize: _isDenseLayout(theme, tileTheme) ? 12.0 : null, ); subtitleText = AnimatedDefaultTextStyle( style: subtitleStyle, duration: kThemeChangeDuration, child: subtitle!, ); ``` ## Different Code Section ```dart final Color? subtitleColor = effectiveColor ?? (theme.useMaterial3 ? null : theme.textTheme.bodySmall!.color); ``` ### Description for code - The value `theme.textTheme.bodySmall!.color` is given because the `effectiveColor` value is `null` and the `theme.useMaterial3` value is `false` </details> <details> <summary>Problem solved code</summary> ## All Code ```dart subtitleStyle = subtitleTextStyle ?? tileTheme.subtitleTextStyle ?? defaults.subtitleTextStyle!; final Color? subtitleColor = effectiveColor; subtitleStyle = subtitleStyle.copyWith( color: subtitleColor, fontSize: _isDenseLayout(theme, tileTheme) ? 12.0 : null, ); subtitleText = AnimatedDefaultTextStyle( style: subtitleStyle, duration: kThemeChangeDuration, child: subtitle!, ); ``` </details> <details> <summary>Screenshot of the result after making the necessary change</summary> <img src="https://github.com/flutter/flutter/assets/70351342/b552fd4c-fdcd-4bf5-b4ba-d6b2cfe527cc" width=250> </details> #133412 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
- 12 Jun, 2023 1 commit
-
-
Taha Tesser authored
fixes https://github.com/flutter/flutter/issues/128569 <details> <summary>code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const ListTileApp()); } class ListTileApp extends StatelessWidget { const ListTileApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( useMaterial3: true, colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith( onSurface: Colors.yellow, onSurfaceVariant: Colors.green, ), ), home: const Scaffold( body: Center( child: ListTile( title: Text('title'), subtitle: Text('subtitle'), ), ), ), ); } } ``` </details> # Description M3 ListTile couldn't be customized using `ColorScheme` colors. - This PR updates the list tile text defaults to `ColorScheme` text color tokens. - Improved the `ListTile` template to use the token group. - Update docs and tests. ```dart colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith( onSurface: Colors.yellow, onSurfaceVariant: Colors.green, ), ``` ### Before  ### After 
-
- 09 Jun, 2023 1 commit
-
-
Pierre-Louis authored
## Description This improves defaults generation with logging, stats, and token validation. This PR includes these changes: * introduce `TokenLogger`, with a verbose mode * prints versions and tokens usage to the console * outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google * find token files in `data` automatically * hide tokens `Map` * tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`. * tokens can be checked for existence with `tokenAvailable` * remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version * improve documentation ## Related Issues - Fixes https://github.com/flutter/flutter/issues/122602 ## Tests - Added tests for `TokenLogger` - Regenerated tokens, no-op except version removal ## Future work A future PR should replace or remove the following invalid tokens usages <img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00">
-
- 01 Jun, 2023 1 commit
-
-
Hans Muller authored
-
- 16 May, 2023 1 commit
-
-
Ian Hickson authored
This is a proof of concept for renaming SlottedMultiChildRenderObjectWidgetMixin to SlottedMultiChildRenderObjectWidget and making it a concrete class. I also made SlottedContainerRenderObjectMixin generic instead of being specialized to RenderBox. I don't think this is something we can easily automigrate, but we may not need to, I don't know how common this is...
-
- 13 Mar, 2023 1 commit
-
-
Pierre-Louis authored
Update Material tokens to 0.162
-
- 17 Feb, 2023 1 commit
-
-
Ian Hickson authored
* lerp documentation * Remove Note, Note That from repo * Improve BorderSide documentation. * apply review comments
-
- 13 Feb, 2023 1 commit
-
-
Taha Tesser authored
-
- 09 Feb, 2023 1 commit
-
-
Hans Muller authored
* added ListTile.textAlignment * changed titlesHeight to titleHeight * fixed a typo * Add tests and example * Update tests * update example test --------- Co-authored-by:
tahatesser <tessertaha@gmail.com>
-
- 07 Feb, 2023 1 commit
-
-
Qun Cheng authored
* Update to v0.158 of the token database. * Update checkbox template * Fix DatePickerTheme test --------- Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 06 Feb, 2023 1 commit
-
-
Eilidh Southren authored
* add icon button property override * list tile changes * add imports * add newlines * whitespace
-
- 02 Feb, 2023 1 commit
-
-
Michael Goderbauer authored
* Make Flex,Row,Column const for real * dart fix --apply * fix snippets * fix integration test * add comment
-
- 25 Jan, 2023 1 commit
-
-
Taha Tesser authored
* Add Material 3 `CheckboxListTile` example and update existing examples * fix `list_tile.dart` doc issues * Remove unnecessary comma
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 19 Jan, 2023 1 commit
-
-
Taha Tesser authored
Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (#118705)
-
- 17 Jan, 2023 1 commit
-
-
Darren Austin authored
-
- 09 Jan, 2023 1 commit
-
-
Taha Tesser authored
* Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add #99933 HTML workaround.
-
- 29 Dec, 2022 1 commit
-
-
Xilai Zhang authored
This reverts commit 57fb36ee.
-
- 20 Dec, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 14 Dec, 2022 1 commit
-
-
Taha Tesser authored
* [reland] Add Material 3 support for `ListTile` - Part 1 * Update doc
-
- 12 Dec, 2022 1 commit
-
-
Hans Muller authored
This reverts commit e57b7f4e.
-
- 09 Dec, 2022 1 commit
-
-
Taha Tesser authored
* Add Material 3 support for `ListTile` - Part 1 * minor refactor * Add `useMaterial3: false` to M2 tests
-
- 29 Nov, 2022 1 commit
-
-
Mohammed CHAHBOUN authored
-
- 03 Oct, 2022 1 commit
-
-
Casey Hillers authored
-
- 30 Sep, 2022 1 commit
-
-
hangyu authored
-
- 12 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 05 Sep, 2022 1 commit
-
-
Taha Tesser authored
-
- 31 Aug, 2022 1 commit
-
-
Mohammed CHAHBOUN authored
-
- 22 Aug, 2022 1 commit
-
-
Kate Lovett authored
-
- 10 Aug, 2022 1 commit
-
-
Ian Hickson authored
-
- 13 Jul, 2022 2 commits
-
-
Taha Tesser authored
-
Taha Tesser authored
-
- 08 Jun, 2022 1 commit
-
-
Pierre-Louis authored
* Improve `useMaterial3` documentation * reverse styles and components * tweak language around support * Update theme_data.dart * remove trailing space * Update packages/flutter/lib/src/material/theme_data.dart Co-authored-by:
Darren Austin <darren@darrenaustin.org> * add missing spec links * remove spec links from useMaterial3 * move defaults section up, rejig things * spaces no longer trailing * spaces no longer trailing (2) Co-authored-by:
Darren Austin <darren@darrenaustin.org>
-
- 25 May, 2022 2 commits
-
-
Taha Tesser authored
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 27 Apr, 2022 1 commit
-
-
Pierre-Louis authored
-
- 19 Apr, 2022 1 commit
-
-
Hans Muller authored
This reverts commit 9f0bcfb8.
-
- 18 Apr, 2022 1 commit
-
-
Taha Tesser authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 07 Apr, 2022 1 commit
-
-
Taha Tesser authored
-