Commits · fde390630797f7ce7db54b048fe0acc67e8e7fad · abdullh.alsoleman / Front-End

26 Jun, 2023 3 commits

Roll Flutter Engine from 88ff46e1efc1 to be46101e952d (2 revisions) (#129540) · fde39063

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/88ff46e1efc1...be46101e952d

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from a20d58872fbe to 5ea08db08587 (1 revision) (flutter/engine#43193)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from XnZWRj5iNXgOHlVNi... to 3Y8TbEFhQUKOJBLQ4... (flutter/engine#43192)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from XnZWRj5iNXgO to 3Y8TbEFhQUKO

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fde39063

Roll Flutter Engine from 317673b3278a to 88ff46e1efc1 (1 revision) (#129534) · c7f82a1c

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/317673b3278a...88ff46e1efc1

2023-06-26 robert.ancell@canonical.com Allow event channels to reuse names (flutter/engine#41837)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7f82a1c

Roll Flutter Engine from 593e1d9a9cf5 to 317673b3278a (3 revisions) (#129531) · 8b6e1fde

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/593e1d9a9cf5...317673b3278a

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uh5om9qyypCToIllT... to GkEyRw1Q2qLZWxitD... (flutter/engine#43190)
2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 7866f2c6ba52 to a20d58872fbe (1 revision) (flutter/engine#43191)
2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from w-DJY4dBZWS7lxsxE... to XnZWRj5iNXgOHlVNi... (flutter/engine#43188)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from w-DJY4dBZWS7 to XnZWRj5iNXgO
fuchsia/sdk/core/mac-amd64 from uh5om9qyypCT to GkEyRw1Q2qLZ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b6e1fde

25 Jun, 2023 4 commits

Roll Flutter Engine from 5178e8ab7764 to 593e1d9a9cf5 (1 revision) (#129514) · b2e95013

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/5178e8ab7764...593e1d9a9cf5

2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 18a947ed2253 to 7866f2c6ba52 (1 revision) (flutter/engine#43187)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b2e95013

Roll Flutter Engine from 100f6fc854b4 to 5178e8ab7764 (1 revision) (#129508) · 42d2c2d5

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/100f6fc854b4...5178e8ab7764

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N0MQ5J5y_hQoiOYs9... to uh5om9qyypCToIllT... (flutter/engine#43185)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from N0MQ5J5y_hQo to uh5om9qyypCT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

42d2c2d5

Roll Flutter Engine from a9f446e25f0c to 100f6fc854b4 (1 revision) (#129498) · 176f7e63

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/a9f446e25f0c...100f6fc854b4

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bjQLnDu32Oj0KUbrW... to w-DJY4dBZWS7lxsxE... (flutter/engine#43184)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from bjQLnDu32Oj0 to w-DJY4dBZWS7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

176f7e63

Roll Flutter Engine from 5b1b98305768 to a9f446e25f0c (1 revision) (#129495) · c0f76fc9

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/5b1b98305768...a9f446e25f0c

2023-06-24 bdero@google.com [Impeller] Supply surface cull rect for Vulkan & GLES dispatchers (flutter/engine#43152)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c0f76fc9

24 Jun, 2023 12 commits

Roll Flutter Engine from 72c902ce3b81 to 5b1b98305768 (2 revisions) (#129493) · c442c6d4

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/72c902ce3b81...5b1b98305768

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JF0sJRpJH8KiyyqrR... to N0MQ5J5y_hQoiOYs9... (flutter/engine#43180)
2023-06-24 bdero@google.com [Impeller] Disable blending for Source blend mode (flutter/engine#43162)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JF0sJRpJH8Ki to N0MQ5J5y_hQo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c442c6d4

Roll Flutter Engine from f2976add9414 to 72c902ce3b81 (1 revision) (#129489) · 96a9773d

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/f2976add9414...72c902ce3b81

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 1826cbacd4da to 18a947ed2253 (1 revision) (flutter/engine#43178)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

96a9773d

Roll Flutter Engine from 76a5e971dc09 to f2976add9414 (1 revision) (#129487) · 6855b527

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/76a5e971dc09...f2976add9414

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b5PDBUm8Hfx-y9Hsp... to bjQLnDu32Oj0KUbrW... (flutter/engine#43177)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from b5PDBUm8Hfx- to bjQLnDu32Oj0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6855b527

Roll Flutter Engine from 79fd6beea087 to 76a5e971dc09 (1 revision) (#129483) · fd9d13c2

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/79fd6beea087...76a5e971dc09

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 050d2ad6dda3 to 1826cbacd4da (2 revisions) (flutter/engine#43175)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd9d13c2

Roll Flutter Engine from 30ac9107f2f9 to 79fd6beea087 (1 revision) (#129479) · afa4cf7e

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/30ac9107f2f9...79fd6beea087

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from w-tUP3Ia2kfAaFNW1... to JF0sJRpJH8KiyyqrR... (flutter/engine#43174)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from w-tUP3Ia2kfA to JF0sJRpJH8Ki

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

afa4cf7e

Roll Flutter Engine from ee65380bf3fd to 30ac9107f2f9 (1 revision) (#129476) · cc76ed95

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/ee65380bf3fd...30ac9107f2f9

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from ef64a8c132c4 to 050d2ad6dda3 (2 revisions) (flutter/engine#43171)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc76ed95

Roll Flutter Engine from 240a86f40781 to ee65380bf3fd (2 revisions) (#129474) · a8c68425

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/240a86f40781...ee65380bf3fd

2023-06-24 skia-flutter-autoroll@skia.org Roll ANGLE from f834ba7fdab9 to 7169dc5fe003 (1 revision) (flutter/engine#43169)
2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 3d9732b86456 to ef64a8c132c4 (6 revisions) (flutter/engine#43170)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a8c68425

Fix issues with no response bot. (#129470) · 0f006ea0
godofredoc authored Jun 24, 2023
```
This is also increasing the number of items to be evaluated on each iteration.
```
0f006ea0

Roll Flutter Engine from 5e6dcf959ea0 to 240a86f40781 (1 revision) (#129473) · e058ceb6

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/5e6dcf959ea0...240a86f40781

2023-06-24 godofredoc@google.com Add docs for magic variables. (flutter/engine#43121)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e058ceb6

Roll Flutter Engine from 550bfedc8760 to 5e6dcf959ea0 (1 revision) (#129468) · 1d5aeea4

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/550bfedc8760...5e6dcf959ea0

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 8818761fbc84 to 3d9732b86456 (4 revisions) (flutter/engine#43167)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1d5aeea4

Roll Flutter Engine from c1abd1f17ab1 to 550bfedc8760 (3 revisions) (#129466) · c39bc1d9

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/c1abd1f17ab1...550bfedc8760

2023-06-23 bdero@google.com [Impeller] Label present waiter command buffer in SurfaceMTL (flutter/engine#43165)
2023-06-23 tamird@google.com Add tmp storage capability to flutter runner (flutter/engine#43157)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from c53a952a2dab to 8818761fbc84 (5 revisions) (flutter/engine#43164)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c39bc1d9

[devicelab] Add platform view scroll benchmarks for Impeller on Android (#129455) · b898d1d2
Brandon DeRosier authored Jun 24, 2023
```
For tracking perf improvements with changes like
https://github.com/flutter/engine/pull/43152.
```
b898d1d2

23 Jun, 2023 21 commits

Roll Flutter Engine from eca910dd5e3f to c1abd1f17ab1 (3 revisions) (#129456) · 813fc3bb

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/eca910dd5e3f...c1abd1f17ab1

2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 566f1ee4657c to f834ba7fdab9 (1 revision) (flutter/engine#43158)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from d53ea1557b35 to c53a952a2dab (1 revision) (flutter/engine#43156)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VSKvLPB4DCIDvXzOA... to b5PDBUm8Hfx-y9Hsp... (flutter/engine#43155)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VSKvLPB4DCID to b5PDBUm8Hfx-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

813fc3bb

Roll Flutter Engine from f8a39cb4dc56 to eca910dd5e3f (3 revisions) (#129451) · be803a7d

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/f8a39cb4dc56...eca910dd5e3f

2023-06-23 110993981+htoor3@users.noreply.github.com [web] - Fix for Safari partially autofilling form (flutter/engine#43058)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from bc2d5ed01f27 to 566f1ee4657c (1 revision) (flutter/engine#43154)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 7b6aae68a11f to d53ea1557b35 (1 revision) (flutter/engine#43153)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

be803a7d

Roll Flutter Engine from 74ef61859bdc to f8a39cb4dc56 (2 revisions) (#129445) · 80f8bf11

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/74ef61859bdc...f8a39cb4dc56

2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 2e285bb591f7 to bc2d5ed01f27 (1 revision) (flutter/engine#43151)
2023-06-23 chinmaygarde@google.com [Impeller] FenceWaiterVK: Move potentially slow calls out of wait set mutex critical section. (flutter/engine#43131)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

80f8bf11

Add CallbackShortcuts widget of the week video (#129296) · e1e2ebd1
Loïc Sharma authored Jun 23, 2023

e1e2ebd1

Roll Flutter Engine from 060cd9c17df3 to 74ef61859bdc (3 revisions) (#129444) · b136f5f9

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/060cd9c17df3...74ef61859bdc

2023-06-23 godofredoc@google.com Remove master mirroring workflow. (flutter/engine#42681)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 07vKo_Vaiy_Vw2xxb... to w-tUP3Ia2kfAaFNW1... (flutter/engine#43148)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 9635d54210dc to 7b6aae68a11f (5 revisions) (flutter/engine#43147)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 07vKo_Vaiy_V to w-tUP3Ia2kfA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b136f5f9

Roll Flutter Engine from cd30a48ef889 to 060cd9c17df3 (3 revisions) (#129440) · fb90a49e

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/cd30a48ef889...060cd9c17df3

2023-06-23 chillers@google.com [impeller] Explicitly cast enum class to int before passing it to a formatted string (flutter/engine#43139)
2023-06-23 54558023+keyonghan@users.noreply.github.com Add osx_sdk context to mac_clang_tidy (flutter/engine#43115)
2023-06-23 jonahwilliams@google.com [Impeller] re-enable buffer to texture blit Vulkan. (flutter/engine#43129)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fb90a49e

Roll Flutter Engine from 27f3498286ff to cd30a48ef889 (4 revisions) (#129437) · 935652c3

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/27f3498286ff...cd30a48ef889

2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 04fa1c1ef69c to 9635d54210dc (2 revisions) (flutter/engine#43145)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 9211ebf1f2ac to 2e285bb591f7 (1 revision) (flutter/engine#43144)
2023-06-23 34871572+gmackall@users.noreply.github.com Add a note in ImeSyncDeferringInsetsCallback explaining the reason behind capturing the latest final inset state (flutter/engine#43109)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 6ab865ee1f65 to 04fa1c1ef69c (1 revision) (flutter/engine#43141)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

935652c3

Add a devicelab test to recipes cq. (#129411) · 929468e1

godofredoc authored Jun 23, 2023

This is to ensure the devicelab_drone recipe is tested on presubmit.

Bug: https://github.com/flutter/flutter/issues/126111

929468e1

fix: Inconsistency of SelectionArea when scrolling (#128765) · a9164a4d

Paurakh Sharma Humagain authored Jun 23, 2023

This PR fixes inconsistency of SelectionArea when scrolling by removing the `_clearSelection` on `longPressUpdate` gesture. This in turn makes the selection UX much better.

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes: https://github.com/flutter/flutter/issues/120892

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

a9164a4d

Run misc test shard when examples/api/** change (#129433) · 309e5017

Kate Lovett authored Jun 23, 2023

Fixes https://github.com/flutter/flutter/issues/129390

Found in https://github.com/flutter/flutter/pull/129381, changing sample code in `examples/api` did not trigger the misc test shard that executes the tests for `examples/api`.

309e5017

Bump ubuntu from `b795f8e` to `db8bf6f` in /dev/ci/docker_linux (#128740) · fcb54add

dependabot[bot] authored Jun 23, 2023

Bumps ubuntu from `b795f8e` to `db8bf6f`.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ubuntu&package-manager=docker&previous-version=focal&new-version=focal)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

fcb54add

Add r: timeout label to bugs/pr closed by no response bot. (#129408) · 11f1ae6f
godofredoc authored Jun 23, 2023
```
Adds r: timeout to bugs closed by inactivity.

Bug: https://github.com/flutter/flutter/issues/104962
```
11f1ae6f

Remove .github/move.yml. (#129409) · 9fa4b53c

godofredoc authored Jun 23, 2023

The file is not being used.

Bug: https://github.com/flutter/flutter/issues/129404

9fa4b53c

Roll Packages from 95bc1c6db547 to d041934b296d (6 revisions) (#129429) · 837e8e0d

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/packages/compare/95bc1c6db547...d041934b296d

2023-06-22 54558023+keyonghan@users.noreply.github.com Enforce Linux targets on VMs (flutter/packages#4268)
2023-06-22 engine-flutter-autoroll@skia.org Roll Flutter from c40baf47 to 042c0366 (20 revisions) (flutter/packages#4278)
2023-06-22 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.2.0 to 1.6.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#3331)
2023-06-22 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.mockito:mockito-core from 5.3.1 to 5.4.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4246)
2023-06-22 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230227 to 20230618 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#4245)
2023-06-22 34871572+gmackall@users.noreply.github.com [in_app_purchase_android] Bump org.mockito:mockito-core from 4.7.0 to 5.3.1 (flutter/packages#4224)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

837e8e0d

Roll Flutter Engine from aca26b2afc27 to 27f3498286ff (16 revisions) (#129421) · ef2e00c8

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/aca26b2afc27...27f3498286ff

2023-06-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 7b30bcd6207e to 81cdbe69a16b (2 revisions) (flutter/engine#43138)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 16d65289e868 to 9211ebf1f2ac (1 revision) (flutter/engine#43137)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from a94abf80dd2f to 6ab865ee1f65 (1 revision) (flutter/engine#43135)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tcVndpnH_jzGm5LsJ... to VSKvLPB4DCIDvXzOA... (flutter/engine#43134)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from ac4f52c4f7ff to 16d65289e868 (1 revision) (flutter/engine#43133)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 450bc21cc836 to a94abf80dd2f (2 revisions) (flutter/engine#43132)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 4ed2d403a329 to ac4f52c4f7ff (2 revisions) (flutter/engine#43130)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from a989b6f1aec5 to 450bc21cc836 (2 revisions) (flutter/engine#43128)
2023-06-23 dnfield@google.com Removed outdated comment from lib/ui/canvas.h (flutter/engine#43112)
2023-06-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 05d99585adab to 7b30bcd6207e (1 revision) (flutter/engine#43123)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 6595192c8352 to a989b6f1aec5 (1 revision) (flutter/engine#43120)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Ylc35wOk0_j0NLzDv... to 07vKo_Vaiy_Vw2xxb... (flutter/engine#43119)
2023-06-23 bdero@google.com [Impeller] Include CPU blends + Flutter blend reference image in goldens (flutter/engine#43117)
2023-06-23 30870216+gaaclarke@users.noreply.github.com [Impeller] Fix and reland drawPaint collapsing optimization. (flutter/engine#43097)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 5265b5ee1afc to 6595192c8352 (1 revision) (flutter/engine#43116)
2023-06-22 skia-flutter-autoroll@skia.org Roll Dart SDK from ecca5857b3ba to 05d99585adab (4 revisions) (flutter/engine#43113)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from tcVndpnH_jzG to VSKvLPB4DCID
fuchsia/sdk/core/mac-amd64 from Ylc35wOk0_j0 to 07vKo_Vaiy_V

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ef2e00c8

Add comments to .ci.yaml that were removed from recipes. (#129321) · f582c0c5

godofredoc authored Jun 23, 2023

Firebaselab recipe was cleaned up and comments removed. This is adding the still valid comments to the .ci.yaml file.

f582c0c5

Update no response to use core action. (#129405) · 3f90620a

godofredoc authored Jun 23, 2023

This is to use a maintained version of the no-response action.

Bug: https://github.com/flutter/flutter/issues/127450

3f90620a

Revert "[web] Migrate framework to fully use package:web" (#129400) · 363e2f7e

Xilai Zhang authored Jun 23, 2023

Reverts flutter/flutter#128901

context: ([cl/542712088](https://critique.corp.google.com/542712088) , [b/288495136](https://b.corp.google.com/288495136))

363e2f7e

Prepare for making `intl` `toBeginningOfSentenceCase` non-nullable (#127488) · 71228e02

Oleh Prypin authored Jun 23, 2023

I intend to edit `toBeginningOfSentenceCase`'s return value to be non-nullable because it really is never null. That will mean that non-null asserts around it will become flagged as unnecessary, although right now they are necessary. So, apply a workaround - instead use a function that does a non-null assert without triggering any lints even after it becomes unnecessary.

71228e02

[web] Hides that Flutter uses requireJS in debug. (#129032) · 34b42acf

David Iglesias authored Jun 23, 2023

Flutter web uses requireJS in `debug` mode to assemble a DDC-compiled app from a bunch of small files ("modules").

This caused that `canvaskit.js` (and all other modules that used a browserify-like loading header) didn't work because they attempted to use the `define` function provided by Flutter's instance of `requireJS` (which kept the defined modules private, rather than as globals on the page, as the users of the JS expected).

A [fix](https://github.com/flutter/engine/pull/27342) was added to `flutter/engine` to trick loaders into *not* using the `requireJS` module loader, but a recent change in the fix's js-interop layer *subtly* changed its JS output on the page (objects went from `undefined` to `null`), causing this:

* https://github.com/flutter/flutter/issues/126131 (and others)

This PR hides a bit of code that is commonly used by module loaders to decide that they may use the `define` function provided by requireJS (so the engine workaround can be removed).

## Next steps

* https://github.com/flutter/engine/pull/42941

## Issues

Partially addresses: https://github.com/flutter/flutter/issues/126131 (and others)

## Tests

* Added a unit test to ensure the `delete` stays
* Manually tested with the Gallery app in `debug` mode with a bunch of user-supplied scripts that currently fail to load.
  * Also tested hot restart as suggested by @nshahan

34b42acf

Roll Flutter Engine from 86820cbd40c5 to aca26b2afc27 (2 revisions) (#129393) · fcbc53bc

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/86820cbd40c5...aca26b2afc27

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from cb44fca83da0 to 5265b5ee1afc (4 revisions) (flutter/engine#43114)
2023-06-22 godofredoc@google.com Add missing android lint to linux_unopt. (flutter/engine#43099)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fcbc53bc