1. 02 Feb, 2017 2 commits
  2. 31 Jan, 2017 1 commit
  3. 23 Jan, 2017 1 commit
  4. 22 Jan, 2017 1 commit
  5. 09 Dec, 2016 1 commit
  6. 01 Dec, 2016 1 commit
  7. 19 Nov, 2016 1 commit
  8. 03 Nov, 2016 2 commits
  9. 17 Oct, 2016 1 commit
    • Adam Barth's avatar
      Fix DropdownButton regression (#6353) · 6399a3af
      Adam Barth authored
      When I changed how routes complete their futures, I broke the Dropdown
      button because it was still waiting for its own Completer to complete
      instead of using the Future returned by push. This patch fixes that
      issue.
      
      I've also removed the previous behavior of the DropdownButton forwarding
      its text style to its route. The mechansim that we were using doesn't
      work properly in all cases. For example, if the DropdownButton is a
      child of a LayoutBuilder, then the route will have already built by the
      time the DropdownButton gets a chance to forward its text style, causing
      an assert in setState.
      
      Finally, I've tweaked PopupMenuButton to work the same way as
      DropdownButton in a couple corner cases (e.g., not calling the changed
      callback if the button was removed from the tree before the menu
      completed its Future).
      
      Fixes #6352
      6399a3af
  10. 14 Oct, 2016 1 commit
  11. 29 Sep, 2016 1 commit
  12. 26 Sep, 2016 1 commit
    • Ian Hickson's avatar
      Turn off AnimationControllers when not in use (#5902) · 9e673853
      Ian Hickson authored
      This requires all AnimationController objects to be given a
      TickerProvider, a class that can create the Ticker.
      
      It also provides some nice mixins for people who want to have their
      State provide a TickerProvider. And a schedulerTickerProvider for those
      cases where you just want to see your battery burn.
      
      Also, we now enforce destruction order for elements.
      9e673853
  13. 21 Jun, 2016 1 commit
    • Ian Hickson's avatar
      ImageIcon (#4649) · e502e9c8
      Ian Hickson authored
      Anywhere that accepted IconData now accepts either an Icon or an
      ImageIcon.
      
      Places that used to take an IconData in an `icon` argument, notably
      IconButton and DrawerItem, now take a Widget in that slot. You can wrap
      the value that used to be passed in in an Icon constructor to get the
      same result.
      
      Icon itself now takes the icon as a positional argument, for brevity.
      
      ThemeData now has an iconTheme as well as a primaryIconTheme, the same
      way it has had a textTheme and primaryTextTheme for a while.
      
      IconTheme.of() always returns a value now (though that value itself may
      have nulls in it). It defaults to the ThemeData.iconTheme.
      
      IconThemeData.fallback() is a new method that returns an icon theme data
      structure with all fields filled in.
      
      IconTheme.merge() is a new constructor that takes a context and creates
      a widget that mixes in the new values with the inherited values.
      
      Most places that introduced an IconTheme widget now use IconTheme.merge.
      
      IconThemeData.merge and IconThemeData.copyWith act in a way analogous to
      the similarly-named members of TextStyle.
      
      ImageIcon is introduced. It acts like Icon but takes an ImageProvider
      instead of an IconData.
      
      Also: Fix the analyzer to actually check the stocks app.
      e502e9c8
  14. 07 Jun, 2016 1 commit
  15. 03 Jun, 2016 1 commit
  16. 17 May, 2016 1 commit
  17. 04 May, 2016 1 commit
  18. 03 May, 2016 1 commit
  19. 28 Apr, 2016 1 commit
  20. 22 Apr, 2016 2 commits
  21. 14 Apr, 2016 1 commit
  22. 12 Apr, 2016 1 commit
  23. 07 Apr, 2016 1 commit
  24. 06 Apr, 2016 1 commit
    • Adam Barth's avatar
      PopupMenuButton should lazily build menu items · 7ab122e5
      Adam Barth authored
      Previously, the client of PopupMenuButton needed to build all the menu times
      
      when building the PopupMenuButton. This can get expensive if, for example, each
      item in a scrollable list has a popup menu associated with it.
      
      Now the client passes a builder function to the PopupMenuButton that gets
      invoked only when its time to show the menu items.
      7ab122e5
  25. 31 Mar, 2016 1 commit
  26. 29 Mar, 2016 1 commit
  27. 18 Mar, 2016 1 commit
  28. 14 Mar, 2016 1 commit
  29. 13 Mar, 2016 1 commit
    • Adam Barth's avatar
      [rename fixit] left -> leading, right -> trailing · e48c822c
      Adam Barth authored
      The terms "left" and "right" have an LTR bias. Instead, we now use
      "leading" and "trailing", for these list and grid decorations so that
      we can later rearrange them to match the reading order.
      
      Fixes #2540
      Fixes #2548
      e48c822c
  30. 12 Mar, 2016 7 commits
  31. 11 Mar, 2016 1 commit
    • Ian Hickson's avatar
      Enable ALL THE LINTS · 1b9cd520
      Ian Hickson authored
      Well, all the easy ones, anyway.
      
      For some reason `// ignore:` isn't working for me so I've disabled
      lints that need that. Also disabled those that require a ton of work
      (which I'm doing, but not in this PR, to keep it reviewable).
      
      This adds:
      - avoid_init_to_null
      - library_names
      - package_api_docs
      - package_names
      - package_prefixed_library_names
      - prefer_is_not_empty
      - sort_constructors_first
      - sort_unnamed_constructors_first
      - unnecessary_getters_setters
      1b9cd520