- 14 Jan, 2024 1 commit
-
-
Kostia Sokolovskyi authored
-
- 26 Oct, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 05 Jul, 2023 1 commit
-
-
Snonky authored
-
- 31 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 12 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 Jan, 2022 1 commit
-
-
Konstantin Scheglov authored
-
- 07 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 10 Sep, 2021 1 commit
-
-
Jason Simmons authored
-
- 10 May, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 03 May, 2021 1 commit
-
-
Abhishek Ghaskata authored
-
- 21 Apr, 2021 1 commit
-
-
Ian Hickson authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 29 Mar, 2021 1 commit
-
- 27 Mar, 2021 1 commit
-
-
YeungKC authored
Let InkWell/Ink/ancestor support GlobalKey so that splash does not stop when changing position. (#71138)
-
- 02 Dec, 2020 1 commit
-
-
Ayush Bherwani authored
-
- 02 Nov, 2020 2 commits
-
-
Greg Spencer authored
-
Michael Goderbauer authored
-
- 16 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
* migrate material to nullsafety * address review comments * address review comments * fix build
-
- 06 Aug, 2020 1 commit
-
-
Nolan Scobie authored
* Add punctuation for unterminated sentences in doc comments * Addressing review nit
-
- 16 Jun, 2020 1 commit
-
-
Ayush Bherwani authored
-
- 11 Jun, 2020 2 commits
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
Darren Austin authored
-
- 09 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 13 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/material * address review comments
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 30 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add missing trailing commas * add more missing trailing commas * add more and more missing trailing commas
-
- 05 Sep, 2019 1 commit
-
-
Ian Hickson authored
* Minor improvements to framework documentation. * maybePop documentation fix * Mark some flutter_test arguments required. Without these set, we get a crash. * Minor correction to ListView docs
-
- 01 Mar, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add trailing commas on list/map/parameters * add trailing commas on Invocation with nb of arg>1 * add commas for widget containing widgets * add trailing commas if instantiation contains trailing comma * revert bad change
-
- 01 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-