- 22 Jan, 2015 1 commit
-
-
Adam Barth authored
Previously, if you had a generated background image and a translucent (or rounded) border, we would draw the image nine times because we would inflate the fill rect to draw behind the border. With no-repeat, we only draw the image once. This saves 4.5% of record time on flights-app. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/844193009
-
- 16 Jan, 2015 2 commits
-
-
Elliott Sprehn authored
Instead of storing primitive values which makes the data binding system throw away DOM each time we update each slot lets just use objects and shift + pop. This means very little data binding churn. R=abarth@chromium.org Review URL: https://codereview.chromium.org/802153004
-
Elliott Sprehn authored
adamk@ says these are pretty stable. R=abarth@chromium.org Review URL: https://codereview.chromium.org/845403009
-
- 15 Jan, 2015 2 commits
-
-
Elliott Sprehn authored
All reflected attributes two way bind on SkyElement, so now doing <sky-element name="sky-input" attributes="value:string"> is enough to get two way binding on the value attribute so users doing <sky-input value="{{ inputValue }}"> will get the inputValue property updated as the user types. R=abarth@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/850383002
-
Adam Barth authored
TBR=ojan@chromium.org Review URL: https://codereview.chromium.org/813133010
-
- 14 Jan, 2015 2 commits
-
-
Adam Barth authored
This CL makes some Sky demos more interesting and adds an fps-widget to see how fast they run. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/803283006
-
Adam Barth authored
We don't need this hack anymore. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/853593002
-
- 13 Jan, 2015 1 commit
-
-
Hixie authored
Specs: introduce layoutDescendants() to avoid work when a layout manager is unaffected by its childrens' intrinsic dimensions Examples: update for layoutDescendants() change Specs: add "lifetime" to resolver settings so that a transition can avoid having to dirty every consumer of the property every frame when it only needs to update the objects that are changing that frame Specs: expose the parents on AbstractStyleDeclarationList subclasses Specs: fix documentation around autoreap Specs: fix definition of setProperty() Specs: clean up the dimension-related logic of layout managers Review URL: https://codereview.chromium.org/850593003
-
- 12 Jan, 2015 1 commit
-
-
Adam Barth authored
This CL adds conversion routines for touch events to sky_viewer so that Mojo touch events actually show up in the platform. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/847873003
-
- 09 Jan, 2015 3 commits
-
-
Hixie authored
Review URL: https://codereview.chromium.org/845053002
-
Elliott Sprehn authored
Log an error whenever an element has an unknown attribute in a template. This means you can't use generic attributes like Polymer, but we probably want to discourage that anyway since attribute selectors should be avoided for most things. R=ojan@chromium.org Review URL: https://codereview.chromium.org/845523004
-
Adam Barth authored
TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/840133002
-
- 08 Jan, 2015 3 commits
-
-
Elliott Sprehn authored
Expandos make v8 sad, lets not allow them. R=ojan@chromium.org Review URL: https://codereview.chromium.org/835353004
-
Adam Barth authored
This CL contains a basic input element. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/831353003
-
Scott Violet authored
Prior to this change the magic sequence was '#!mojo:' and the url of the content handler app included mojo:. This works only for mojo: urls, but we want other schemes. So, the magic sequence is now '#!mojo ' and 'mojo ' is not part of the resulting url. R=aa@chromium.org Review URL: https://codereview.chromium.org/821403003
-
- 07 Jan, 2015 2 commits
-
-
Hixie authored
Specs: custom element constructor argument shouldn't clash with the module-global 'module' identifier Review URL: https://codereview.chromium.org/829133003
-
Eric Seidel authored
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/844443004
-
- 06 Jan, 2015 1 commit
-
-
Hixie authored
Review URL: https://codereview.chromium.org/836153005
-
- 05 Jan, 2015 1 commit
-
-
Elliott Sprehn authored
The unicode char never showed up for me, lets do what polymer does for now. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/836723006
-
- 19 Dec, 2014 1 commit
-
-
Elliott Sprehn authored
Now inside the <template> of a SkyElement you can use on-eventName="method" on any element to add event listeners. For example you can write <sky-button on-click="handleClick"> and then define handleClick(event) on the element class that contains the button. In adding this and tests I also realized that property bindings were not setup on the initial call to bind(), which is now fixed in this patch (See change to Node.prototype.bind). R=eseidel@google.com, rafaelw@chromium.org Review URL: https://codereview.chromium.org/812713005
-
- 18 Dec, 2014 2 commits
-
-
Elliott Sprehn authored
It was missing the as attribute for the SkyElement import. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/789703007
-
Eric Seidel authored
Eventually we'll want to replace these with something fancier like polymer, but this exercise helped us find several bugs in the engine as well as removed one more blocker from using Sky to replace mojo/views usage in mojo/examples. R=esprehn@chromium.org BUG=443439 Review URL: https://codereview.chromium.org/809233002
-
- 17 Dec, 2014 1 commit
-
-
Elliott Sprehn authored
The syntax for implementing a SkyElement is now: <sky-element name="element-name"> <template> <!-- template here --> </template> <script> module.exports = class extends SkyElement { attached() { // ... } // .. methods here .. }.register(); </script> </sky-element> The register() static method on SkyElement subclasses calls document.registerElement() and returns the generated constructor. It uses the parent <sky-element>'s name attribute to set the name of the element. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/788943003
-
- 02 Dec, 2014 1 commit
-
-
Rafael Weinstein authored
This patch (re)hooks up animations so they start and removes the infrastructure required by blink to synchronize the compositor and main threads. R=ojan@chromium.org Review URL: https://codereview.chromium.org/772673002
-
- 27 Nov, 2014 1 commit
-
-
Rafael Weinstein authored
TBR=esprehn Review URL: https://codereview.chromium.org/760403002
-
- 25 Nov, 2014 2 commits
-
-
Rafael Weinstein authored
TBR=esprehn Review URL: https://codereview.chromium.org/759483003
-
Rafael Weinstein authored
TBR=esprehn Review URL: https://codereview.chromium.org/758753003
-
- 21 Nov, 2014 1 commit
-
-
Adam Barth authored
This example will let us test basic animation performance. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/748853004
-
- 20 Nov, 2014 3 commits
-
-
Hixie authored
Docs: fix the hitTest() logic for display:toolbar since it doesn't use size 0x0 for its hidden children Review URL: https://codereview.chromium.org/741313002
-
Hixie authored
actually telling your child to paint, you just say where it would paint. The platform then takes care of making sure all the dirty nodes have their paint() methods called. Review URL: https://codereview.chromium.org/744843003
-
Hixie authored
Review URL: https://codereview.chromium.org/745863002
-
- 18 Nov, 2014 1 commit
-
-
Ojan Vafai authored
-Add RenderParagraph and display:paragraph. This is the only render type that's allowed to contain inlines or text. -If you put text nodes directly in a non-paragraph, wrap them in an anonymous paragraph. This may not be the place we want to end up, but it's a good stopgap to make it so we don't crash in this case. -Make StyleAdjuster force that non-paragraph blocks only contain RenderBlock subclasses and that paragraphs and inlines only contain inlines. -Considerably simplify addChildIgnoringAnonymousColumnBlocks now that we only create anonymous blocks for the case of text nodes in non-paragraphs. Also get rid of the behavior where we try to group multiple nodes into a single anonymous block. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/729693003
-
- 17 Nov, 2014 7 commits
-
-
Hixie authored
Review URL: https://codereview.chromium.org/732243002
-
Rafael Weinstein authored
TBR=esprehn BUG= Review URL: https://codereview.chromium.org/730283002
-
Hixie authored
Review URL: https://codereview.chromium.org/730273002
-
Hixie authored
Review URL: https://codereview.chromium.org/732163003
-
Hixie authored
Review URL: https://codereview.chromium.org/725203007
-
Hixie authored
Review URL: https://codereview.chromium.org/735533002
-
Hixie authored
Review URL: https://codereview.chromium.org/730223002
-
- 14 Nov, 2014 1 commit
-
-
Elliott Sprehn authored
Also add a test, this checks nested Shadow DOM and <content> with and without select. R=ojan@chromium.org Review URL: https://codereview.chromium.org/725763003
-