- 07 Oct, 2016 1 commit
-
-
Adam Barth authored
This patch adds `@checked` everywhere is needed to remove the `strong_mode_invalid_method_override` strong mode error.
-
- 26 Sep, 2016 1 commit
-
-
Ian Hickson authored
This requires all AnimationController objects to be given a TickerProvider, a class that can create the Ticker. It also provides some nice mixins for people who want to have their State provide a TickerProvider. And a schedulerTickerProvider for those cases where you just want to see your battery burn. Also, we now enforce destruction order for elements.
-
- 22 Sep, 2016 1 commit
-
-
Hans Muller authored
-
- 19 Sep, 2016 1 commit
-
-
Adam Barth authored
This name is more consistent with our other names. Fixes #4714
-
- 12 Sep, 2016 1 commit
-
-
Ian Hickson authored
This allows us to simplify the logic around inherited widgets e.g. in the Image widget.
-
- 09 Sep, 2016 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/5776
-
- 07 Sep, 2016 1 commit
-
-
Ian Hickson authored
Previously, if a StatefulWidget was marked dirty, then removed from the build, then reinserted using the exact same widget under a widget under a LayoutBuilder, it wouldn't rebuild. This fixes that. It also introduces an assert that's supposed to catch SizeObserver-like behaviour. Rather than make this patch even bigger, I papered over two pre-existing bugs which this assert uncovered (and fixed the other problems it found): https://github.com/flutter/flutter/issues/5751 https://github.com/flutter/flutter/issues/5749 We should fix those before 1.0 though.
-
- 02 Sep, 2016 1 commit
-
-
Dragoș Tiselice authored
Fixes #5393.
-
- 26 Aug, 2016 1 commit
-
-
Hans Muller authored
-
- 11 Aug, 2016 1 commit
-
-
Ian Hickson authored
Changes in this patch: - iOS now uses a different scrollDrag constant than Android. - ScrollConfigurationDelegate now knows about target platforms. - ScrollBehaviors now know about target platforms. - RawInputLine now has to be told what platform it's targetting. - PageableList now has a concept of target platform. - make debugPrintStack filter its stack. - move debugPrintStack to `assertions.dart`. - add support for limiting the number of frames to debugPrintStack. - make defaultTargetPlatform default to android in test environments. - remove OverscrollStyle and MaterialApp's overscrollStyle argument. You can now control the overscroll style using Theme.platform. - the default scroll configuration is now private to avoid people relying on the defaultTargetPlatform getter in their subclasses (since they really should use Theme.of(context).platform). - fix some typos I noticed in some tests. - added a test for flinging scrollables, that checks that the behavior differs on the two target platforms. - made flingFrom and fling in the test API pump the frames. - added more docs to the test API. - made the TestAsyncUtils.guard() method report uncaught errors to help debug errors when using that API.
-
- 04 Aug, 2016 1 commit
-
-
Adam Barth authored
This patch improves the Post and Shrine transitions by making the AppBar into a Hero and changing the default MaterialPageTransition. Now the AppBar transitions smoothly between screens and the MaterialPageTransition doesn't involve a fade effect. Also, rejigger the bounds of the image header in Pesto to avoid the "pop" at the end of the animation by laying out the image header at its final visual size instead of relying on occlusion to size the image header. Fixes #5202 Fixes #5204
-
- 29 Jul, 2016 1 commit
-
-
Hans Muller authored
-
- 28 Jul, 2016 1 commit
-
-
Hans Muller authored
-
- 23 Jun, 2016 2 commits
-
-
Hans Muller authored
-
Adam Barth authored
-
- 21 Jun, 2016 2 commits
-
-
Hans Muller authored
-
Ian Hickson authored
Anywhere that accepted IconData now accepts either an Icon or an ImageIcon. Places that used to take an IconData in an `icon` argument, notably IconButton and DrawerItem, now take a Widget in that slot. You can wrap the value that used to be passed in in an Icon constructor to get the same result. Icon itself now takes the icon as a positional argument, for brevity. ThemeData now has an iconTheme as well as a primaryIconTheme, the same way it has had a textTheme and primaryTextTheme for a while. IconTheme.of() always returns a value now (though that value itself may have nulls in it). It defaults to the ThemeData.iconTheme. IconThemeData.fallback() is a new method that returns an icon theme data structure with all fields filled in. IconTheme.merge() is a new constructor that takes a context and creates a widget that mixes in the new values with the inherited values. Most places that introduced an IconTheme widget now use IconTheme.merge. IconThemeData.merge and IconThemeData.copyWith act in a way analogous to the similarly-named members of TextStyle. ImageIcon is introduced. It acts like Icon but takes an ImageProvider instead of an IconData. Also: Fix the analyzer to actually check the stocks app.
-
- 20 Jun, 2016 1 commit
-
-
Hans Muller authored
-
- 12 Jun, 2016 1 commit
-
-
Adam Barth authored
We now use the `@required` annotation to encourage developers to explicitly set onPressed and onChanged callbacks to null when that would disable the widget. Fixes #287
-
- 08 Jun, 2016 1 commit
-
-
Ian Hickson authored
Also, make sure that the parent is notified when they change. Fixes #2298
-
- 01 Jun, 2016 1 commit
-
-
Adam Barth authored
This patch starts using the mustCallSuper annotation for several of the key lifecycle callbacks in the framework. I haven't added it to didUpdateConfig because there are a large number of non-compliant overrides. We should discuss whether we want to use it there.
-
- 31 May, 2016 1 commit
-
-
Ian Hickson authored
-
- 23 May, 2016 1 commit
-
-
Hans Muller authored
-
- 16 May, 2016 3 commits
-
-
Ian Hickson authored
This makes it possible to substitute 'flutter run' for 'flutter test' and actually watch a test run on a device. For any test that depends on flutter_test: 1. Remove any import of 'package:test/test.dart'. 2. Replace `testWidgets('...', (WidgetTester tester) {` with `testWidgets('...', (WidgetTester tester) async {` 3. Add an "await" in front of calls to any of the following: * tap() * tapAt() * fling() * flingFrom() * scroll() * scrollAt() * pump() * pumpWidget() 4. Replace any calls to `tester.flushMicrotasks()` with calls to `await tester.idle()`. There's a guarding API that you can use, if you have particularly complicated tests, to get better error messages. Search for TestAsyncUtils.
-
Ian Hickson authored
This reverts commit 55f9145e. Turns out that this commit breaks apps that use the material library, because of the _errorTextStyle DefaultTextStyle which has inherit:true. Just setting it to false doesn't work, unfortunately, because then you hit some sort of issue with merging that text style with others that have inherit:true.
-
Adam Barth authored
To make it clear that this constructor requires an explicit style. Also throw a descriptive error recommending the inherit constructor for styles with the inherit bit set. Fixes #3842
-
- 13 May, 2016 1 commit
-
-
Hans Muller authored
-
- 12 May, 2016 1 commit
-
-
pq authored
It's safe to remove the unneeded `void`s from setters since the blocking issues in the `always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/). We can also safely flip the bit on `avoid_return_types_on_setters`.
-
- 09 May, 2016 1 commit
-
-
Adam Barth authored
Fixes #417
-
- 03 May, 2016 1 commit
-
-
Adam Barth authored
Also, move the default theme transition duration into theme.dart.
-
- 29 Apr, 2016 1 commit
-
-
Adam Barth authored
Instead of incorporating the margin into the button, introduce a ButtonBar widget that supplies the proper spacing between the buttons. Also, make these buttons more configurable via ButtonTheme so that dialogs can change the minWidth and padding of the buttons as required by the spec. Fixes #1843 Fixes #3184
-
- 27 Apr, 2016 1 commit
-
-
Adam Barth authored
Rather that importing `package:newton/newton.dart` you can `import package:flutter/physics.dart`. Fixes #2441
-
- 14 Apr, 2016 1 commit
-
-
Ian Hickson authored
-
- 09 Apr, 2016 1 commit
-
-
Hans Muller authored
* Remove ScrollableListPainter
-
- 07 Apr, 2016 1 commit
-
-
Adam Barth authored
Previously, we lost sync with the tab view contents when switching tabs. Now we key the subtrees to make sure they keep their state across tab animations. Fixes #3147
-
- 05 Apr, 2016 1 commit
-
-
Hans Muller authored
-
- 01 Apr, 2016 1 commit
-
-
Adam Barth authored
-
- 31 Mar, 2016 1 commit
-
-
Adam Barth authored
Also, fill out other documentation for these widgets. Fixes #967
-
- 30 Mar, 2016 1 commit
-
-
Hans Muller authored
-
- 23 Mar, 2016 1 commit
-
-
Adam Barth authored
Previously, when the content extent changed during a scroll interaction, we'd stop the current scroll interaction and reset the scroll offset. Now we try to continue the scroll interaction (e.g., drag, fling, or overscroll) even through the underlying scroll behavior has changed. For physics-based scroll interactions, we keep the current position and velocity and recompute the operative forces. For drag interactions, we keep the current position and continue to let the user drag the scroll offset. After this patch, we still disrupt non-physical scroll animations that are operating outside the new scroll bounds because it's not clear how we can sensibly modify them to work with the new scroll bounds.
-